From: Philippe Altherr <philippe.altherr@gmail.com>
To: 60833@debbugs.gnu.org
Subject: bug#60833: [PATCH] sh-script.el: Add support for Zsh's case branches ; |.
Date: Sun, 15 Jan 2023 14:28:08 +0100 [thread overview]
Message-ID: <CAGdYchviHhiFXvOkP0+8uJnwnjZ7koeMWYKJebVEc-VmspNZ5g@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1886 bytes --]
In shell scripts, case branches traditionally end with ;;. Bash
additionally supports case branches ending with ;& and ;;&. Zsh similarly
supports case branches ending with ;& and ;|. Currently sh-script.el
supports case branches ending with ;;, ;&, and ;;&, but not with ;|. The
attached patch adds support for case branches ending with ;|.
I have tested the patch by defining all the modified functions
(sh-smie-sh-rules, sh-font-lock-paren) and constants (sh-smie-sh-grammar,
sh-smie-rc-grammar, sh-smie--sh-operators, sh-smie--sh-operators-re,
sh-smie--sh-operators-back-re) in my .emacs (in a (with-eval-after-load
'sh-script ...) statement).
Here is an example indented without the patch:
case $input in
*a* ) echo A;;
*b* ) echo B;&
*c* ) echo C;;&
*d* ) echo D;|
*e* ) echo E;;
esac
and with the (simulated) patch:
case $input in
*a* ) echo A;;
*b* ) echo B;&
*c* ) echo C;;&
*d* ) echo D;|
*e* ) echo E;;
esac
The first change in the patch replaces an (eq (char-before) ?|)
<https://github.com/emacs-mirror/emacs/blob/77ca6aa56e3425c87861cab8abce52bee3697cf4/lisp/progmodes/sh-script.el#L1045>
with
(and (eq (char-before) ?|) (not (eq (char-before (1- (point))) ?\;))). It
is needed to avoid confusing ;| tokens with plain | tokens. I wonder
however whether there would be a cleaner way of expressing the same.
The second change replaces a (looking-at ";[;&]\\|\\_<in")
<https://github.com/emacs-mirror/emacs/blob/77ca6aa56e3425c87861cab8abce52bee3697cf4/lisp/progmodes/sh-script.el#L1056>
with (looking-at ";\\(?:;&?\\|[&|]\\)\\|\\_<in"). The original expression
is looking for ;; and ;& tokens but not for ;;& tokens, which looks like an
oversight to me. That's why I have changed it to look for ;;, ;&, ;| but
also ;;&.
The other changes simply add support for ;| where there was previously
support for ;;, ;&, and ;;&.
Philippe
[-- Attachment #1.2: Type: text/html, Size: 2368 bytes --]
[-- Attachment #2: 0001-Add-support-for-Zsh-s-case-branches.patch --]
[-- Type: application/x-patch, Size: 3427 bytes --]
next reply other threads:[~2023-01-15 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 13:28 Philippe Altherr [this message]
2023-01-21 7:33 ` bug#60833: [PATCH] sh-script.el: Add support for Zsh's case branches ; | Eli Zaretskii
2023-01-23 4:13 ` Philippe Altherr
2023-01-23 15:16 ` Eli Zaretskii
[not found] ` <handler.60833.B.16737920195794.ack@debbugs.gnu.org>
2023-02-17 15:20 ` bug#60833: Acknowledgement ([PATCH] sh-script.el: Add support for Zsh's case branches ; |.) Philippe Altherr
2023-03-02 10:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGdYchviHhiFXvOkP0+8uJnwnjZ7koeMWYKJebVEc-VmspNZ5g@mail.gmail.com \
--to=philippe.altherr@gmail.com \
--cc=60833@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).