From: Philippe Vaucher <philippe.vaucher@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 24985@debbugs.gnu.org
Subject: bug#24985: Add missing provide statements
Date: Tue, 22 Nov 2016 14:58:19 +0100 [thread overview]
Message-ID: <CAGK7Mr4NTD4q2b+w_ifJeTSmXXNUa8yqqsSzsHYfhhwG9xtNOg@mail.gmail.com> (raw)
In-Reply-To: <8737ijlngz.fsf@gmx.de>
[-- Attachment #1.1: Type: text/plain, Size: 600 bytes --]
>
> > (defalias 'toggle-auto-composition 'auto-composition-mode)
> >
> > +(provide 'auto-composition-mode)
>
> Why that? I would expect (provide 'composite) here.
>
I thought that the most interesting thing in composite was
auto-composition-mode... same reasoning for replace.el which provided
'occur in my first patch.
Anyway, you're right, it's not very consistent. Here attached is a new
patch that simply follows the file name.
In the future, I think we should consider renaming/splitting these files so
each mode provide its feature (e.g occur provides 'occur, etc).
Best regards,
Philippe
[-- Attachment #1.2: Type: text/html, Size: 988 bytes --]
[-- Attachment #2: 0001-Add-missing-provide-statements.patch --]
[-- Type: text/x-patch, Size: 1458 bytes --]
From f86383d8ff683bc88a1410708d8e52a33d38fa67 Mon Sep 17 00:00:00 2001
From: Philippe Vaucher <philippe.vaucher@stvs.com>
Date: Tue, 22 Nov 2016 09:35:22 +0100
Subject: [PATCH] Add missing provide statements
* lisp/composite.el: add provide statement
* lisp/replace.el: add provide statement
* lisp/textmodes/text-mode.el: add provide statement
---
lisp/composite.el | 2 ++
lisp/replace.el | 2 ++
lisp/textmodes/text-mode.el | 2 ++
3 files changed, 6 insertions(+)
diff --git a/lisp/composite.el b/lisp/composite.el
index 94b14df..53013c1 100644
--- a/lisp/composite.el
+++ b/lisp/composite.el
@@ -843,6 +843,8 @@ For more information on Auto Composition mode, see
(defalias 'toggle-auto-composition 'auto-composition-mode)
+(provide 'composite)
+
\f
;;; composite.el ends here
diff --git a/lisp/replace.el b/lisp/replace.el
index eb5e0cf..ae1c192 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -2544,4 +2544,6 @@ It must return a string."
"")))
(or (and keep-going stack) multi-buffer)))
+(provide 'replace)
+
;;; replace.el ends here
diff --git a/lisp/textmodes/text-mode.el b/lisp/textmodes/text-mode.el
index 731c2d2..51a7bbe 100644
--- a/lisp/textmodes/text-mode.el
+++ b/lisp/textmodes/text-mode.el
@@ -232,4 +232,6 @@ The argument NLINES says how many lines to center."
(setq nlines (1+ nlines))
(forward-line -1)))))
+(provide 'text-mode)
+
;;; text-mode.el ends here
--
2.10.2
next prev parent reply other threads:[~2016-11-22 13:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 10:42 bug#24985: Add missing provide statements Philippe Vaucher
2016-11-22 12:15 ` Michael Albinus
2016-11-22 13:58 ` Philippe Vaucher [this message]
2016-11-22 15:13 ` Michael Albinus
2016-11-23 9:26 ` Philippe Vaucher
2016-11-23 9:46 ` Michael Albinus
2016-11-25 10:27 ` Eli Zaretskii
2016-11-25 11:51 ` Philippe Vaucher
2016-11-26 1:07 ` Richard Stallman
2016-11-26 7:17 ` Eli Zaretskii
2016-11-26 9:17 ` Michael Albinus
2016-11-26 10:07 ` Philippe Vaucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGK7Mr4NTD4q2b+w_ifJeTSmXXNUa8yqqsSzsHYfhhwG9xtNOg@mail.gmail.com \
--to=philippe.vaucher@gmail.com \
--cc=24985@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).