From: Paul Pogonyshev <pogonyshev@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 57800@debbugs.gnu.org
Subject: bug#57800: TRAMP insert-file-contents now fails for regions
Date: Sat, 1 Oct 2022 18:16:01 +0200 [thread overview]
Message-ID: <CAG7Bparo_qtBVaP4uo5m2m2ZsVq0C633QsUiPPywN9NxV-iwPA@mail.gmail.com> (raw)
In-Reply-To: <87czbbfu73.fsf@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]
> However, the cache doesn't keep its own version, it uses just the Tramp
> version for check.
Yeah, as long as it is not expensive, it won't hurt to throw it away
whenever Tramp version changes, even if cache format stays the same,
just to be sure.
Paul
On Sat, 1 Oct 2022 at 17:19, Michael Albinus <michael.albinus@gmx.de> wrote:
> Paul Pogonyshev <pogonyshev@gmail.com> writes:
>
> Hi Paul,
>
> > Thanks. I suggest also adding a simple "version" to the cache.
> > Whenever you make an incompatible change in the future, bump this
> > version. And also make Tramp automatically discard all cached values
> > when they come from a different (earlier or even a later) version.
> > Otherwise something like this will certainly happen again sooner or
> > later and will cost both the person bumping into it and you or whoever
> > responds to the bugreport a lot of time again.
>
> That's a good idea, thanks! I've pushed a respective change to master.
>
> However, the cache doesn't keep its own version, it uses just the Tramp
> version for check. Using an own cache version is error-prone, there are
> good chances to forget to change it when needed. At least *I* would
> forget it always, as far as I know me.
>
> > Paul
>
> Best regards, Michael.
>
[-- Attachment #2: Type: text/html, Size: 1807 bytes --]
prev parent reply other threads:[~2022-10-01 16:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 12:11 bug#57800: TRAMP insert-file-contents now fails for regions Paul Pogonyshev
2022-09-14 18:08 ` Lars Ingebrigtsen
2022-09-14 18:18 ` Paul Pogonyshev
2022-09-14 18:23 ` Lars Ingebrigtsen
2022-09-14 18:33 ` Paul Pogonyshev
2022-09-15 10:30 ` Michael Albinus
2022-09-16 9:37 ` Lars Ingebrigtsen
2022-09-29 9:24 ` Paul Pogonyshev
2022-09-29 10:43 ` Lars Ingebrigtsen
2022-09-29 11:26 ` Paul Pogonyshev
2022-09-29 11:27 ` Paul Pogonyshev
2022-09-29 17:39 ` Michael Albinus
2022-09-30 8:49 ` Paul Pogonyshev
2022-09-30 18:39 ` Michael Albinus
2022-09-30 18:52 ` Paul Pogonyshev
2022-09-30 19:11 ` Michael Albinus
2022-09-30 19:58 ` Michael Albinus
2022-09-30 20:48 ` Paul Pogonyshev
2022-10-01 15:18 ` Michael Albinus
2022-10-01 16:16 ` Paul Pogonyshev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG7Bparo_qtBVaP4uo5m2m2ZsVq0C633QsUiPPywN9NxV-iwPA@mail.gmail.com \
--to=pogonyshev@gmail.com \
--cc=57800@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).