From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Pogonyshev Newsgroups: gmane.emacs.bugs Subject: bug#56800: Pointless "Warning: desktop file appears to be in use by PID ###." Date: Wed, 27 Jul 2022 21:22:46 +0200 Message-ID: References: <838roebivp.fsf@gnu.org> <834jz2bgvr.fsf@gnu.org> <831qu6bcwh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000036035905e4ce581b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21382"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56800@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 27 21:27:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGmhG-0005QT-8b for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Jul 2022 21:27:54 +0200 Original-Received: from localhost ([::1]:48090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGmhE-0003BO-PP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Jul 2022 15:27:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGmdW-0000vo-Sd for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2022 15:24:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39075) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGmdW-0007Qv-Dm for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2022 15:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGmdW-0006U7-A2 for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2022 15:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jul 2022 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56800 X-GNU-PR-Package: emacs Original-Received: via spool by 56800-submit@debbugs.gnu.org id=B56800.165894978624844 (code B ref 56800); Wed, 27 Jul 2022 19:24:02 +0000 Original-Received: (at 56800) by debbugs.gnu.org; 27 Jul 2022 19:23:06 +0000 Original-Received: from localhost ([127.0.0.1]:57057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGmcb-0006Sd-UY for submit@debbugs.gnu.org; Wed, 27 Jul 2022 15:23:06 -0400 Original-Received: from mail-yb1-f181.google.com ([209.85.219.181]:38612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGmcZ-0006RR-C7 for 56800@debbugs.gnu.org; Wed, 27 Jul 2022 15:23:04 -0400 Original-Received: by mail-yb1-f181.google.com with SMTP id d124so14363464ybb.5 for <56800@debbugs.gnu.org>; Wed, 27 Jul 2022 12:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ov4hFA1kFwjnAApPmn5jo3Ats/+gqCW2OVEEMGo+MY8=; b=WI4eYQ2ShZazt4PdQaSMw5+5J9RzB10FvQLIMAnin9EpnM2tDEImZi44GZiHlZ+1Hh P7s9o6Wkwz6IzI9uUbG0OrURqSCj1qU5N8YvaNBj2imb4N+BP3cAyH7TqspAgs23mRw9 XpfJ8DXO57Y026eGE4vDqd2x/zZP7x/Rp8Fglg1VN/KnWsmKNrh/7JNUfLIFDdiOfo/S vdtSK0ofw6uqt5nmE7nx3XZW9ZYBqUf9nmDmIpj1B64KdqEWM+IgIDUDKA6wLgTbNk9B 9sRthtShVFsMZu8OyM3TcecMuKL8GeFatwwS/6hXZWN71gh1ABSUqqVHfzF1B13y1/8D ZJdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ov4hFA1kFwjnAApPmn5jo3Ats/+gqCW2OVEEMGo+MY8=; b=7va0K/jsm9NNyatdJOZZshQ8J9/cY4QOgZ1m+qvdpTo6jXySCPOYZGGnuauMwMbHWa RxVZlTY9Z4JBQ34hHjhoCGUhXYnAvgzPEIO/2ts6y3ebVCnttsWz2ydGX/vGuBPIB6q/ U3ynZR5Py5S8EiYytq++PsAn4XR4gu9o0/NnizXtMdns/w/XXw+k07DE1hcFG6mGfgdG +LouG8438x+dz1zOkaeZpWlaCelQcW1gyBv+D18uE2+CHDpkqrhs/n6TNX7ZjIkaiJoW HGIweapTWb0CIOvIOjDXBsVjKPfHzvs37ZSnHsWCJm4G26O9NuH3eckPJkppB976hY6L r1DA== X-Gm-Message-State: AJIora/qxobE3kAZw4qn9z02AE/e7PPmdxRIfUBjzfX/dTd0h3plI9GT nsLAf41S6biDrB526iWons0dCwhlsxG/C9SHOcUaoe/f8A== X-Google-Smtp-Source: AGRyM1ufie+y5xXIcT1gC8+SZcA8Pu7kxqWrmo1aJvX7LTtbsg3AgLs4AM9JOmdqFpcqzgWrGtdw94drS4MXjyfy1vY= X-Received: by 2002:a25:cdc7:0:b0:66f:601f:5296 with SMTP id d190-20020a25cdc7000000b0066f601f5296mr18816714ybf.170.1658949777862; Wed, 27 Jul 2022 12:22:57 -0700 (PDT) In-Reply-To: <831qu6bcwh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238059 Archived-At: --00000000000036035905e4ce581b Content-Type: multipart/alternative; boundary="00000000000036035705e4ce5819" --00000000000036035705e4ce5819 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I meant something like what is in the attached patch. The problem is that _everything_ got moved to `...-query-functions', including that part that has nothing to do with querying. Paul On Wed, 27 Jul 2022 at 20:58, Eli Zaretskii wrote: > > From: Paul Pogonyshev > > Date: Wed, 27 Jul 2022 19:52:31 +0200 > > Cc: 56800@debbugs.gnu.org > > > > Yeah, apparently `kill-emacs' is considered "low-level primitive": > > > > Functions to call with no arguments to query about killing Emacs. > > If any of these functions returns nil, killing Emacs is canceled. > > =E2=80=98save-buffers-kill-emacs=E2=80=99 calls these functions, bu= t =E2=80=98kill-emacs=E2=80=99, > > the low level primitive, does not. See also =E2=80=98kill-emacs-ho= ok=E2=80=99. > > > > Since I have rebound C-x C-c for my private use (why waste such a nice > shortcut on something used once > > in a few days?), I have been using `kill-emacs'. But apparently it's no= t > what should be used... Emacs making > > it easy to silently break things, nothing new. > > > > I suggest that `desktop-release-lock' call is still moved from somethin= g > hooked on > > `kill-emacs-query-functions' to `kill-emacs-hook'. That part is suppose= d > to be done unconditionally. > > That change was made because the hook can ask questions, which doesn't > work in a daemon session. So we moved the hook. > --00000000000036035705e4ce5819 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I meant something like what is in the attached patch. The = problem is that _everything_ got moved to `...-query-functions', includ= ing that part that has nothing to do with querying.

Paul=



On Wed, 27 Jul 2022 at 20:58, Eli Z= aretskii <eliz@gnu.org> wrote:
> From: Paul Po= gonyshev <pogo= nyshev@gmail.com>
> Date: Wed, 27 Jul 2022 19:52:31 +0200
> Cc: 56800@d= ebbugs.gnu.org
>
> Yeah, apparently `kill-emacs' is considered "low-level primit= ive":
>
>=C2=A0 =C2=A0 =C2=A0Functions to call with no arguments to query about = killing Emacs.
>=C2=A0 =C2=A0 =C2=A0If any of these functions returns nil, killing Emac= s is canceled.
>=C2=A0 =C2=A0 =C2=A0=E2=80=98save-buffers-kill-emacs=E2=80=99 calls the= se functions, but =E2=80=98kill-emacs=E2=80=99,
>=C2=A0 =C2=A0 =C2=A0the low level primitive, does not.=C2=A0 See also = =E2=80=98kill-emacs-hook=E2=80=99.
>
> Since I have rebound C-x C-c for my private use (why waste such a nice= shortcut on something used once
> in a few days?), I have been using `kill-emacs'. But apparently it= 's not what should be used... Emacs making
> it easy to silently break things, nothing new.
>
> I suggest that `desktop-release-lock' call is still moved from som= ething hooked on
> `kill-emacs-query-functions' to `kill-emacs-hook'. That part i= s supposed to be done unconditionally.

That change was made because the hook can ask questions, which doesn't<= br> work in a daemon session.=C2=A0 So we moved the hook.
--00000000000036035705e4ce5819-- --00000000000036035905e4ce581b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Followup-to-5bd04ea307-still-have-M-x-kill-emacs-rel.patch" Content-Disposition: attachment; filename="0001-Followup-to-5bd04ea307-still-have-M-x-kill-emacs-rel.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l63zutmf0 RnJvbSBlNzM4YzA2MzEyY2UzMmY5MmFjZDYyY2RhZDlkODM0MjQ1MWJkNzM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIFBvZ29ueXNoZXYgPHBvZ29ueXNoZXZAZ21haWwuY29t PgpEYXRlOiBXZWQsIDI3IEp1bCAyMDIyIDIxOjIwOjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g Rm9sbG93dXAgdG8gNWJkMDRlYTMwNzogc3RpbGwgaGF2ZSBgTS14IGtpbGwtZW1hY3MnIHJlbGVh c2UKIGRlc2t0b3AgbG9jawoKLS0tCiBsaXNwL2Rlc2t0b3AuZWwgfCAxMiArKysrKysrKystLS0K IDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvbGlzcC9kZXNrdG9wLmVsIGIvbGlzcC9kZXNrdG9wLmVsCmluZGV4IDg1MGQyYTg2ZWYu LmEwOTMxZTA1M2UgMTAwNjQ0Ci0tLSBhL2xpc3AvZGVza3RvcC5lbAorKysgYi9saXNwL2Rlc2t0 b3AuZWwKQEAgLTc5MSw3ICs3OTEsMTAgQEAgZGVza3RvcC1jbGVhcgogCiA7OyAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCiAodW5sZXNzIG5vbmludGVyYWN0aXZlCi0gIChhZGQtaG9vayAna2lsbC1lbWFj cy1xdWVyeS1mdW5jdGlvbnMgIydkZXNrdG9wLWtpbGwpKQorICAoYWRkLWhvb2sgJ2tpbGwtZW1h Y3MtcXVlcnktZnVuY3Rpb25zICMnZGVza3RvcC1raWxsKQorICA7OyBDZXJ0YWluIHRoaW5ncyBz aG91bGQgYmUgZG9uZSBldmVuIGlmCisgIDs7IGBraWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9ucycg YXJlIG5vdCBjYWxsZWQuCisgIChhZGQtaG9vayAna2lsbC1lbWFjcy1ob29rICMnZGVza3RvcC0t b24ta2lsbCkpCiAKIChkZWZ1biBkZXNrdG9wLWtpbGwgKCkKICAgIklmIGBkZXNrdG9wLXNhdmUt bW9kZScgaXMgbm9uLW5pbCwgZG8gd2hhdCBgZGVza3RvcC1zYXZlJyBzYXlzIHRvIGRvLgpAQCAt ODE4LDEyICs4MjEsMTUgQEAgZGVza3RvcC1raWxsCiAgICAgICAoZmlsZS1lcnJvcgogICAgICAg ICh1bmxlc3MgKHllcy1vci1uby1wICJFcnJvciB3aGlsZSBzYXZpbmcgdGhlIGRlc2t0b3AuICBJ Z25vcmU/ICIpCiAJIChzaWduYWwgKGNhciBlcnIpIChjZHIgZXJyKSkpKSkpCisgIChkZXNrdG9w LS1vbi1raWxsKQorICB0KQorCisoZGVmdW4gZGVza3RvcC0tb24ta2lsbCAoKQogICA7OyBJZiB3 ZSBvd24gaXQsIHdlIGRvbid0IGFueW1vcmUuCiAgICh3aGVuIChlcSAoZW1hY3MtcGlkKSAoZGVz a3RvcC1vd25lcikpCiAgICAgOzsgQWxsb3cgZXhpdGluZyBFbWFjcyBldmVuIGlmIHdlIGNhbid0 IGRlbGV0ZSB0aGUgZGVza3RvcCBmaWxlLgogICAgIChpZ25vcmUtZXJyb3IgJ2ZpbGUtZXJyb3IK LSAgICAgIChkZXNrdG9wLXJlbGVhc2UtbG9jaykpKQotICB0KQorICAgICAgKGRlc2t0b3AtcmVs ZWFzZS1sb2NrKSkpKQogCiA7OyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAoZGVmdW4gZGVza3RvcC1s aXN0KiAoJnJlc3QgYXJncykKLS0gCjIuMzUuMQoK --00000000000036035905e4ce581b--