From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Pogonyshev Newsgroups: gmane.emacs.bugs Subject: bug#18128: Diff-mode doesn't refine hunks automatically Date: Mon, 28 Jul 2014 16:45:39 +0200 Message-ID: References: <83d2cph81y.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b472078033b8404ff41fa36 X-Trace: ger.gmane.org 1406558788 20413 80.91.229.3 (28 Jul 2014 14:46:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Jul 2014 14:46:28 +0000 (UTC) Cc: 18128@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 28 16:46:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XBmBt-0000xl-Ne for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Jul 2014 16:46:17 +0200 Original-Received: from localhost ([::1]:40107 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBmBr-0001dZ-8C for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Jul 2014 10:46:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBmBk-0001dS-4X for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 10:46:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBmBe-0002Qo-TN for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 10:46:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBmBe-0002Qg-PX for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 10:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XBmBe-0004wd-GN for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 10:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jul 2014 14:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18128 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18128-submit@debbugs.gnu.org id=B18128.140655874818982 (code B ref 18128); Mon, 28 Jul 2014 14:46:02 +0000 Original-Received: (at 18128) by debbugs.gnu.org; 28 Jul 2014 14:45:48 +0000 Original-Received: from localhost ([127.0.0.1]:40911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBmBP-0004w5-Fg for submit@debbugs.gnu.org; Mon, 28 Jul 2014 10:45:47 -0400 Original-Received: from mail-oa0-f46.google.com ([209.85.219.46]:65465) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBmBN-0004vr-0E for 18128@debbugs.gnu.org; Mon, 28 Jul 2014 10:45:45 -0400 Original-Received: by mail-oa0-f46.google.com with SMTP id m1so8762746oag.5 for <18128@debbugs.gnu.org>; Mon, 28 Jul 2014 07:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=sWv+WWR6SPLLH90hy9z5OpuRWbC89yxagobVUsY+DCg=; b=06oervEBNmDes+0myQPiAPpNHlNnXtxgNzLKuYvvN7WtImEkuS7Rs0s4aOcIZH6eSA 1DpK9beS2h0DuQTN78XyC2JB9GfjGX+IXjvcBNCQxr16LP20G6co5AqA5f6yD/CjMETi pjDgZHgysxyK49VU+Xbw33AHQmeRznrR7DOonHAFKBDz8Dl4QHK2xYYXNyGMKeCG2ISo +3Ia3cjG/TjnNWu7bFUoSjO+QaS2KCfc5MX051TFfqmcgdWj/XWEueTxLT0GafJah+m1 GbmYZ6CSSpXGxOT0xruvdKWMOaYBmrwAcSypPQsGbiZPVDyQNPCA8oLJwQaOyXQEB1Pv cm1Q== X-Received: by 10.60.133.233 with SMTP id pf9mr50598472oeb.30.1406558739314; Mon, 28 Jul 2014 07:45:39 -0700 (PDT) Original-Received: by 10.182.162.67 with HTTP; Mon, 28 Jul 2014 07:45:39 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91889 Archived-At: --047d7b472078033b8404ff41fa36 Content-Type: text/plain; charset=UTF-8 Actually, it seems it is not enough. My usecase: I open a fairly large diff file with many changes like -bla bla bla a long line were some word was changed or maybe two +bla bla bla a long line where some word was changed or maybe two I want to be able to immediately see the changes, without reading whole lines and certainly without visiting the hunks. When Emacs highlights the change (there is only one above), I see it right away. Otherwise I have to scan the lines with my eyes, which is tedious and error-prone. Of course I can also hit C-c C-b on each hunk, but it feels like some sort of work I'd prefer Emacs do for me. Paul On 28 July 2014 16:39, Paul Pogonyshev wrote: > It is enough. Then please add a reference to it to documentation of > diff-refine-hunk, I wasn't even aware of that mode. > > Paul > > > On 28 July 2014 16:28, Eli Zaretskii wrote: > >> > Date: Mon, 28 Jul 2014 15:59:12 +0200 >> > From: Paul Pogonyshev >> > >> > Diff-mode should just refine hunks automatically when visiting a >> buffer. If >> > it is a performance concern, there should be some customization option >> for >> > it and/or this could be done lazily. >> > >> > Chunk refining is just too useful to not have. >> >> Why isn't diff-auto-refine-mode enough? >> > > --047d7b472078033b8404ff41fa36 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Actually, it seems it is not enough. My use= case: I open a fairly large diff file with many changes like

-= bla bla bla a long line were some word was changed or maybe two
+bla bla= bla a long line where some word was changed or maybe two

I want to be able to immediately see the changes, without reading= whole lines and certainly without visiting the hunks. When Emacs highlight= s the change (there is only one above), I see it right away. Otherwise I ha= ve to scan the lines with my eyes, which is tedious and error-prone. Of cou= rse I can also hit C-c C-b on each hunk, but it feels like some sort of wor= k I'd prefer Emacs do for me.

Paul


On 28 July 2014 16:39, Paul Pogonyshev <pogonyshev@gmail.com= > wrote:
It is enough. Then ple= ase add a reference to it to documentation of diff-refine-hunk, I wasn'= t even aware of that mode.
Paul=


On 28 July 2014 16:28, Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Mon, 28 Jul 2014 15:59:12 +0200
> From: Paul Pogonyshev <pogonyshev@gmail.com>
>
> Diff-mode should just refine hunks automatically when visiting a buffe= r. If
> it is a performance concern, there should be some customization option= for
> it and/or this could be done lazily.
>
> Chunk refining is just too useful to not have.

Why isn't diff-auto-refine-mode enough?


--047d7b472078033b8404ff41fa36--