From: Paul Pogonyshev <pogonyshev@gmail.com>
To: 26177@debbugs.gnu.org
Subject: bug#26177: pcase spams me with useless and cryptic messages intended for internal use
Date: Sun, 19 Mar 2017 22:54:43 +0100 [thread overview]
Message-ID: <CAG7BpapKmX5qXMuWwqBmfMiFWiZxf1nESNgrhF8+qN+9xu4TAw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
To reproduce, evaluate this:
(defmacro kek (&rest more-cases)
`(pcase it
(`foo 1)
,@more-cases))
(defun lol (x)
(--each x
(kek))
(--each x
(kek (`baz 3))))
Observe that there is "pcase-memoize: equal first branch, yet
different" gibberish in *Messages* buffer.
Attached patch comments out this debug output.
[-- Attachment #2: silence-pcase.diff --]
[-- Type: text/plain, Size: 783 bytes --]
diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el
index 289265abf2..fc5474ecc4 100644
--- a/lisp/emacs-lisp/pcase.el
+++ b/lisp/emacs-lisp/pcase.el
@@ -175,8 +175,8 @@ Emacs Lisp manual for more information and examples."
;; (when (gethash (car cases) pcase--memoize-2)
;; (message "pcase-memoize failed because of eq test on %S"
;; (car cases)))
- (when data
- (message "pcase-memoize: equal first branch, yet different"))
+ ;; (when data
+ ;; (message "pcase-memoize: equal first branch, yet different"))
(let ((expansion (pcase--expand exp cases)))
(puthash (car cases) `(,exp ,cases ,@expansion) pcase--memoize)
;; (puthash (car cases) `(,exp ,cases ,@expansion) pcase--memoize-1)
next reply other threads:[~2017-03-19 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 21:54 Paul Pogonyshev [this message]
2017-03-25 22:47 ` bug#26177: Paul Pogonyshev
2017-03-25 23:31 ` bug#26177: npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG7BpapKmX5qXMuWwqBmfMiFWiZxf1nESNgrhF8+qN+9xu4TAw@mail.gmail.com \
--to=pogonyshev@gmail.com \
--cc=26177@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).