From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Pogonyshev Newsgroups: gmane.emacs.bugs Subject: bug#57800: TRAMP insert-file-contents now fails for regions Date: Fri, 30 Sep 2022 22:48:29 +0200 Message-ID: References: <87fsgt4ynq.fsf@gnus.org> <875yhp4xyf.fsf@gnus.org> <87h719j5g6.fsf@gmx.de> <87sfkry80u.fsf@gnus.org> <87o7uyihq6.fsf@gnus.org> <87v8p6hyg4.fsf@gmx.de> <87r0zsiu5h.fsf@gmx.de> <87mtagisnt.fsf@gmx.de> <87h70ofxck.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000757ab405e9eb1e86" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8699"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57800-done@debbugs.gnu.org, Lars Ingebrigtsen To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 30 22:49:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oeMwa-00020E-7g for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Sep 2022 22:49:12 +0200 Original-Received: from localhost ([::1]:38524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oeMwZ-0003nT-4b for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Sep 2022 16:49:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeMwR-0003n6-5I for bug-gnu-emacs@gnu.org; Fri, 30 Sep 2022 16:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oeMwQ-0008Ij-TZ for bug-gnu-emacs@gnu.org; Fri, 30 Sep 2022 16:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oeMwQ-0004Kj-FQ for bug-gnu-emacs@gnu.org; Fri, 30 Sep 2022 16:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Sep 2022 20:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57800 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 57800-done@debbugs.gnu.org id=D57800.166457092916636 (code D ref 57800); Fri, 30 Sep 2022 20:49:02 +0000 Original-Received: (at 57800-done) by debbugs.gnu.org; 30 Sep 2022 20:48:49 +0000 Original-Received: from localhost ([127.0.0.1]:43035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeMwC-0004KF-Oh for submit@debbugs.gnu.org; Fri, 30 Sep 2022 16:48:49 -0400 Original-Received: from mail-ej1-f52.google.com ([209.85.218.52]:37413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeMwB-0004K1-5K for 57800-done@debbugs.gnu.org; Fri, 30 Sep 2022 16:48:47 -0400 Original-Received: by mail-ej1-f52.google.com with SMTP id a26so11425438ejc.4 for <57800-done@debbugs.gnu.org>; Fri, 30 Sep 2022 13:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=KGDA41b5K3HiBrHVoIc+sZhaP5vvQB4D8cWoXiCoozA=; b=XCrNBL4tN2Br6j5FeFgKEjI+tkHDeFea7gJn8yECSuXBYpa4Q/YGM78EodxCsWLMf9 xr5foq8711pA0gx0pOngAigVLRgJnns6IwRtM2MhgwpnEsPFbud/j0oUxwNmn3P50VDv 6jMKc9F0D0mC+M3b9ZqERZiiqe1dOuE/SeSEuz8jQKa7kWFMF+K980Xi5clNQvxTfhGG Zdqt4IINDcKraM/MNLGzI56/bvolEgfoRtdMN8jHeWjqW2GiztEulcz0SIsBL9aI5QTl jok4KS9hUfBcWc8+T2r/+EQMy8QmnrJRonDCfTCPduEQIcH926Km+O7zRGUbwbU2i/XV 3Ang== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=KGDA41b5K3HiBrHVoIc+sZhaP5vvQB4D8cWoXiCoozA=; b=mfzGQPknYfjLbrSdQajeyLwaytn9viADEEi/zDUFoHx7ytsrkXxP9YqK9N3s0B6kO0 qkj4S2Ab+AOPb31J3z9suK4/KKeUCWlQ9Q5962hNNUsrqPz3Z6QJ9xdNk2JCR3Uc3oln +RZ3YGFGeNCypgUwuStUGFcE41i1j6vPRPjF9Vk2190LoR6FYwIhzWN1dmtsANPo5vLQ noemwFLiAD/tnUPkmKo9su2LwGXTIzvM5uDlFFKq987N10josxtSfCFbukxRoGx4bQOT DXK/SuLG3WCLK+vkIG6LZdlpGcA3a8vpc9EoEvjcQKMf3Lt8w7AJcEfZ8XicgFQI0o5C ryaw== X-Gm-Message-State: ACrzQf0Pymfi1Iq5BI8RcYEpvm/pr+KDZp6sLNwDlctqB+xdKU5CFxEl 5mD2CAoMHvMnqFqhIkwzO1htohsAbMSwkKatNg== X-Google-Smtp-Source: AMsMyM6NxqlgVje5p0C5h23SZrkm46V+KwJMOvHO+VGKO3pC31Hz8sw7J6xYHX9n9qeAOsqoHFs0Yi/sJ8uiNzwk9Lo= X-Received: by 2002:a17:907:6d28:b0:782:32ad:7b64 with SMTP id sa40-20020a1709076d2800b0078232ad7b64mr8247102ejc.23.1664570921153; Fri, 30 Sep 2022 13:48:41 -0700 (PDT) In-Reply-To: <87h70ofxck.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244062 Archived-At: --000000000000757ab405e9eb1e86 Content-Type: text/plain; charset="UTF-8" Thanks. I suggest also adding a simple "version" to the cache. Whenever you make an incompatible change in the future, bump this version. And also make Tramp automatically discard all cached values when they come from a different (earlier or even a later) version. Otherwise something like this will certainly happen again sooner or later and will cost both the person bumping into it and you or whoever responds to the bugreport a lot of time again. Paul On Fri, 30 Sept 2022 at 21:58, Michael Albinus wrote: > Version: 29.1 > > Michael Albinus writes: > > Hi Paul, > > >> Yes, that fixes the problem. Does that mean I somehow have a mixup of > >> sources from different commits (not sure how) or that the cache is > >> persistent and can survive long times? Note that I also run Emacs 28 > >> from time to time. Could it be that 29 reuses cache created by 28 that > >> contains no-longer-compatible values? > > > > Could be the latter, yes. "tmpdir" is the only cache value I know of > > which has changed its meaning(*). Perhaps I shall add a test that it > > ignores cached "tmpdir" values if they are remote. But hmm, it has > > changed its meaning also in Tramp 2.5.3.2, which is distributed via GNU > > ELPA. > > Pushed this change to the emacs-28 branch, it will appear in the master > branch after merge. > > It will also be contained in the upcoming Tramp 2.5.3.4 on GNU > ELPA. Closing the bug. > > >> Paul > > Best regards, Michael. > --000000000000757ab405e9eb1e86 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks. I suggest also adding a simple "version&= quot; to the cache. Whenever you make an incompatible change in the future,= bump this version. And also make Tramp automatically discard all cached va= lues when they come from a different (earlier or even a later) version. Oth= erwise something like this will certainly happen again sooner or later and = will cost both the person bumping into it and you or whoever responds to th= e bugreport a lot of time again.

Paul
<= br>
On Fri,= 30 Sept 2022 at 21:58, Michael Albinus <michael.albinus@gmx.de> wrote:
Version: 29.1

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Paul,

>> Yes, that fixes the problem. Does that mean I somehow have a mixup= of
>> sources from different commits (not sure how) or that the cache is=
>> persistent and can survive long times? Note that I also run Emacs = 28
>> from time to time. Could it be that 29 reuses cache created by 28 = that
>> contains no-longer-compatible values?
>
> Could be the latter, yes. "tmpdir" is the only cache value I= know of
> which has changed its meaning(*). Perhaps I shall add a test that it > ignores cached "tmpdir" values if they are remote. But hmm, = it has
> changed its meaning also in Tramp 2.5.3.2, which is distributed via GN= U
> ELPA.

Pushed this change to the emacs-28 branch, it will appear in the master
branch after merge.

It will also be contained in the upcoming Tramp 2.5.3.4 on GNU
ELPA. Closing the bug.

>> Paul

Best regards, Michael.
--000000000000757ab405e9eb1e86--