bug#36932: 25.2; vc-rename-file does NOT handle ~ in paths

bug#36932: 25.2; vc-rename-file does NOT handle ~ in paths

[Christian Seberino]

[-- Attachment #1: Type: text/plain, Size: 5543 bytes --]

----------------------------------------------------------------------------------------------------------------
To recreate problem:
----------------------------------------------------------------------------------------------------------------

1. "emacs -q some_file"  where some_file is a file in a directory under
version control.
           ( verified this bug with Mercurial.)
2. M-x vc-rename-file
3. Select a file to rename by appending to the current directory path shown.
4. Select new file path and name.

----------------------------------------------------------------------------------------------------------------
Problem
----------------------------------------------------------------------------------------------------------------

The above steps will lead to a new windows displaying the file path name
trying
to change with the following error after it:

No such file or directory
abort: no files to copy


------------------------

The problem goes away if the ~ is removed from the original file path in
step #3 above.
Ironically, ~ is ok in step #4 above.






In GNU Emacs 25.2.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.21)
 of 2017-09-22, modified by Debian built on lgw01-amd64-050
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Ubuntu 18.04.1 LTS

Configured using:
 'configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.2/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --build x86_64-linux-gnu
 --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.2/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-x=yes --with-x-toolkit=gtk3
 --with-toolkit-scroll-bars 'CFLAGS=-g -O2
 -fdebug-prefix-map=/build/emacs25-jYekUr/emacs25-25.2+1=.
-fstack-protector-strong
 -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time
 -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Loading 00debian-vars...done
Loading /etc/emacs/site-start.d/50autoconf.el (source)...done
Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)...
Loading debian-ispell...
Loading /var/cache/dictionaries-common/emacsen-ispell-default.el
(source)...done
Loading debian-ispell...done
Loading /var/cache/dictionaries-common/emacsen-ispell-dicts.el
(source)...done
Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)...done
Loading /etc/emacs/site-start.d/50python-docutils.el (source)...done
For information about GNU Emacs and the GNU system, type C-h C-a.
vc-do-command: Running hg mv ~/Ws/Wb/erase/pp2 pp3...FAILED (status 255)

Load-path shadows:
/usr/share/emacs/25.2/site-lisp/debian-startup hides
/usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs/site-lisp/rst hides
/usr/share/emacs/25.2/lisp/textmodes/rst

Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu
mail-prsvr mail-utils vc cl-loaddefs pcase cl-lib vc-dispatcher vc-hg
time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote dbusbind inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 93065 8742)
 (symbols 48 20393 0)
 (miscs 40 775 146)
 (strings 32 16682 4987)
 (string-bytes 1 489323)
 (vectors 16 13009)
 (vector-slots 8 449947 6218)
 (floats 8 168 108)
 (intervals 56 287 0)
 (buffers 976 20))

[-- Attachment #2: Type: text/html, Size: 6397 bytes --]

bug#36932: Just tested and this vc-rename-file bug only applies to Mercurial! Git works fine with ~!

[Christian Seberino]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Just tested and this vc-rename-file bug only applies to Mercurial!  Git
works fine with ~!

[-- Attachment #2: Type: text/html, Size: 239 bytes --]

bug#36932: 25.2; vc-rename-file does NOT handle ~ in paths

[Lars Ingebrigtsen]

Christian Seberino <cseberino@gmail.com> writes:

> 1. "emacs -q some_file"  where some_file is a file in a directory under version
> control.
>            ( verified this bug with Mercurial.)
> 2. M-x vc-rename-file
> 3. Select a file to rename by appending to the current directory path shown.
> 4. Select new file path and name.

Christian Seberino <cseberino@gmail.com> writes:

> Just tested and this vc-rename-file bug only applies to Mercurial!  Git works fine
> with ~!

Thanks for a clear case to reproduce the bug.  This should now be fixed
in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no