unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: yary <not.com@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 15577 <15577@debbugs.gnu.org>
Subject: bug#15577: 24.3; dir-local variables not applied when switching major-mode
Date: Mon, 14 Oct 2013 14:41:34 -0400	[thread overview]
Message-ID: <CAG2CFAYTycdF2gzs-XgpvafB3gNEwCvJ_yM2MyUo_V2DqTAEXQ@mail.gmail.com> (raw)
In-Reply-To: <CAG2CFAZUNFj8my2iS6MXPH4o-MxkWVbOvd2J-M_RSW4UB1jH2w@mail.gmail.com>

Thinking about switching major modes more, my instinct is that the
right solution involves being "smarter" both about which local
variables to clear and reloading any {dir,file}-local variables for
the new node.

Basically, at the start, instead of calling
"kill-all-local-variables", only clear the locals that were set as a
consequence of the old mode. That is, if it was set directly by the
old mode, or by dir-local matching the old mode, delete it. Don't
delete a buffer-local variable if it was set explicitly by the user
after opening during the editing session.

Then after the new mode has set itself, recheck dir-locals and set any
that match the new mode.

Alas I don't use file-locals so am not sure how their use cases fit.
Ignore any "mode:" specifiers and maybe "eval:" as well after the
mode-change, I'd guess.





  reply	other threads:[~2013-10-14 18:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09 20:14 bug#15577: 24.3; dir-local variables not applied when switching major-mode yary
2013-10-09 21:42 ` Glenn Morris
2013-10-10 18:34   ` yary
2013-10-10 21:27     ` Glenn Morris
2013-10-10 21:52       ` Stefan Monnier
2013-10-10 23:12         ` yary
2013-10-14 18:41           ` yary [this message]
2013-10-16 14:26             ` yary
2013-10-18 15:43               ` yary
2013-10-19  1:18                 ` Stefan Monnier
2013-10-19 19:08                   ` yary
2013-10-19 21:55                     ` Stefan Monnier
2013-10-20 13:00                       ` yary
2013-10-20 13:38                         ` Phil Sainty
2013-10-21 13:11                           ` Stefan Monnier
2013-10-21 13:23                             ` yary
2013-10-21 14:23                               ` Stefan Monnier
2013-10-21 21:58                                 ` Phil Sainty
2013-10-18 16:29               ` Phil Sainty
     [not found] ` <mailman.3789.1381430919.10748.bug-gnu-emacs@gnu.org>
2016-05-05 11:26   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAG2CFAYTycdF2gzs-XgpvafB3gNEwCvJ_yM2MyUo_V2DqTAEXQ@mail.gmail.com \
    --to=not.com@gmail.com \
    --cc=15577@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).