From: Kaushal Modi <kaushal.modi@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31828@debbugs.gnu.org
Subject: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome
Date: Thu, 14 Jun 2018 11:59:27 -0400 [thread overview]
Message-ID: <CAFyQvY3zEo5_2cBcHOrVQYFqnhOtcdXAs8P5SfJF=OtPWGJZxg@mail.gmail.com> (raw)
In-Reply-To: <83d0wt2wgi.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
The rationale is because I ended up with this error:
> Symbol’s function definition is void: browse-url-chrome
:)
Then looking up in lisp/net/browse-url.el, I saw that all browse-url-*
functions had an autoload except for browse-url-chrome.
So it looked like a clear oversight. Is that correct?
On Thu, Jun 14, 2018 at 11:56 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Kaushal Modi <kaushal.modi@gmail.com>
> > Date: Thu, 14 Jun 2018 11:43:34 -0400
> >
> > From f6c6f9bb0b5aeab89817ee18d738ee54daada9a3 Mon Sep 17 00:00:00 2001
> > From: Kaushal Modi <kaushal.modi@gmail.com>
> > Date: Thu, 14 Jun 2018 11:41:35 -0400
> > Subject: [PATCH] Add missing autoload for browse-url-chrome
> >
> > * lisp/net/browse-url.el (browse-url-chrome): Add autoload cookie.
>
> No rationale?
>
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 1508 bytes --]
next prev parent reply other threads:[~2018-06-14 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 15:43 bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome Kaushal Modi
2018-06-14 15:56 ` Eli Zaretskii
2018-06-14 15:59 ` Kaushal Modi [this message]
2018-06-14 17:54 ` Eli Zaretskii
2018-06-14 17:59 ` Kaushal Modi
2018-06-15 10:41 ` Noam Postavsky
2019-05-15 4:27 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY3zEo5_2cBcHOrVQYFqnhOtcdXAs8P5SfJF=OtPWGJZxg@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=31828@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).