From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#19717: 24.4.50; printing.el still uses ps-eval-switch Date: Wed, 11 May 2016 17:08:21 +0000 Message-ID: References: <87wq4667tb.fsf@yale.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113d4e56545a070532941714 X-Trace: ger.gmane.org 1462986560 20573 80.91.229.3 (11 May 2016 17:09:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 May 2016 17:09:20 +0000 (UTC) To: 19717@debbugs.gnu.org, jorge.alfaro-murillo@yale.edu, Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 11 19:09:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b0XdI-0001R3-FQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2016 19:09:12 +0200 Original-Received: from localhost ([::1]:53295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0XdH-0008OY-KN for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2016 13:09:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0XdC-0008En-OD for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 13:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0Xd8-0000Lq-Ch for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 13:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0Xd8-0000LM-8U for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 13:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b0Xd7-0005Rf-Im for bug-gnu-emacs@gnu.org; Wed, 11 May 2016 13:09:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87wq4667tb.fsf@yale.edu> Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 May 2016 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19717 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19717-submit@debbugs.gnu.org id=B19717.146298651920892 (code B ref 19717); Wed, 11 May 2016 17:09:01 +0000 Original-Received: (at 19717) by debbugs.gnu.org; 11 May 2016 17:08:39 +0000 Original-Received: from localhost ([127.0.0.1]:47597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0Xck-0005Qt-Vs for submit@debbugs.gnu.org; Wed, 11 May 2016 13:08:39 -0400 Original-Received: from mail-oi0-f68.google.com ([209.85.218.68]:32796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0Xcj-0005Qh-5r for 19717@debbugs.gnu.org; Wed, 11 May 2016 13:08:37 -0400 Original-Received: by mail-oi0-f68.google.com with SMTP id t140so4981917oie.0 for <19717@debbugs.gnu.org>; Wed, 11 May 2016 10:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=qxEUwGiJgNp8eHqRNfcvrdTPocIX9k22F4uDTQsuK5Y=; b=DGudObURtkXfS+pUzitwP0ePIixvtzYdkw0xTT+J3C7L+L7jbE8+gArumP1Kf+jZCA fejo+j+cdxvEjWIvqkwsZ/RtF+HdlwzeQYJMgAKiWyRURtEkrZoXLIIIf6yxbeS/NC01 OFlGeliLGQXsXbMvHKdatGZMkLZ56Bl6CbGnwtHwJ34cC9oEvfCGi7bWy+6CfAqR5b4q HCHiFHC5haLwe+BdEixZcnKi0GkCBXmJvjHj657o4lww9pl5MGYCPaP/i9SObjWOk4Gw Lpu35V7oS2dwk7czvikEoljnSlShd0FWz00aFpwS5NQ/Rb+WANutySq5A0TL4u4WLt3a vHPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qxEUwGiJgNp8eHqRNfcvrdTPocIX9k22F4uDTQsuK5Y=; b=H8Z1uLm4uqtTQS8HdXlGI6NK71vbyCZ3AUNe8iocZtvCGkFNkApAwJcyp2v1zK4uCY zPWZ54jqlF0M54KJVSMCQ19CzO1AP+IRgV+xatWBT9in92MwvSkFWrD4o0LRKOsfyfwT d9bOvSCPves/rw910h5D7ZeKfO7uKhWpqN09zZKxdxeojKQYUDpKfz5ZClCDlJGE2p43 uA1Rz0qQLVlb2Nl6UyCrF9A+z8eBBx2iCLNbjtpi0vs9id3lZiFl+2lX/R1Kuj6aZvg1 E2UTwBg0Nt5lkcHmqG5q8oJ0fn0XPAYbhVdGL1T+RIeOPRvdX46RgzbWietz0inNvEQa iE2A== X-Gm-Message-State: AOPr4FW0mqF1oQ+3ylBGWly5Y7HFJbVH8HfysF6BoOP/nc8jrpPRpytLUWg0XyaEcVEmIvm2+jZgGr7AJigBJQ== X-Received: by 10.202.225.84 with SMTP id y81mr2744556oig.125.1462986511503; Wed, 11 May 2016 10:08:31 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118136 Archived-At: --001a113d4e56545a070532941714 Content-Type: text/plain; charset=UTF-8 Hi, I have attached the below patch in an attempt to fix this. I notice that printing.el requires lpr.el, and pr-switches function anyways uses lpr-flatten-list from lpr.el. So there should be no harm using lpr-eval-switch instead of ps-eval-switch. I have verified that lpr-eval-switch is the exact same function as the now obsolete ps-eval-switch; just different names. Copying Stefan for reviewing and commiting this patch as he was the author of the commit http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-25&id=2cdeb903c57126d3ad5f0cbd72e182584b76ee29 where ps-eval-switch was removed. ===== >From 4af9c6403b5917aca27490cc331a36dd6e1222c3 Mon Sep 17 00:00:00 2001 From: Kaushal Modi Date: Wed, 11 May 2016 12:45:42 -0400 Subject: [PATCH] Fix reference to obsolete fn ps-eval-switch The `lpr-eval-switch' is functionally the same as `ps-eval-switch' which was obsoleted in 2cdeb903c57126d3ad5f0cbd72e182584b76ee29. So using that instead (Bug#19717). * printing.el (pr-switches): Use lpr-eval-switch instead of ps-eval-switch. --- lisp/printing.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/printing.el b/lisp/printing.el index 3bd5a67..a336aeb 100644 --- a/lisp/printing.el +++ b/lisp/printing.el @@ -5673,7 +5673,7 @@ pr-switches (or (listp switches) (error "%S should have a list of strings" mess)) (lpr-flatten-list ; dynamic evaluation - (mapcar 'ps-eval-switch switches))) + (mapcar 'lpr-eval-switch switches))) (defun pr-ps-preview (kind n-up filename mess) -- 2.6.0.rc0.24.gec371ff -- -- Kaushal Modi --001a113d4e56545a070532941714 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

I have attached the belo= w patch in an attempt to fix this. I notice that printing.el requires lpr.e= l, and pr-switches function anyways uses lpr-flatten-list from lpr.el. So t= here should be no harm using lpr-eval-switch instead of ps-eval-switch. I h= ave verified that lpr-eval-switch is the exact same function as the now obs= olete ps-eval-switch; just different names.

Copyin= g Stefan for reviewing and commiting this patch as he was the author of the= commit=C2=A0http://git.= savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-25&id=3D2cdeb903c5712= 6d3ad5f0cbd72e182584b76ee29=C2=A0where ps-eval-switch was removed.

=3D=3D=3D=3D=3D

From 4af9c640= 3b5917aca27490cc331a36dd6e1222c3 Mon Sep 17 00:00:00 2001
From: K= aushal Modi <kaushal.modi@gmai= l.com>
Date: Wed, 11 May 2016 12:45:42 -0400
Sub= ject: [PATCH] Fix reference to obsolete fn ps-eval-switch

The `lpr-eval-switch' is functionally the same as `ps-eval-swit= ch' which
was obsoleted in 2cdeb903c57126d3ad5f0cbd72e182584b= 76ee29.=C2=A0 So using
that instead (Bug#19717).

* printing.el (pr-switches): Use lpr-eval-switch instead of ps-eva= l-switch.
---
=C2=A0lisp/printing.el | 2 +-
= =C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/printing.el b/lisp/printing.el
index 3bd5a67.= .a336aeb 100644
--- a/lisp/printing.el
+++ b/lisp/print= ing.el
@@ -5673,7 +5673,7 @@ pr-switches
=C2=A0 =C2=A0(= or (listp switches)
=C2=A0 =C2=A0 =C2=A0 =C2=A0(error "%S sh= ould have a list of strings" mess))
=C2=A0 =C2=A0(lpr-flatte= n-list ; = dynamic evaluation
- =C2=A0 (mapcar 'ps-eval-switch switches)= ))
+ =C2=A0 (mapcar 'lpr-eval-switch switches)))
= =C2=A0
=C2=A0
=C2=A0(defun pr-ps-preview (kind n-up fil= ename mess)
--=C2=A0
2.6.0.rc0.24.gec371ff
--

--
Kaushal Modi

--001a113d4e56545a070532941714--