From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#28688: 26.0.60; Making ucs-names hash tables breaks aa2u, counsel packages Date: Tue, 03 Oct 2017 15:40:46 +0000 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c0bb8e22d8214055aa651fb" X-Trace: blaine.gmane.org 1507045329 19843 195.159.176.226 (3 Oct 2017 15:42:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Oct 2017 15:42:09 +0000 (UTC) To: mvoteiza@udel.edu, 28688@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 03 17:42:03 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzPKc-0004HQ-Sk for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Oct 2017 17:42:03 +0200 Original-Received: from localhost ([::1]:59184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzPKi-0000V9-Rz for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Oct 2017 11:42:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzPKd-0000V2-Hg for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 11:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzPKc-0001RR-5g for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 11:42:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37869) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dzPKc-0001R8-2H for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 11:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dzPKb-0006pY-PI for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 11:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Oct 2017 15:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28688 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Mark Oteiza , "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.150704526926185 (code B ref -1); Tue, 03 Oct 2017 15:42:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Oct 2017 15:41:09 +0000 Original-Received: from localhost ([127.0.0.1]:46548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzPJl-0006oH-8X for submit@debbugs.gnu.org; Tue, 03 Oct 2017 11:41:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzPJj-0006o2-7B for submit@debbugs.gnu.org; Tue, 03 Oct 2017 11:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzPJc-0000mh-Lg for submit@debbugs.gnu.org; Tue, 03 Oct 2017 11:41:02 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:34706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzPJc-0000mU-HZ for submit@debbugs.gnu.org; Tue, 03 Oct 2017 11:41:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzPJa-00009H-VB for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 11:41:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzPJZ-0000kD-HG for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 11:40:58 -0400 Original-Received: from mail-qt0-x236.google.com ([2607:f8b0:400d:c0d::236]:53178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dzPJZ-0000if-BD for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 11:40:57 -0400 Original-Received: by mail-qt0-x236.google.com with SMTP id o52so13687295qtc.9 for ; Tue, 03 Oct 2017 08:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=bcgR4pHeTpnjp3qVG00jRWBz159e9rLw/CtF3Bz/bMg=; b=BLHCn973ENIT0r2PvyHBaluP+kk4k4QhmjmeUxARfWudSMGwmhnp+07Cm7YNuxPdWm 1ieVUNJKbTfLyO5hyySi+gCGz5+ikT0+l/rVWJCe1LFEZEDMoho8aLLLUZogIK9j7Oj/ 6nuCOvbXs55YuZqYk9KPKIRV4w/0KUlSLCtXoQzSLsnw7L8j10HxUls5B+aVuViDv+A5 NJxrKTaxjS4H5QQ64c5oSMGyHezHRzHZbSKJjHKOE+bdqeGM2sniV2GmDpQlvrnsMDEM pM7bWL3+bdAL+rjFmWcSGL6zUBUVL0Gb93jQS0IUqkWd+9Gb/FMkilIgnDNdJQ5cRkjO iRFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=bcgR4pHeTpnjp3qVG00jRWBz159e9rLw/CtF3Bz/bMg=; b=dBrs59sUZfWXUZKsMf6EmqcBNWJ26TgPtjoOmZRN/oc0y/+O/o24gubbLfnoSE7Ion CHm14xrH9ukILPNJ5HtfkBzvqdWeJ+NwtgBwfiC9tdtDRLeNHVROnRkSBPa5+WBNfBN7 k4sDRX+m2pD8MnPW7HqKYnCoB1rUPJ5nlEamMi6z6PPoAxKnga/XjFpKpuF4E3rzdm8y AvLoRLUfz8xwkOkm3VckdWnSg1zUXtwLcK4qtMOHaqVp9jqQDA8jbeJ6sYK0fYpSBnc7 CHxwSxCwLnEWK9CsKLfZri5bkf5Yip/JHIJzvTrlHo5sRESgg2K9IP1qnbD1eX2r7/Pi Nqsw== X-Gm-Message-State: AHPjjUhWTSqxBsuaJJbfA1X7g4rpBrY/CjVYvhDuSL2ABjIvSJEx6/IN ZyncmsYHeaymrNOeH1TOvj4QAnHyVrz0J8cnaWs= X-Google-Smtp-Source: AOwi7QA6VRwFRUlUQWSVrs6EMvM9W/xhfJN0Ol+dROllafyczkz1b3Wzsy4TrZhSLZQlJ99dIsX4tp7Sg9ENtIFh2+Y= X-Received: by 10.129.159.69 with SMTP id w66mr15360328ywg.392.1507045256555; Tue, 03 Oct 2017 08:40:56 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137837 Archived-At: --94eb2c0bb8e22d8214055aa651fb Content-Type: text/plain; charset="UTF-8" Hi Mark, Can you please review the aa2u package in GNU Elpa? https://elpa.gnu.org/packages/ascii-art-to-unicode.html In there, there is this function which triggers error after this change[1]: (defun aa2u-1c (stringifier &rest components) "Apply STRINGIFIER to COMPONENTS; return the UCS char w/ this name. The char is a string (of length one), with two properties: aa2u-stringifier aa2u-components Their values are STRINGIFIER and COMPONENTS, respectively." (let ((s (string (cdr (assoc-string (apply stringifier components) (ucs-names)))))) (propertize s 'aa2u-stringifier stringifier 'aa2u-components components))) Can you please update the package so that it works whether ucs-names is a hash-table or a list? I also realized that it broke the counsel-unicode-char interactive function in the counsel.el package too: (defun counsel-unicode-char (&optional count) "Insert COUNT copies of a Unicode character at point. COUNT defaults to 1." (interactive "p") (let ((minibuffer-allow-text-properties t) (ivy-sort-max-size (expt 256 6))) (setq ivy-completion-beg (point)) (setq ivy-completion-end (point)) (ivy-read "Unicode name: " (nreverse (mapcar (lambda (x) (propertize (format "%06X % -60s%c" (cdr x) (car x) (cdr x)) 'result (cdr x))) (ucs-names))) :action (lambda (char) (with-ivy-window (delete-region ivy-completion-beg ivy-completion-end) (setq ivy-completion-beg (point)) (insert-char (get-text-property 0 'result char) count) (setq ivy-completion-end (point)))) :history 'counsel-unicode-char-history :sort t))) [1]: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-26&id=96c2c098aeed5c85733577ebbdaf33af6fbb59e9 -- Kaushal Modi --94eb2c0bb8e22d8214055aa651fb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Mark,

Can you please review the aa2u= package in GNU Elpa?


In there, there is th= is function which triggers error after this change[1]:

=
(defun aa2u-1c (stringifier &rest components)
=C2= =A0 "Apply STRINGIFIER to COMPONENTS; return the UCS char w/ this name= .
The char is a string (of length one), with two properties:

=C2=A0 aa2u-stringifier
=C2=A0 aa2u-componen= ts

Their values are STRINGIFIER and COMPONENTS, re= spectively."
=C2=A0 (let ((s (string (cdr (assoc-string (app= ly stringifier components)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 (ucs-names))))))
=C2=A0 =C2=A0 (propertize s=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'aa2= u-stringifier stringifier
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 'aa2u-components components)))

Can you please update the package so that it works whether ucs-nam= es is a hash-table or a list?

I also realized that= it broke the counsel-unicode-char interactive function in the counsel.el p= ackage too:

(defun counsel-unicode-char (&= ;optional count)
=C2=A0 "Insert COUNT copies of a Unicode ch= aracter at point.
COUNT defaults to 1."
=C2=A0 (in= teractive "p")
=C2=A0 (let ((minibuffer-allow-text-prop= erties t)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (ivy-sort-max-size (expt 25= 6 6)))
=C2=A0 =C2=A0 (setq ivy-completion-beg (point))
= =C2=A0 =C2=A0 (setq ivy-completion-end (point))
=C2=A0 =C2=A0 (iv= y-read "Unicode name: "
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 (nreverse
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(mapcar (lambda (x)
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(properti= ze
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 (format "%06X % -60s%c" (cdr x) (car= x) (cdr x))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'result (cdr x)))
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(ucs-names)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 :action (lambda (char)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (with-ivy-window
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 (delete-region ivy-completion-beg ivy-completion-end)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 (setq ivy-completion-beg (point))
=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 (insert-char (get-text-property 0 'result char) count)
=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 (setq ivy-completion-end (point))))
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :history 'counsel-unicode-cha= r-history
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :sort = t)))

--

Kaushal Modi

--94eb2c0bb8e22d8214055aa651fb--