From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff Date: Sun, 9 Jun 2019 23:21:20 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000b33bc1058aefae69" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50701"; mail-complaints-to="usenet@blaine.gmane.org" Cc: alex.branham@gmail.com To: 36157@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 10 05:23:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haAu8-000D4q-FS for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 05:23:28 +0200 Original-Received: from localhost ([::1]:40184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haAu6-0002zT-SN for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Jun 2019 23:23:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41218) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haAtp-0002zN-Hp for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 23:23:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haAtl-0006KZ-8y for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 23:23:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42218) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1haAth-00067N-Qe for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 23:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1haAth-0006FB-L7 for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2019 23:23:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jun 2019 03:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36157 X-GNU-PR-Package: emacs Original-Received: via spool by 36157-submit@debbugs.gnu.org id=B36157.156013692623937 (code B ref 36157); Mon, 10 Jun 2019 03:23:01 +0000 Original-Received: (at 36157) by debbugs.gnu.org; 10 Jun 2019 03:22:06 +0000 Original-Received: from localhost ([127.0.0.1]:55762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haAsm-0006Dy-EX for submit@debbugs.gnu.org; Sun, 09 Jun 2019 23:22:06 -0400 Original-Received: from mail-lf1-f41.google.com ([209.85.167.41]:45145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haAsk-0006DS-LU for 36157@debbugs.gnu.org; Sun, 09 Jun 2019 23:22:03 -0400 Original-Received: by mail-lf1-f41.google.com with SMTP id u10so5513465lfm.12 for <36157@debbugs.gnu.org>; Sun, 09 Jun 2019 20:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=vDLpKc+hd+x0UrswcyQzUbpHJ6g41+35Q+1AM1GXFUM=; b=M24Dh1fWgWqeZNpF6pIZA+ihBgqQenRjbCiVE4oVkerbqKpHM3z5PnM4Ih8ENIkDWZ y1ET9iAe6B6/Br1Shhac2RrjkNxx2G3hYTpbhExB2OTGX8ZaBaDOcWN+UzP2hCZUMTqN CWuecrQWM3dDfNZzSfgZ06OXTxWeWiIImO5FMPfso3dpCa8lBvpRCtfkhtjBOWYd5KLR +6yNemqmwsaDSGN3rTb7rdr7bSXGWJwVD72XajQlkOZlJ2dPlMV2mzkp1dqLt7zdrxfz 1qilSjDXAXGYXTmVyiF1DRfIukoZsqksn12Jy6LbhKdiybrueiqLPKBxUpt+PwRWOt2a 1nHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=vDLpKc+hd+x0UrswcyQzUbpHJ6g41+35Q+1AM1GXFUM=; b=ZgbVNO5S1erlmJP7BLgOnSrKb/20jD228zbmCS/TWWa7POtRY6ZpiQbHiq95wz6eDf jnMqRcJaJI+wOXLpKU4FFYl52kOy6QyM0rV1w2yYjKu9BFgs832c4VPhNxkhIHjmC6Sx R5bMykqCt7wvaYpPBkpAVI2hiwqBQ8+bQzxXarI16TwWiSBmW4yMg7hRcrSB59j7rsTZ aqMRJQ1+cQITNoh0VLkA08Xj/uWzteIdLRMJWxPq3uJzeTGSc2Dch6b8HzDb/6ZH2Plu Ar+5RMUTRkghzwmmsU4gfBT0mt+FlHlFJrvd3fIPQL4erTBQvHp9qyj2tvwfV+wO0xYq mocA== X-Gm-Message-State: APjAAAUc9NeZbtGK+w5SGvjSzv8FE/AIDTZd/TUeXeEIsvh/eBekbqaj rNrqalYdjTy1kpRxsPqSRCMSdkdvOVQIV7nAw7xzD1y3 X-Google-Smtp-Source: APXvYqx1puAHLQzsp6l1fb3Rq5AMXsyOuyx491tgKJoa4l07Y8sG2nnRX0V9USGAxLDtHmG4dGFZILWfkqMISJYug6A= X-Received: by 2002:a19:2d41:: with SMTP id t1mr33125126lft.79.1560136916349; Sun, 09 Jun 2019 20:21:56 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160318 Archived-At: --000000000000b33bc1058aefae69 Content-Type: text/plain; charset="UTF-8" It seems like properly enabling lexical binding in ediff will be a bit tricky. If you look at the code of ediff-find-file, you will see the use of `symbol-value' everywhere. This line is the source of the error in the bug report: (defun ediff-find-file (file-var buffer-name &optional last-dir hooks-var) "Visit FILE and arrange its buffer to Ediff's liking. ... deleted." (let* ((file (symbol-value file-var)) ;<------------------ I see symbol-value used at 4 places in ediff.el. So all of those will need replaced with variable access in lexical scope. -- Kaushal Modi --000000000000b33bc1058aefae69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It seems like properly enabling lexical binding in ed= iff will be a bit tricky.

If you look at the code = of ediff-find-file, you will see the use of `symbol-value' everywhere.<= /div>

This line is the source of the error in the bug re= port:

(defun ediff-find-file (file-var buffer-name= &optional last-dir hooks-var)
=C2=A0 "Visit FILE and arrange i= ts buffer to Ediff's liking.
...

deleted."
=C2=A0 (let* ((file (symbol-value file-var))=C2=A0 ;<= ------------------

I see symbol-value used at 4 pl= aces in ediff.el. So all of those will need replaced with variable access i= n lexical scope.

--=
Kaushal Modi
--000000000000b33bc1058aefae69--