From: Kaushal Modi <kaushal.modi@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 34256@debbugs.gnu.org
Subject: bug#34256: 27.0.50; Crash on draw_glyphs()
Date: Mon, 4 Feb 2019 11:03:37 -0500 [thread overview]
Message-ID: <CAFyQvY2YEmrBOMpFqgPj=KrpwT8fW_ssk8QfjW7D4U0K006gfA@mail.gmail.com> (raw)
In-Reply-To: <834l9nzys6.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]
Hi Eli,
On Fri, Feb 1, 2019 at 3:41 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > "redisplay_internal (C function)" (0x0)
>
> Thanks, I think I understand what happened here. Does the patch below
> fix the problem? If it doesn't, please repeat the procedure with the
> patched Emacs.
>
> diff --git a/src/frame.h b/src/frame.h
> index ab3efdf..e0dab51 100644
> --- a/src/frame.h
> +++ b/src/frame.h
> @@ -413,6 +413,10 @@ struct frame
> /* Non-zero if this frame's faces need to be recomputed. */
> bool_bf face_change : 1;
>
> + /* Non-zero if this frame's image cache cannot be freed because the
> + frame is in the process of being redisplayed. */
> + bool_bf inhibit_clear_image_cache : 1;
> +
> /* Bitfield area ends here. */
>
> /* This frame's change stamp, set the last time window change
> diff --git a/src/image.c b/src/image.c
> index 2014860..342b647 100644
> --- a/src/image.c
> +++ b/src/image.c
> @@ -1554,7 +1554,7 @@ clear_image_cache (struct frame *f, Lisp_Object
> filter)
> {
> struct image_cache *c = FRAME_IMAGE_CACHE (f);
>
> - if (c)
> + if (c && !f->inhibit_clear_image_cache)
> {
> ptrdiff_t i, nfreed = 0;
>
> diff --git a/src/xdisp.c b/src/xdisp.c
> index ec8dd86..b43777a 100644
> --- a/src/xdisp.c
> +++ b/src/xdisp.c
> @@ -14440,7 +14440,17 @@ redisplay_internal (void)
> FRAME_TERMINAL (f)->condemn_scroll_bars_hook (f);
>
> if (FRAME_VISIBLE_P (f) && !FRAME_OBSCURED_P (f))
> - redisplay_windows (FRAME_ROOT_WINDOW (f));
> + {
Thanks for the patch!
I couldn't apply the patch, so had to apply it manually.
But it works!
I am looking forward to understand in plain terms what this fix did.
Thank you.
[-- Attachment #2: Type: text/html, Size: 2459 bytes --]
next prev parent reply other threads:[~2019-02-04 16:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 14:30 bug#34256: 27.0.50; Crash on draw_glyphs() Kaushal Modi
2019-01-30 16:16 ` Eli Zaretskii
2019-01-30 16:35 ` Kaushal Modi
2019-01-30 16:51 ` Eli Zaretskii
2019-01-30 18:22 ` Kaushal Modi
2019-01-30 18:55 ` Eli Zaretskii
2019-01-30 20:54 ` Kaushal Modi
2019-01-31 14:02 ` Eli Zaretskii
2019-01-31 15:50 ` Kaushal Modi
2019-01-31 16:52 ` Eli Zaretskii
2019-01-31 17:02 ` Kaushal Modi
2019-01-31 17:05 ` Kaushal Modi
2019-01-31 20:26 ` Eli Zaretskii
2019-02-01 3:15 ` Kaushal Modi
2019-02-01 3:25 ` Kaushal Modi
2019-02-01 8:41 ` Eli Zaretskii
2019-02-04 16:03 ` Kaushal Modi [this message]
2019-02-04 17:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY2YEmrBOMpFqgPj=KrpwT8fW_ssk8QfjW7D4U0K006gfA@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=34256@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).