From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Newsgroups: gmane.emacs.bugs Subject: bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist Date: Thu, 20 Aug 2015 17:35:55 +0000 Message-ID: References: <87wpyt5c26.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e011843e855b9c7051dc1967c X-Trace: ger.gmane.org 1440120868 20309 80.91.229.3 (21 Aug 2015 01:34:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Aug 2015 01:34:28 +0000 (UTC) To: michael_heerdegen@web.de, 21047@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 21 03:34:22 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZSbDl-0004zV-RC for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Aug 2015 03:34:18 +0200 Original-Received: from localhost ([::1]:38956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSbDl-0001RT-9m for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2015 21:34:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSXZ6-0005D9-CI for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2015 17:40:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZSXZ5-0004hP-2k for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2015 17:40:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSXZ5-0004hL-0e for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2015 17:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZSXZ4-0000MK-K5 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2015 17:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2015 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21047 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Michael Heerdegen , "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.14401067681337 (code B ref -1); Thu, 20 Aug 2015 21:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Aug 2015 21:39:28 +0000 Original-Received: from localhost ([127.0.0.1]:33887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSXYV-0000LV-9Y for submit@debbugs.gnu.org; Thu, 20 Aug 2015 17:39:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37367) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSXYS-0000LM-IN for submit@debbugs.gnu.org; Thu, 20 Aug 2015 17:39:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZSXYR-0004Pp-4l for submit@debbugs.gnu.org; Thu, 20 Aug 2015 17:39:24 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSXYR-0004Pl-2c for submit@debbugs.gnu.org; Thu, 20 Aug 2015 17:39:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSTl7-0006mx-Jf for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2015 13:36:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZSTl6-0001K5-Bn for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2015 13:36:13 -0400 Original-Received: from mail-ob0-x233.google.com ([2607:f8b0:4003:c01::233]:36282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSTl6-0001Jt-4z for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2015 13:36:12 -0400 Original-Received: by obkg7 with SMTP id g7so38186167obk.3 for ; Thu, 20 Aug 2015 10:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-type; bh=uT3gCjj5dWryhaKnqUcSKo6AASx4bWiAxcBDt0srGHU=; b=rKWNvFdx8Qw70ZQqC9toOKX1FkIRFI/WR5z0zu0ozmeiRc2lfjPIX5In7u9cFUTuQh Uv7F3YyEk7w+xKRNzQz8x2xOi1Fj0FpkEkzphzJjcrLlVEicWt7hEmOgEbA57vctNmyp c4R8bpQYED9Zh4rV6f4AUzXyh3Jd+BVEw7nwQdlQ0Ayk5+Pdj6ZfHbH7JWSz4lUEXrgt pkkisyBAkKy9cqcE3MHGP/GKWhWhlvN+gWV8rNMlpPyFQ1o29bSlYgX8BKksfuk60SDV hjPLsEGU0TMzvcH7MyQdkvK1XFMUNn7lU9m2Pc0omLC+kWUFO0Ro7P5SCfUfxqVNPeag Qz2A== X-Received: by 10.60.178.99 with SMTP id cx3mr3908930oec.50.1440092171645; Thu, 20 Aug 2015 10:36:11 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105628 Archived-At: --089e011843e855b9c7051dc1967c Content-Type: text/plain; charset=UTF-8 Can someone please review this? On Mon, Jul 13, 2015 at 11:06 AM Kaushal wrote: > Hi, > > This was posted on the emacs-devel list a while back and it was suggested > that this be posted on bug-gnu-emacs. > > The aim of this patch is that opening M-x woman buffers be controlled > using display-buffer-alist. Using display-buffer function instead of > switch-to-buffer function will allow the user to control how they want to > open the WoMan buffers (same window, other window, popup, etc) > > The patch is below: > > Date: Mon, 13 Jul 2015 11:00:39 -0400 > Subject: [PATCH] Allow display-buffer-alist to control woman bufs > > --- > lisp/woman.el | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lisp/woman.el b/lisp/woman.el > index 75c3d2e..e903caa 100644 > --- a/lisp/woman.el > +++ b/lisp/woman.el > @@ -1651,7 +1651,7 @@ Do not call directly!" > (setq woman-frame (make-frame))))) > (set-buffer (get-buffer-create bufname)) > (condition-case nil > - (switch-to-buffer (current-buffer)) > + (display-buffer (current-buffer)) > (error (pop-to-buffer (current-buffer)))) > (buffer-disable-undo) > (setq buffer-read-only nil) > @@ -2061,14 +2061,14 @@ alist in `woman-buffer-alist' and return nil." > (if (zerop woman-buffer-number) > (let ((buffer (get-buffer (cdr (car woman-buffer-alist))))) > (if buffer > - (switch-to-buffer buffer) > + (display-buffer buffer) > ;; Delete alist element: > (setq woman-buffer-alist (cdr woman-buffer-alist)) > nil)) > (let* ((prev-ptr (nthcdr (1- woman-buffer-number) woman-buffer-alist)) > (buffer (get-buffer (cdr (car (cdr prev-ptr)))))) > (if buffer > - (switch-to-buffer buffer) > + (display-buffer buffer) > ;; Delete alist element: > (setcdr prev-ptr (cdr (cdr prev-ptr))) > (if (>= woman-buffer-number (length woman-buffer-alist)) > -- > 1.9.2 > > > On Wed, Jun 24, 2015 at 12:03 PM Michael Heerdegen < > michael_heerdegen@web.de> wrote: > >> Hi Kaushal, >> >> > I was trying to make the WoMan buffers open as I intend to using >> > display-buffer-alist. But that was not working. >> >> I guess your message got lost here, better make a bug report, and >> better include a patch than the whole changed code. >> >> > can that change be made in the master? >> >> I think it would be an improvement. >> >> The very same applies to eww: >> >> --8<---------------cut here---------------start------------->8--- >> (defun eww-setup-buffer () >> (switch-to-buffer (get-buffer-create "*eww*")) ; <----- >> (let ((inhibit-read-only t)) >> (remove-overlays) >> (erase-buffer)) >> (unless (eq major-mode 'eww-mode) >> (eww-mode))) >> --8<---------------cut here---------------end--------------->8--- >> >> Maybe there are more cases. It's surely worth discussing. >> >> >> Regards, >> >> Michael. >> > --089e011843e855b9c7051dc1967c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Can someone please review this?

On Mon, Jul 13, 2015 at 11:06 AM Kaushal <kaushal.modi@gmail.com> wrote= :
Hi,

This was posted on the emacs-devel list a while back and = it was suggested that this be posted on bug-gnu-emacs.

=
The aim of this patch is that opening M-x woman buffers be controlled = using display-buffer-alist. Using display-buffer function instead of switch= -to-buffer function will allow the user to control how they want to open th= e WoMan buffers (same window, other window, popup, etc)

The patch is below:

Date: Mon, 13 Jul 2015 1= 1:00:39 -0400
Subject: [PATCH] Allow display-buffer-alist to = control woman bufs

---
=C2=A0lisp/woman.= el | 6 +++---
=C2=A01 file changed, 3 insertions(+), 3 deletions(= -)

diff --git a/lisp/woman.el b/lisp/woman.el
index 75c3d2e..e903caa 100644
--- a/lisp/woman.el
+++ b/lisp/woman.el
@@ -1651,7 +1651,7 @@ Do not call directly!&= quot;
=C2=A0 =C2=A0 = =C2=A0 (setq woman-frame (make-frame)))))
=C2=A0 =C2=A0 =C2=A0(se= t-buffer (get-buffer-create bufname))
=C2=A0 =C2=A0 =C2=A0(condit= ion-case nil
- =C2=A0 =C2=A0 =C2=A0 =C2=A0(switch-to-buffer (curr= ent-buffer))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0(display-buffer (curren= t-buffer))
=C2=A0 =C2=A0 =C2=A0 =C2=A0(error (pop-to-buffer (curr= ent-buffer))))
=C2=A0 =C2=A0 =C2=A0(buffer-disable-undo)
=C2=A0 =C2=A0 =C2=A0(setq buffer-read-only nil)
@@ -2061,14 +20= 61,14 @@ alist in `woman-buffer-alist' and return nil."
= =C2=A0 =C2=A0(if (zerop woman-buffer-number)
=C2=A0 =C2=A0 =C2=A0= =C2=A0(let ((buffer (get-buffer (cdr (car woman-buffer-alist)))))
=C2=A0 (if buffer
-= =C2=A0 =C2=A0(switch-to-buffe= r buffer)
+ =C2=A0 = =C2=A0(display-buffer buffer)
=C2=A0 =C2=A0;; Delete alist element:
=C2=A0 =C2=A0(setq woman-buffer-alist (cdr woma= n-buffer-alist))
=C2=A0 =C2=A0nil))
=C2=A0 =C2=A0 =C2=A0(let* ((prev-ptr (nthcdr (1- = woman-buffer-number) woman-buffer-alist))
=C2=A0 =C2=A0 (buffer (get-buffer (cdr (car (cdr prev= -ptr))))))
=C2=A0 =C2=A0 =C2=A0 =C2=A0(if buffer
- =C2=A0(switch-to-buffer buffer)
+ =C2=A0(display-buffe= r buffer)
=C2=A0 ;; D= elete alist element:
=C2=A0 = (setcdr prev-ptr (cdr (cdr prev-ptr)))
=C2=A0 (if (>=3D woman-buffer-number (length = woman-buffer-alist))
--=C2=A0
1.9.2


On Wed, Jun 24, 2015 at 12= :03 PM Michael Heerdegen <michael_heerdegen@web.de> wrote:
Hi Kaushal,

> I was trying to make the WoMan buffers open as I intend to using
> display-buffer-alist. But that was not working.

I guess your message got lost here, better make a bug report, and
better include a patch than the whole changed code.

> can that change be made in the master?

I think it would be an improvement.

The very same applies to eww:

--8<---------------cut here---------------start------------->8---
(defun eww-setup-buffer ()
=C2=A0 (switch-to-buffer (get-buffer-create "*eww*")) ; <-----=
=C2=A0 (let ((inhibit-read-only t))
=C2=A0 =C2=A0 (remove-overlays)
=C2=A0 =C2=A0 (erase-buffer))
=C2=A0 (unless (eq major-mode 'eww-mode)
=C2=A0 =C2=A0 (eww-mode)))
--8<---------------cut here---------------end--------------->8---

Maybe there are more cases.=C2=A0 It's surely worth discussing.


Regards,

Michael.
--089e011843e855b9c7051dc1967c--