From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#29067: 26.0.90; "Invalid client frame" when doing save-buffers-kill-terminal Date: Mon, 30 Oct 2017 17:10:13 +0000 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f4030437f310df0323055cc6b600" X-Trace: blaine.gmane.org 1509383552 18544 195.159.176.226 (30 Oct 2017 17:12:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Oct 2017 17:12:32 +0000 (UTC) To: 29067@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 30 18:12:28 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9Dbn-0003kJ-JJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 18:12:19 +0100 Original-Received: from localhost ([::1]:41778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9Dbu-0007cP-S4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 13:12:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9Dac-0006Ti-NH for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 13:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9DaY-0003xM-BC for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 13:11:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33816) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9DaY-0003x4-8A for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 13:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e9DaX-0000Rn-QY; Mon, 30 Oct 2017 13:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: rudalics@gmx.at, bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Oct 2017 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" X-Debbugs-Original-Xcc: rudalics@gmx.at Original-Received: via spool by submit@debbugs.gnu.org id=B.15093834381688 (code B ref -1); Mon, 30 Oct 2017 17:11:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Oct 2017 17:10:38 +0000 Original-Received: from localhost ([127.0.0.1]:42496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9DaA-0000RA-4R for submit@debbugs.gnu.org; Mon, 30 Oct 2017 13:10:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9Da8-0000Qx-Ld for submit@debbugs.gnu.org; Mon, 30 Oct 2017 13:10:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9Da2-0003IY-5a for submit@debbugs.gnu.org; Mon, 30 Oct 2017 13:10:31 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:35551) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9Da1-0003ID-QK for submit@debbugs.gnu.org; Mon, 30 Oct 2017 13:10:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9Da0-00065m-7s for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 13:10:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9DZy-0003FL-ME for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 13:10:28 -0400 Original-Received: from mail-yw0-x22d.google.com ([2607:f8b0:4002:c05::22d]:48550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9DZy-0003Dq-8s for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 13:10:26 -0400 Original-Received: by mail-yw0-x22d.google.com with SMTP id q1so12219975ywh.5 for ; Mon, 30 Oct 2017 10:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=213lrW9GxBOKfqQteOCmggfxTBIw2hXVOiKzZbf0dfM=; b=iN0J5jIbefYCQ2m4lgu/hH+ppWmX4vE8SD5wx7KK9lWyQllPxCewvxm1UxtiGcPtSi yTPn2h+d0Cgol+Mhxt7it9BX1ZxInvsG8LwP1VMrkeROIlg8viiSj+eQS3Rxd6cR0wS2 Mxn7y7nIdV4WISphLdCaBW+za0nIYURSQPlmhC8QoqEV5SpPk6mqY61Om4qfT651wJKv JBsrA4YKSFlBP13yUUgatKrB2WKCLD3ClgnPWlNixgKCDZBO+EjS/uk1jnaixMq4nge4 m/1iW6502raCxfVbxh8ZurCXjv1LOVYZqKiKxdDC5p6ij3Acly0YRrv3w2ZSd3PQnfHY rvYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=213lrW9GxBOKfqQteOCmggfxTBIw2hXVOiKzZbf0dfM=; b=XKOLXNniLiMFIOBYVtWpJV3D8x1DTWbr9/7lT+gDMATTaD8FxdHIllwIKuSapoKNPW /y7rwnAo/jd+uIozZZlHrtRNtRjhgAUN2SiROnIglKd6xkrqovSDio1wtm38CSMz4qwf dNi2TJLtnnpQP0nNCU0Xr9nDVIMaj48R2/efvkYbYKVmEfejh9hzOgHpqmIVOyb+EbLx qqfcT46d4NfxxuKS4zBiKHhEmvXLFYM4wwwOILxC5i+uWYz39w5iHkJlmdbIKKlzSxIZ rg1Xuvga3SFIH6jhx8QI7v3GiSGgiKb2nN5x6/p5FqZtGI7TORZwEEppGukghbwr8He8 lgLA== X-Gm-Message-State: AMCzsaVN0DfdzR3QFCe2GhwnHvGfNXijUu0ZcfyNb27QL1aCNQzbeYdu cNrCY3Gf6AesRKW8lWYEWD0hZfdX1jSxHMdV0EM= X-Google-Smtp-Source: ABhQp+Q6sI14GGPa9PoOeAUpCkvxJdiqxOtTHhXCMR4P+WmaqRAP9eObr6W0pZZK8Moh8eORGTmeei8N34EqEZkmzuc= X-Received: by 10.37.139.8 with SMTP id i8mr6319892ybl.389.1509383424900; Mon, 30 Oct 2017 10:10:24 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139185 Archived-At: --f4030437f310df0323055cc6b600 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Debbugs-CC: rudalics@gmx.at Hello, Normally (99.99% of the time), I run emacs using emacsclient. Today I happened to run it with just emacs&. But then when I tried to quit via save-buffers-kill-terminal, I got "Invalid client frame". In files.el, we have: (defun save-buffers-kill-terminal (&optional arg) "Offer to save each buffer, then kill the current connection. If the current frame has no client, kill Emacs itself using `save-buffers-kill-emacs'. With prefix ARG, silently save all file-visiting buffers, then kill. If emacsclient was started with a list of filenames to edit, then only these files will be asked to be saved." (interactive "P") (if (frame-parameter nil 'client) (server-save-buffers-kill-terminal arg) (save-buffers-kill-emacs arg))) When I eval'ed (frame-parameter nil 'client), I got "Unprintable entity"! So server-save-buffers-kill-terminal gets called incorrectly instead of save-buffers-kill-emacs when I actually do not have the emacsclient or daemon running. I do not see this issue on emacs 25.3 using my same emacs config. Copying Martin as he might have an idea what could have caused this regression. In GNU Emacs 26.0.90 (build 14, x86_64-pc-linux-gnu, GTK+ Version 2.24.23) of 2017-10-26 Repository revision: 646e56e150ca08978d6ce736b12867b4958a0cd8 Windowing system distributor 'The X.Org Foundation', version 11.0.60900000 System Description: Red Hat Enterprise Linux Workstation release 6.6 (Santiago) Recent messages: Quit [4 times] Ag finished Mark saved where search started Ag finished nil Entering debugger... uncompressing files.el.gz...done "Unprintable entity" [2 times] Mark saved where search started Mark set "Unprintable entity" Configured using: 'configure --with-modules --prefix=3D/home/kmodi/usr_local/apps/6/emacs/emacs-26 '--program-transform-name=3Ds/^ctags$/ctags_emacs/' 'CPPFLAGS=3D-I/home/kmodi/usr_local/6/include -I/usr/include/freetype2 -I/usr/include' 'CFLAGS=3D-ggdb3 -O0' 'CXXFLAGS=3D-ggdb3 -O0' 'LDFLAGS=3D-L/home/kmodi/usr_local/6/lib -L/home/kmodi/usr_local/6/lib64 -ggdb3' PKG_CONFIG_PATH=3D/home/kmodi/usr_local/6/lib/pkgconfig:/home/kmodi/usr_lo= cal/6/lib64/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib/pkgconfig:/cad/a= di/apps/gnu/linux/x86_64/6/lib64/pkgconfig:/home/kmodi/stowed/lib/pkgconfig= :/usr/lib/pkgconfig:/usr/lib64/pkgconfig:/usr/share/pkgconfig:/lib/pkgconfi= g:/lib64/pkgconfig' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 MODULES --=20 Kaushal Modi --f4030437f310df0323055cc6b600 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
X-Debbugs-CC: ruda= lics@gmx.at

Hello,

Normally (99.99% of the time), I run emacs using emacsclient.
<= br>
Today I happened to run it with just emacs&. But then whe= n I tried to quit via save-buffers-kill-terminal, I got "Invalid clien= t frame".

In files.el, we have:
(defun save-buffers-kill-terminal (&optional arg)
=C2=A0 "Offer to save each buffer, then kill the current connect= ion.
If the current frame has no client, kill Emacs itself using<= /div>
`save-buffers-kill-emacs'.

With pref= ix ARG, silently save all file-visiting buffers, then kill.

<= /div>
If emacsclient was started with a list of filenames to edit, then=
only these files will be asked to be saved."
=C2= =A0 (interactive "P")
=C2=A0 (if (frame-parameter nil &= #39;client)
=C2=A0 =C2=A0 =C2=A0 (server-save-buffers-kill-termin= al arg)
=C2=A0 =C2=A0 (save-buffers-kill-emacs arg)))
=

When I eval'ed (frame-parameter nil 'client), I= got=C2=A0"Unprintable entity"!

So serve= r-save-buffers-kill-terminal gets called incorrectly instead of save-buffer= s-kill-emacs when I actually do not have the emacsclient or daemon running.=

I do not see this issue on emacs 25.3 using my sa= me emacs config.

Copying Martin as he might have a= n idea what could have caused this regression.=C2=A0



In GNU Emacs 26.0.90 (build 14, x86_64-pc-= linux-gnu, GTK+ Version 2.24.23)
=C2=A0of 2017-10-26
Re= pository revision: 646e56e150ca08978d6ce736b12867b4958a0cd8
Windo= wing system distributor 'The X.Org Foundation', version 11.0.609000= 00
System Description: Red= Hat Enterprise Linux Workstation release 6.6 (Santiago)

Recent messages:
Quit [4 times]
Ag finished
Mark saved where search started
Ag finished
nil
Entering debugger...
uncompressing files.el.gz...done
"Unprintable entity" [2 times]
Mark saved where= search started
Mark set
"Unprintable entity"=
Configured using:
=C2=A0'configure --with-modules<= /div>
=C2=A0--prefix=3D/home/kmodi/usr_local/apps/6/emacs/emacs-26
=C2=A0'--program-transform-name=3Ds/^ctags$/ctags_emacs/'
=C2=A0'CPPFLAGS=3D-I/home/kmodi/usr_local/6/include -I/usr/inclu= de/freetype2
=C2=A0-I/usr/include' 'CFLAGS=3D-ggdb3 -O0&#= 39; 'CXXFLAGS=3D-ggdb3 -O0'
=C2=A0'LDFLAGS=3D-L/home/= kmodi/usr_local/6/lib -L/home/kmodi/usr_local/6/lib64
=C2=A0-ggdb= 3'
=C2=A0PKG_CONFIG_PATH=3D/home/kmodi/usr_local/6/lib/pkgcon= fig:/home/kmodi/usr_local/6/lib64/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/= 6/lib/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib64/pkgconfig:/home/kmod= i/stowed/lib/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig:/usr/share/p= kgconfig:/lib/pkgconfig:/lib64/pkgconfig'

Conf= igured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM= DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIB= OTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK2 X11 MODULES

<= /div>

--

Kaushal Modi<= /p>

--f4030437f310df0323055cc6b600--