From: Kaushal Modi <kaushal.modi@gmail.com>
To: 22714@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#22714: 25.0.91; Minibuffer quirk in C-x r SPC
Date: Wed, 17 Feb 2016 09:07:55 -0500 [thread overview]
Message-ID: <CAFyQvY1CMGUwX3=QP4E-bJ2-BvPvurU6TOLZCguvkskw4W9iLQ@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY0Yt9Uaid=ZwLrEv2bZsEg55EwbnadeHfq_RiYLEhn8FQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]
OK, I found the change that caused this.
http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-25&id=0da7d35c6754b44d1ef4383e4a8ba9b98afc3a4c
diff --git a/lisp/register.el b/lisp/register.el
index 1c64a9a..6a5792c 100644
--- a/lisp/register.el
<http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/register.el?h=emacs-25&id=c435f506a1fd8fbf2bd22f59226ef296a3eb6ab3>
+++ b/lisp/register.el
<http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/register.el?h=emacs-25&id=0da7d35c6754b44d1ef4383e4a8ba9b98afc3a4c>
@@ -161,7 +161,7 @@ display such a window regardless."
collect c)))
(unwind-protect
(progn
- (while (memq (read-event (propertize prompt 'face 'minibuffer-prompt))
+ (while (memq (read-key (propertize prompt 'face 'minibuffer-prompt))
help-chars)
(unless (get-buffer-window buffer)
(register-preview buffer 'show-empty)))
It's the use of read-key instead of read-event that's causing this.
Stefan should be able to comment more on why that changes the behavior of
the prompt staying vs disappearing.
--
Kaushal Modi
On Wed, Feb 17, 2016 at 8:56 AM, Kaushal Modi <kaushal.modi@gmail.com>
wrote:
>
> I don't have a solution but I can confirm this behavior.
>
> In emacs 24.5, the "Point to Register" prompt disappears after pressing
> "1".
> In emacs 25.x, the prompt stays there after pressing "1".
>
> I tried edebugging in both 24.5 and 25.x but the behavior looks the same
> when doing edebug (the prompt disappears).
>
> I briefly looked at the register.el, but couldn't spot any change there
> that could be causing this. So the change is probably in some common
> library in elisp/C.
>
> --
> Kaushal Modi
>
[-- Attachment #2: Type: text/html, Size: 4067 bytes --]
next prev parent reply other threads:[~2016-02-17 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 1:11 bug#22714: 25.0.91; Minibuffer quirk in C-x r SPC Steve Revilak
2016-02-17 13:56 ` Kaushal Modi
2016-02-17 14:07 ` Kaushal Modi [this message]
2016-02-20 20:32 ` Stefan Monnier
2016-04-08 15:26 ` Kaushal Modi
2016-04-08 18:02 ` Stefan Monnier
2016-04-08 18:24 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY1CMGUwX3=QP4E-bJ2-BvPvurU6TOLZCguvkskw4W9iLQ@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=22714@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).