From: Kaushal Modi <kaushal.modi@gmail.com>
To: 26378@debbugs.gnu.org, phst@google.com
Subject: bug#26378: 26.0.50; Hitting 'n' during ediff gives Error
Date: Wed, 05 Apr 2017 21:20:56 +0000 [thread overview]
Message-ID: <CAFyQvY0JsJdvkFYDx8XYj6GG7bc9B4nsoXm=zPkti7yFukpOMg@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY3vrESEJnLfLN1=kUoAppXFahRPf12Qb6aFTpbreeR_pg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]
This patch fixes the error:
From 9de1cad8697781ac9a3729087cd38f1da7374ad4 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Wed, 5 Apr 2017 17:16:33 -0400
Subject: [PATCH] Check that file argument is a string
* lisp/vc/ediff-diff.el (ediff-exec-process): Check that the argument
passed to `file-local-copy' is a string. (Bug#26378)
---
lisp/vc/ediff-diff.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/vc/ediff-diff.el b/lisp/vc/ediff-diff.el
index cfa08ef360..79db0dc042 100644
--- a/lisp/vc/ediff-diff.el
+++ b/lisp/vc/ediff-diff.el
@@ -1151,8 +1151,9 @@ ediff-exec-process
args)
(setq args (append (split-string options)
(mapcar (lambda (file)
- (file-name-unquote
- (or (file-local-copy file) file)))
+ (when (stringp file)
+ (file-name-unquote
+ (or (file-local-copy file) file))))
files)))
(setq args (delete "" (delq nil args))) ; delete nil and "" from
arguments
;; the --binary option, if present, should be used only for buffer jobs
--
2.11.0
Can you please review and commit this if alright?
Thanks.
> --
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 2285 bytes --]
next prev parent reply other threads:[~2017-04-05 21:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 20:57 bug#26378: 26.0.50; Hitting 'n' during ediff gives Error Kaushal Modi
2017-04-05 21:03 ` Kaushal Modi
2017-04-05 21:20 ` Kaushal Modi [this message]
2017-04-05 21:53 ` Noam Postavsky
2017-04-05 22:36 ` Kaushal Modi
2017-04-05 23:23 ` npostavs
2017-04-06 12:23 ` Kaushal Modi
2017-04-06 12:45 ` npostavs
2017-04-06 14:36 ` Kaushal Modi
2017-04-06 23:38 ` npostavs
2017-04-07 14:09 ` Kaushal Modi
2017-04-07 22:31 ` npostavs
2017-04-08 14:58 ` Philipp Stephani
2017-04-10 19:36 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY0JsJdvkFYDx8XYj6GG7bc9B4nsoXm=zPkti7yFukpOMg@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=26378@debbugs.gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).