From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome Date: Thu, 14 Jun 2018 13:59:11 -0400 Message-ID: References: <83d0wt2wgi.fsf@gnu.org> <83bmcd2r08.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000098f57056e9ddcbe" X-Trace: blaine.gmane.org 1528999137 22538 195.159.176.226 (14 Jun 2018 17:58:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Jun 2018 17:58:57 +0000 (UTC) Cc: 31828@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 14 19:58:53 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTWWK-0005js-6e for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2018 19:58:52 +0200 Original-Received: from localhost ([::1]:41951 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTWYR-0006cZ-Aa for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2018 14:01:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTWXX-00062g-32 for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 14:00:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTWXT-0008GO-44 for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 14:00:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40509) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTWXT-0008G6-0k for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 14:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fTWXS-0007mZ-M2 for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 14:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jun 2018 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31828 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31828-submit@debbugs.gnu.org id=B31828.152899917229853 (code B ref 31828); Thu, 14 Jun 2018 18:00:02 +0000 Original-Received: (at 31828) by debbugs.gnu.org; 14 Jun 2018 17:59:32 +0000 Original-Received: from localhost ([127.0.0.1]:48406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTWWy-0007lR-Gv for submit@debbugs.gnu.org; Thu, 14 Jun 2018 13:59:32 -0400 Original-Received: from mail-lf0-f50.google.com ([209.85.215.50]:41048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTWWw-0007lD-DF for 31828@debbugs.gnu.org; Thu, 14 Jun 2018 13:59:30 -0400 Original-Received: by mail-lf0-f50.google.com with SMTP id d24-v6so10769981lfa.8 for <31828@debbugs.gnu.org>; Thu, 14 Jun 2018 10:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KCSe2FzuWLOLVuGt3Lkqt4+JLiRsWaVjFflGJyoJkSY=; b=Spz3kz1NkMgmVL7lf1unQKtLVCVhvd0gLrjaiM9x14sqIvG1PNSV7IysBFgJ7KLIbu vtna7GTNLFnYs7sae0XA5MQD9p/28tfx+bDkdJ86vQmGoxLsg4ab9jZ5D0RSO347T7IM gQs1lZktUfqHsJstkcbS3oPWiTYyZSdgwPAvD+GxdW4O6H2zv/l6isAZDMSAhX2dCq7t 8oAzvTpx3wJ7p8TEhgI1Kh93oiPoGdOpuh03AAZ12nbhrvqX35l3KJIPFdSgvPT2AUMd 1yVfaAtx/x4BU8Wp3SCZXQ0vtxuP15KU0HzBoActotsiFYsgYE4dArpGbJME9b0BVAn1 tIrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KCSe2FzuWLOLVuGt3Lkqt4+JLiRsWaVjFflGJyoJkSY=; b=luVzu5U0O7ikQsmRrN+MO07KpMYhW8th+++3VOKuAFfcQ0wjKl7bYA8CaeWUxKL8mi j2NNnOt3EHOGN7KOmt6PAZcL2yUggxhA1gxT/0Th65+JpOsll2P5XBypu4EtbWyCg7xH CEpNkymMQHXaXwJp2G6OWWgERsdRY0n1uRFiKanAoKgs54g19ylNLb0uQwGQU2gdz69R VL0ahi9LtyJIwGVAfBa2xw7jR9+fBJG5IDQcsN3M+yqbasVY4SsZFiVBYSCOgREJ7HmW Zw7UPzfryCIA84lyuGLNnQ/PIchflA7YlBFfv4aEg6SdzhDxW+7LqFgwPJ0NX6N5QsGF udbw== X-Gm-Message-State: APt69E03TYwuBMdhJxC1cobCZeEyKpX06nmLAGbMu6W1VEVfhK7pcfHs q8Me4X88tBVQauRO0nHYyCZ8+CUrWiCXMVA6nrI= X-Google-Smtp-Source: ADUXVKLeru7vZelCv7uHGq3cjKzYzkrunihKjRr22odfB9TKG8uWzmLCPZOpbEF9pH+Cu8SQawG1ZY0IZfN6FRl/xyE= X-Received: by 2002:a19:eb4d:: with SMTP id j74-v6mr6375466lfh.1.1528999164086; Thu, 14 Jun 2018 10:59:24 -0700 (PDT) In-Reply-To: <83bmcd2r08.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147424 Archived-At: --000000000000098f57056e9ddcbe Content-Type: text/plain; charset="UTF-8" If this was intentional, it's not a big deal. You can reject this patch. My use-package based workaround is quite simple (in case any one else ends up here while searching): (use-package browse-url :commands (browse-url-chrome)) ; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31828 On Thu, Jun 14, 2018 at 1:54 PM Eli Zaretskii wrote: > > From: Kaushal Modi > > Date: Thu, 14 Jun 2018 11:59:27 -0400 > > Cc: 31828@debbugs.gnu.org > > > > Then looking up in lisp/net/browse-url.el, I saw that all browse-url-* > functions had an autoload except for > > browse-url-chrome. > > No, not all of them. > > > So it looked like a clear oversight. Is that correct? > > I don't think it's an oversight. Chrome is proprietary software. > -- Kaushal Modi --000000000000098f57056e9ddcbe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
If this was intentional, it's not a big deal. You= can reject this patch.

My use-package based worka= round is quite simple (in case any one else ends up here while searching):<= /div>

(use-package browse-url
=C2=A0 :commands (brows= e-url-chrome)) ;https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31828


On Thu, Jun 14, 201= 8 at 1:54 PM Eli Zaretskii <eliz@gnu.org= > wrote:
> From: Kaushal = Modi <kausha= l.modi@gmail.com>
> Date: Thu, 14 Jun 2018 11:59:27 -0400
> Cc: 31828@d= ebbugs.gnu.org
>
> Then looking up in lisp/net/browse-url.el, I saw that all browse-url-*= functions had an autoload except for
> browse-url-chrome.

No, not all of them.

> So it looked like a clear oversight. Is that correct?

I don't think it's an oversight.=C2=A0 Chrome is proprietary softwa= re.
--

Kaushal Modi

--000000000000098f57056e9ddcbe--