bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome

bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

From f6c6f9bb0b5aeab89817ee18d738ee54daada9a3 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Thu, 14 Jun 2018 11:41:35 -0400
Subject: [PATCH] Add missing autoload for browse-url-chrome

* lisp/net/browse-url.el (browse-url-chrome): Add autoload cookie.
---
 lisp/net/browse-url.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index a84a7b1c71..85cf898438 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -1145,6 +1145,7 @@ browse-url-chromium
         browse-url-chromium-arguments
         (list url)))))

+;;;###autoload
 (defun browse-url-chrome (url &optional _new-window)
   "Ask the Google Chrome WWW browser to load URL.
 Default to the URL around or before point.  The strings in
-- 
2.17.0.rc0


-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1106 bytes --]

bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome

[Eli Zaretskii]

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Thu, 14 Jun 2018 11:43:34 -0400
> 
> From f6c6f9bb0b5aeab89817ee18d738ee54daada9a3 Mon Sep 17 00:00:00 2001
> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Thu, 14 Jun 2018 11:41:35 -0400
> Subject: [PATCH] Add missing autoload for browse-url-chrome
> 
> * lisp/net/browse-url.el (browse-url-chrome): Add autoload cookie.

No rationale?

bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

The rationale is because I ended up with this error:

> Symbol’s function definition is void: browse-url-chrome

:)

Then looking up in lisp/net/browse-url.el, I saw that all browse-url-*
functions had an autoload except for browse-url-chrome.

So it looked like a clear oversight. Is that correct?




On Thu, Jun 14, 2018 at 11:56 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Kaushal Modi <kaushal.modi@gmail.com>
> > Date: Thu, 14 Jun 2018 11:43:34 -0400
> >
> > From f6c6f9bb0b5aeab89817ee18d738ee54daada9a3 Mon Sep 17 00:00:00 2001
> > From: Kaushal Modi <kaushal.modi@gmail.com>
> > Date: Thu, 14 Jun 2018 11:41:35 -0400
> > Subject: [PATCH] Add missing autoload for browse-url-chrome
> >
> > * lisp/net/browse-url.el (browse-url-chrome): Add autoload cookie.
>
> No rationale?
>
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1508 bytes --]

bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome

[Eli Zaretskii]

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Thu, 14 Jun 2018 11:59:27 -0400
> Cc: 31828@debbugs.gnu.org
> 
> Then looking up in lisp/net/browse-url.el, I saw that all browse-url-* functions had an autoload except for
> browse-url-chrome. 

No, not all of them.

> So it looked like a clear oversight. Is that correct?

I don't think it's an oversight.  Chrome is proprietary software.

bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

If this was intentional, it's not a big deal. You can reject this patch.

My use-package based workaround is quite simple (in case any one else ends
up here while searching):

(use-package browse-url
  :commands (browse-url-chrome)) ;
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31828


On Thu, Jun 14, 2018 at 1:54 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Kaushal Modi <kaushal.modi@gmail.com>
> > Date: Thu, 14 Jun 2018 11:59:27 -0400
> > Cc: 31828@debbugs.gnu.org
> >
> > Then looking up in lisp/net/browse-url.el, I saw that all browse-url-*
> functions had an autoload except for
> > browse-url-chrome.
>
> No, not all of them.
>
> > So it looked like a clear oversight. Is that correct?
>
> I don't think it's an oversight.  Chrome is proprietary software.
>
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1468 bytes --]

bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome

[Noam Postavsky]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Kaushal Modi <kaushal.modi@gmail.com>
>> Date: Thu, 14 Jun 2018 11:59:27 -0400
>> Cc: 31828@debbugs.gnu.org
>> 
>> Then looking up in lisp/net/browse-url.el, I saw that all browse-url-* functions had an autoload except for
>> browse-url-chrome. 
>
> No, not all of them.

Looks like the only other one missing an autoload is
browse-url-epiphany.

>> So it looked like a clear oversight. Is that correct?
>
> I don't think it's an oversight.  Chrome is proprietary software.

If that's the reason, shouldn't it be removed completely (and people who
want to use Chrome could just set browse-url-chromium-program to
"chrome" instead)?  I've cc'd the author of the commit which added it.

[1: 05a630484f]: 2016-01-24 14:47:28 -0500
  browse-url.el: Add 'google-chrome' to supported browsers.
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=05a630484fd652f67ce06679fb3f890f5fdd65ea

bug#31828: [PATCH] [emacs-26] Add missing autoload cookie for browse-url-chrome

[Lars Ingebrigtsen]

Noam Postavsky <npostavs@gmail.com> writes:

> If that's the reason, shouldn't it be removed completely (and people who
> want to use Chrome could just set browse-url-chromium-program to
> "chrome" instead)?  I've cc'd the author of the commit which added it.

My guess would be that some people may want to use both Chrome and
Chromium, so I think it might make sense to have separate functions.

And leaving the autoload off of the -chrome version seems OK to me, so
I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no