From: Kaushal Modi <kaushal.modi@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>, Eli Zaretskii <eliz@gnu.org>
Cc: 23453-done@debbugs.gnu.org
Subject: bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep
Date: Thu, 05 May 2016 16:23:07 +0000 [thread overview]
Message-ID: <CAFyQvY08nN9aQHKbJLEwWD7576jqm3s3SyaMS0s7ZOtmoWuzBA@mail.gmail.com> (raw)
In-Reply-To: <2d5fca36-dee6-9c4b-6c7b-7ea50501ea62@yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On Wed, May 4, 2016 at 9:18 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
> That doesn't mean that it isn't being quoted now, in the function in
> question.
>
OK
> It's functionally equivalent to the second one, I believe.
>
It is! I just rearranged the position for shell-quote-argument. Actually
all 3 patches were the same, functionally.
> Actually, this comment means the opposite: we would want ~ in the
> command line unquoted, but that won't happen because DIR is quoted
> later. So we require DIR to be non-abbreviated.
>
> Anyway, let's leave that off until you find a definite case where it's a
> problem.
OK
> I've pushed the other change now in ab3ba91.
>
> Please see if it fixes the problem, and if so, close the bug.
>
It does fix the bug, thanks!
--
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 1599 bytes --]
next prev parent reply other threads:[~2016-05-05 16:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 19:39 bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep Kaushal Modi
2016-05-04 19:49 ` Eli Zaretskii
2016-05-04 19:56 ` Kaushal Modi
2016-05-04 20:24 ` Kaushal Modi
2016-05-04 21:14 ` Kaushal Modi
2016-05-04 21:39 ` Kaushal Modi
2016-05-04 22:15 ` Dmitry Gutov
2016-05-04 22:30 ` Kaushal Modi
2016-05-05 1:18 ` Dmitry Gutov
2016-05-05 16:23 ` Kaushal Modi [this message]
2016-05-05 2:44 ` Eli Zaretskii
2016-05-05 2:37 ` Eli Zaretskii
2016-05-05 16:36 ` Kaushal Modi
2016-05-05 16:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY08nN9aQHKbJLEwWD7576jqm3s3SyaMS0s7ZOtmoWuzBA@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=23453-done@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).