From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#27397: [PATCH] New commands for bulk tracing of elisp functions Date: Fri, 16 Jun 2017 15:43:32 +0000 Message-ID: References: <1348823a-7623-8146-8cc0-8c0eff13e458@orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f403045fff247167d4055215a62b" X-Trace: blaine.gmane.org 1497627859 10299 195.159.176.226 (16 Jun 2017 15:44:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Jun 2017 15:44:19 +0000 (UTC) To: 27397@debbugs.gnu.org, psainty@orcon.net.nz, Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 16 17:44:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLtPv-00029E-1m for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Jun 2017 17:44:11 +0200 Original-Received: from localhost ([::1]:59474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLtPz-0008A4-AI for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Jun 2017 11:44:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLtPp-00089Z-SZ for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 11:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLtPm-0005T4-PK for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 11:44:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48867) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dLtPm-0005Sw-Kv for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 11:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dLtPm-0004Mq-EN for bug-gnu-emacs@gnu.org; Fri, 16 Jun 2017 11:44:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <1348823a-7623-8146-8cc0-8c0eff13e458@orcon.net.nz> Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jun 2017 15:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27397-submit@debbugs.gnu.org id=B27397.149762783216763 (code B ref 27397); Fri, 16 Jun 2017 15:44:02 +0000 Original-Received: (at 27397) by debbugs.gnu.org; 16 Jun 2017 15:43:52 +0000 Original-Received: from localhost ([127.0.0.1]:51544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLtPc-0004MJ-7c for submit@debbugs.gnu.org; Fri, 16 Jun 2017 11:43:52 -0400 Original-Received: from mail-lf0-f44.google.com ([209.85.215.44]:34138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLtPa-0004M4-4o for 27397@debbugs.gnu.org; Fri, 16 Jun 2017 11:43:50 -0400 Original-Received: by mail-lf0-f44.google.com with SMTP id v20so27475897lfa.1 for <27397@debbugs.gnu.org>; Fri, 16 Jun 2017 08:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=XuQg6Eh+hM85UybIt5FY26EZWaYiHOzKOFTcBsutJ1c=; b=Wzqtqo25dG7Ab+wS9BBMuH2OEI8HZXq3+suPlQ3hstRZQJubzbxmNQ4YYAh5gZpIH0 TkmS1MfiwzLUcplLyinJLKEnU16jgGBW4SLYx31allVWCfeKtwcLOvamFI0DL1JiCxCI 7IDnHm8zgqHx2J8IvxatQRkOvubluxZWs3PdEFtOvYmeblobr2DsBo/k4rXZVu6z/b0z A+TPbD32JrF09C6QIjujs8QEtHfbeP+j6RWWJKJ56ubR72dFb0Pjp3yEXpVvuRo7+Cxr w9aK9tBA3KMTtaHYifMsY4rBb7lXb43WViPrde9Y57rfDUubidfRiDWquTd3DZvM4GvM JGlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=XuQg6Eh+hM85UybIt5FY26EZWaYiHOzKOFTcBsutJ1c=; b=qrTjtGO1hs4K5+croiblNwed+TX3wYzumC+RZSWYSs7TcRxjuR9GhfMlma8xFUEPw4 CTDHRG2ABQS1CPGWP5gHswVNk/VJsQERtITokQSzyX7vNoaLhA4zkHeszYgBqEItHusJ HxAqx5LwIg1OIXiiJZoGnvkFJSxZYAfTGikiDy1QsoN3LB3Ow9rcwlRiQXBprQ32INUA A47IyPF4cB0bVbM0+xJ5VLaxQkGSVvbA5dm/9xcP+0vOZ9hwscaIIZe6PUrLtBic80BQ E8FNBXmAe8zBMVmo/i4zmxrSjEDjH8QB01NmZLPeccOYctc9JFnwaemjlk2gp/jTCnog K7rg== X-Gm-Message-State: AKS2vOy5CiIfh0+U0Rihyj7KT4hTncINbAXF8eEFqs3VKcgjDH4dm/W0 oTZ/mCaDzLQcu90y+KJVBx+z6ituTA== X-Received: by 10.46.81.26 with SMTP id f26mr880079ljb.33.1497627823791; Fri, 16 Jun 2017 08:43:43 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133650 Archived-At: --f403045fff247167d4055215a62b Content-Type: text/plain; charset="UTF-8" > I note that the `trace-is-traced' function does not follow the usual > naming convention for predicates. Should this be renamed to > `trace-is-traced-p' Based on current examples[1], it is more common to see predicate *functions* end in "-p". So the "-is-" portion is maybe redundant. My suggestion would be something like "trace-traced-p" or "trace-fn-traced-p". [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?att=0;bug=26564;msg=5 -- Kaushal Modi --f403045fff247167d4055215a62b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> I note that the `trace-is-traced' function d= oes not follow the usual
> naming convention for predicates.= =C2=A0 Should this be renamed to
> `trace-is-traced-p'

Based on current examples[1], it is more common to see pre= dicate *functions* end in "-p". So the "-is-" portion i= s maybe redundant.

My suggestion would be something like= "trace-traced-p" or "trace-fn-traced-p".

-- =

Kaushal Mo= di

--f403045fff247167d4055215a62b--