From: Matthias Clasen <matthias.clasen@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, 23144@debbugs.gnu.org
Subject: bug#23144: shrinking windows with gtk 3.20
Date: Sat, 2 Apr 2016 19:20:41 -0400 [thread overview]
Message-ID: <CAFwd_vCeKPrVCEYj9PPx4yPYTDYq3TSXeVw5JrbBkrmbbabbRA@mail.gmail.com> (raw)
In-Reply-To: <83y48vrk5d.fsf@gnu.org>
On Sat, Apr 2, 2016 at 1:32 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Sat, 2 Apr 2016 13:27:25 -0400
>> From: Matthias Clasen <matthias.clasen@gmail.com>
>> Cc: martin rudalics <rudalics@gmx.at>, 23144@debbugs.gnu.org,
>> Paul Eggert <eggert@cs.ucla.edu>
>>
>> > Do we understand the effect of this? It effectively makes the
>> > xg_frame_resized call a no-op, but I very much doubt that this call
>> > was added there with no good reason. Does the history of this
>> > addition, including any related discussions, teach us something about
>> > the reason?
>>
>> Yes, this is what I would have suggested as alternative patch for
>> emacs 25. It only disregards the return value of
>> gdk_window_get_geometry if it is still the initial value of 1,1 -
>> thats clearly not a useful size for an emacs window...
>
> Ignoring the 1x1 dimensions is a no-brainer. What bothers me is
> something else entirely: that call to xg_frame_resized was most
> probably added there for a reason; if xg_frame_resized no longer works
> with GTK 3.22 and later as it did before, the question is what, if
> anything, else do we lose with the new behavior?
>
> Could you perhaps describe what that call does in older versions of
> GTK, and why it worked before, but not anymore?
Well, it seems that nobody on your side remembers the reason for why
that particular xg_frame_resized call was added :-(
It is not that xg_frame_resized doesn't work anymore with GTK 3.22. It
just gets called at a time when the GdkWindow is not fully set up yet.
The reason that that happens now is due to a) to some subtle changes
in the way GTK+ sets up windows initially and b) emacs poking directly
at X events like MapNotify.
next prev parent reply other threads:[~2016-04-02 23:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 20:52 bug#23144: shrinking windows with gtk 3.20 Matthias Clasen
2016-03-29 15:18 ` martin rudalics
2016-03-29 16:02 ` Eli Zaretskii
2016-03-29 17:20 ` martin rudalics
2016-03-31 16:09 ` John Wiegley
2016-04-01 7:48 ` martin rudalics
2016-04-01 9:46 ` Eli Zaretskii
2016-04-02 0:03 ` Paul Eggert
2016-04-02 7:01 ` Eli Zaretskii
2016-04-02 15:19 ` Matthias Clasen
2016-04-02 15:47 ` Eli Zaretskii
2016-04-02 16:06 ` martin rudalics
2016-04-02 16:28 ` Eli Zaretskii
2016-04-02 17:27 ` Matthias Clasen
2016-04-02 17:32 ` Eli Zaretskii
2016-04-02 23:20 ` Matthias Clasen [this message]
2016-04-03 2:36 ` Eli Zaretskii
2016-05-16 6:53 ` Paul Eggert
2016-05-16 8:21 ` martin rudalics
2016-05-16 15:53 ` Eli Zaretskii
2016-05-16 17:11 ` Paul Eggert
2017-03-24 13:01 ` Ken Brown
2017-03-24 13:24 ` martin rudalics
2017-03-24 13:38 ` Ken Brown
2017-03-24 18:52 ` martin rudalics
2017-03-24 13:35 ` Eli Zaretskii
2017-03-24 14:08 ` Ken Brown
2017-03-24 14:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFwd_vCeKPrVCEYj9PPx4yPYTDYq3TSXeVw5JrbBkrmbbabbRA@mail.gmail.com \
--to=matthias.clasen@gmail.com \
--cc=23144@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).