From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Aaron S. Hawley" Newsgroups: gmane.emacs.bugs Subject: bug#11010: tar-subfile-save-buffer: Buffer is read-only: # Date: Tue, 13 Mar 2012 13:05:12 -0400 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=0015175df004a8c07d04bb22dc6e X-Trace: dough.gmane.org 1331658384 15831 80.91.229.3 (13 Mar 2012 17:06:24 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 13 Mar 2012 17:06:24 +0000 (UTC) To: 11010@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 13 18:06:23 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S7VB1-00026F-AI for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Mar 2012 18:06:23 +0100 Original-Received: from localhost ([::1]:54131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7VB0-0004qA-Kl for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Mar 2012 13:06:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7VAq-0004mv-MQ for bug-gnu-emacs@gnu.org; Tue, 13 Mar 2012 13:06:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7VAj-0002Qy-Uy for bug-gnu-emacs@gnu.org; Tue, 13 Mar 2012 13:06:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7VAj-0002Qe-P7 for bug-gnu-emacs@gnu.org; Tue, 13 Mar 2012 13:06:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S7Vdi-0003Ut-9i for bug-gnu-emacs@gnu.org; Tue, 13 Mar 2012 13:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Aaron S. Hawley" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Mar 2012 17:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11010 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.133166013613404 (code B ref -1); Tue, 13 Mar 2012 17:36:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Mar 2012 17:35:36 +0000 Original-Received: from localhost ([127.0.0.1]:49266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S7VdI-0003U8-4q for submit@debbugs.gnu.org; Tue, 13 Mar 2012 13:35:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56595) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S7VdF-0003U1-GJ for submit@debbugs.gnu.org; Tue, 13 Mar 2012 13:35:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7VAB-0002MU-HY for submit@debbugs.gnu.org; Tue, 13 Mar 2012 13:05:35 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:49638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7VAB-0002MQ-BS for submit@debbugs.gnu.org; Tue, 13 Mar 2012 13:05:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7VA5-0004ZJ-7c for bug-gnu-emacs@gnu.org; Tue, 13 Mar 2012 13:05:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7V9v-0002Kq-7W for bug-gnu-emacs@gnu.org; Tue, 13 Mar 2012 13:05:24 -0400 Original-Received: from mail-bk0-f41.google.com ([209.85.214.41]:65337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7V9u-0002Kf-UD for bug-gnu-emacs@gnu.org; Tue, 13 Mar 2012 13:05:15 -0400 Original-Received: by bkwq16 with SMTP id q16so780337bkw.0 for ; Tue, 13 Mar 2012 10:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=fMshfS3BNY32IxiZZiC6mwLR4xkbF8JW4yPsX4ke+GI=; b=sa8AwFKTo8KRNDrCvRPsN04vLNR5upgQyAYygY3v3himkEG/f8+1hjXuRoTV+sS+EK 2EOCHgPRohe7pHJnmNVaRZHxz5eO/PWIag1tvQr1NqhwMk4zh+UCHfp6wubMwfVCjCLX c97splJ/NY38vQHqDrvO67oF3SFOSIcsdckkakvLV92AqsYMb1raUMolzbX+r8N1C4bY WIwU83c2i5eJ1brvktbjB4AT2xJCGPkG3gyGNej2aVqHKrfKVz63fhueI7Ej4KnxWM6H E65rgBhd83NHcUHYZ6ZCWo5Mgs7d5GaTFppflj8nw6txObkOT8L02DW3lwcwYZVeb794 MF7A== Original-Received: by 10.204.157.155 with SMTP id b27mr6368183bkx.103.1331658312171; Tue, 13 Mar 2012 10:05:12 -0700 (PDT) Original-Received: by 10.205.35.78 with HTTP; Tue, 13 Mar 2012 10:05:12 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57770 Archived-At: --0015175df004a8c07d04bb22dc6e Content-Type: text/plain; charset=ISO-8859-1 Opening a tar file and then a sub file, used to be able to save. Doesn't seem to be the case in the latest Emacs pretest. In fact, everything's opening as read-only. Test case: M-! touch foo; tar cf foo.tar foo RET C-x C-f foo.tar RET f C-x q C-x s ! The above should save the files including the sub file, but instead complains about the tar file being. The following patch removes the C-x q and saving actually works. Seems this bug was a result of tar-mode inheriting from special-mode. Thanks for Emacs, /a 2012-03-13 Aaron S. Hawley * tar-mode.el (tar-mode): Fix saving by conditionally undoing `special-mode' setting of `buffer-read-only'. --- tar-mode.el 2012-02-13 11:13:25.000000000 -0500 +++ tar-mode.el 2012-03-13 12:54:00.376389400 -0400 @@ -634,6 +634,9 @@ See also: variables `tar-update-datestamp' and `tar-anal-blocksize'. \\{tar-mode-map}" + (when (and buffer-file-name + (file-writable-p buffer-file-name)) + (setq buffer-read-only nil)) ;; Undo what `special-mode' did. (make-local-variable 'tar-parse-info) (set (make-local-variable 'require-final-newline) nil) ; binary data, dude... (set (make-local-variable 'local-enable-local-variables) nil) --0015175df004a8c07d04bb22dc6e Content-Type: application/octet-stream; name="tar-mode.el.diff" Content-Disposition: attachment; filename="tar-mode.el.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 MjAxMi0wMy0xMyAgQWFyb24gUy4gSGF3bGV5ICA8QWFyb24uUy5IYXdsZXlAZ21haWwuY29tPgoK ICAgICAgICAqIHRhci1tb2RlLmVsICh0YXItbW9kZSk6IEZpeCBzYXZpbmcgYnkgY29uZGl0aW9u YWxseSB1bmRvaW5nCiAgICAgICAgYHNwZWNpYWwtbW9kZScgc2V0dGluZyBvZiBgYnVmZmVyLXJl YWQtb25seScuCgotLS0gdGFyLW1vZGUuZWwJMjAxMi0wMi0xMyAxMToxMzoyNS4wMDAwMDAwMDAg LTA1MDAKKysrIHRhci1tb2RlLmVsCTIwMTItMDMtMTMgMTI6NTQ6MDAuMzc2Mzg5NDAwIC0wNDAw CkBAIC02MzQsNiArNjM0LDkgQEAKIAogU2VlIGFsc286IHZhcmlhYmxlcyBgdGFyLXVwZGF0ZS1k YXRlc3RhbXAnIGFuZCBgdGFyLWFuYWwtYmxvY2tzaXplJy4KIFxce3Rhci1tb2RlLW1hcH0iCisg ICh3aGVuIChhbmQgYnVmZmVyLWZpbGUtbmFtZQorICAgICAgICAgICAgIChmaWxlLXdyaXRhYmxl LXAgYnVmZmVyLWZpbGUtbmFtZSkpCisgICAgKHNldHEgYnVmZmVyLXJlYWQtb25seSBuaWwpKSA7 OyBVbmRvIHdoYXQgYHNwZWNpYWwtbW9kZScgZGlkLgogICAobWFrZS1sb2NhbC12YXJpYWJsZSAn dGFyLXBhcnNlLWluZm8pCiAgIChzZXQgKG1ha2UtbG9jYWwtdmFyaWFibGUgJ3JlcXVpcmUtZmlu YWwtbmV3bGluZSkgbmlsKSA7IGJpbmFyeSBkYXRhLCBkdWRlLi4uCiAgIChzZXQgKG1ha2UtbG9j YWwtdmFyaWFibGUgJ2xvY2FsLWVuYWJsZS1sb2NhbC12YXJpYWJsZXMpIG5pbCkK --0015175df004a8c07d04bb22dc6e--