From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karol Ostrovsky Newsgroups: gmane.emacs.bugs Subject: bug#18302: MSYS2 build issues Date: Thu, 21 Aug 2014 12:08:08 +0200 Message-ID: References: <83zjezb00n.fsf@gnu.org> <83y4ujaxiv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1408615763 27017 80.91.229.3 (21 Aug 2014 10:09:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Aug 2014 10:09:23 +0000 (UTC) Cc: Chris Zheng , 18302@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 21 12:09:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XKPIy-0000xn-8M for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Aug 2014 12:09:16 +0200 Original-Received: from localhost ([::1]:59856 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKPIx-0005p4-NB for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Aug 2014 06:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKPIq-0005oW-NZ for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2014 06:09:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKPIk-0007WW-Pf for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2014 06:09:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKPIk-0007WS-LW for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2014 06:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XKPIk-0004WR-2V for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2014 06:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Karol Ostrovsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Aug 2014 10:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18302 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 18302-submit@debbugs.gnu.org id=B18302.140861569717327 (code B ref 18302); Thu, 21 Aug 2014 10:09:01 +0000 Original-Received: (at 18302) by debbugs.gnu.org; 21 Aug 2014 10:08:17 +0000 Original-Received: from localhost ([127.0.0.1]:48763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XKPI0-0004VO-HD for submit@debbugs.gnu.org; Thu, 21 Aug 2014 06:08:16 -0400 Original-Received: from mail-vc0-f173.google.com ([209.85.220.173]:57916) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XKPHy-0004VB-5z for 18302@debbugs.gnu.org; Thu, 21 Aug 2014 06:08:14 -0400 Original-Received: by mail-vc0-f173.google.com with SMTP id hy10so10492198vcb.32 for <18302@debbugs.gnu.org>; Thu, 21 Aug 2014 03:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=p8utUvW+43zPnGqD4royv7cgv8wXirSaem40J/Blp1I=; b=LyD2RltpeiQOKbZ+xUCjgUAJ6oA6JWC8PM12/ixr8FL3CsRL8I0MDHmrvF3vUnxFBw fWMzLPf4w3BT6UWJtF3mT6CxLk2g8fw/VtcGtQIZYvQ3iKWC5omQU4SJPwtFeBr4oDoX pyzNMNoNakTg1HcVu99dB50CFudxWSYTSIHW5ybNDFOqm2utgtRe7obiqIrZ5MkZ49lm ATKiT2AkoED3OjvnW55ozV4gsqwolECajO6YIiDCb6nK6/+sKh1Z8+PCC0r/+Tg6qOWD Qs32qlFtJLUTVu8RF1mmWP3o/S6kOLPGIeeeh57UYyiLDngUlJJCsJGIsZXcWH1vznI1 wViA== X-Received: by 10.220.251.200 with SMTP id mt8mr1612716vcb.24.1408615688440; Thu, 21 Aug 2014 03:08:08 -0700 (PDT) Original-Received: by 10.221.48.196 with HTTP; Thu, 21 Aug 2014 03:08:08 -0700 (PDT) In-Reply-To: <83y4ujaxiv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92560 Archived-At: Hello all, thank you for the very quick response. First, I am sorry for some of the mess, like submitting whole files. Now to the technical stuff: 1. I am the sole author of these changes. I have no issue with signing the required legal papers. Please, let me know how to proceed with this. 2. MSYS2 'uname' is indeed the main source of the problem. My solution fixes that, and also renames opsys=3Dmingw32 to opsys=3Dmingw. This renaming is not strictly necessary, but I believe it is a good practice to name things as clearly as possible. In this case, the name mingw32 seems too related to a 32-bit system, which it is not any more after my changes. 3. "-mtune" change: I don't see how Pentium4 optimisations are related to running Windows9X. I know people still running Windows95 on Pentium III. Shouldn't the official Emacs build be as generic as possible? Perhaps one should even take away the whole -mtune part for MinGW. 4. CPPFLAGS for XPM change follows the same pattern as cygwin. Both cygwin and MSYS2 install the XPM library in an unusual place. Since adding an include path for cygwin was already accepted, I did not see any issue with adding a similar solution for MSYS2. 5. I am sorry I was not aware of the ln flag issues. The -v was only to see the result and it is completely unnecessary, while the -f was needed just as it was used for "rm -f" in the original. The crash is quite random, and currently I am unable to reproduce it. Yesterday it was relatively easy to reproduce, but today it is not happening. However, I remember that make stopped with something like: unable to build emacs.exe on line 603 of src/Makefile with reason "rm: cannot remove =E2=80=98bootstrap-emacs.exe=E2=80=99: Device or resource busy". Th= e crash happened even when running make without a j flag, that is non-parallel build. The easy manual workaround is to just start make again, but then it is hard to add emacs to any automated build system (for example as an MSYS2 package). Given how random this crash is it is hard to justify any change to the Makefile.in until I or someone else can find the root cause. Best regards, Karol On 20 August 2014 19:20, Eli Zaretskii wrote: >> From: Glenn Morris >> Cc: Karol Ostrovsky , chriszheng99@gmail.com= , 18302@debbugs.gnu.org >> Date: Wed, 20 Aug 2014 13:04:44 -0400 >> >> Eli Zaretskii wrote: >> >> > not sure we should be changing it. In particular, I'm not sure >> > non-GNU 'ln' supports these 2 switches (and why do you need -v >> > anyway?). >> >> http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/= html_node/Limitations-of-Usual-Tools.html >> >> "Don't rely on ln having a -f option." > > Thanks, that's what I remembered. > >> This and other changes that you commented on give the strong impression >> that this patch contains a bunch of things that are just personal >> preferences. > > The only real issue AFAICT is the value that MSYS2's 'uname' returns, > that issue does need a (trivial) solution.