From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthew Bauer Newsgroups: gmane.emacs.bugs Subject: bug#48994: 28.0.50; [PATCH] 28.0.50; Native compilation unnecessarily recompiles .eln (macOS) Date: Tue, 22 Jun 2021 18:01:25 -0500 Message-ID: References: <8335tk7h32.fsf@gnu.org> <835yyg5k4p.fsf@gnu.org> <83fsxh1wdd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a0604d05c562c53e" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24817"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Third , Matthew Bauer , Eli Zaretskii , 48994@debbugs.gnu.org, Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 23 01:02:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvpPG-0006GH-B9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Jun 2021 01:02:10 +0200 Original-Received: from localhost ([::1]:36940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvpPF-00024l-C0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Jun 2021 19:02:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvpP9-00024Z-0J for bug-gnu-emacs@gnu.org; Tue, 22 Jun 2021 19:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lvpP8-00078o-Lb for bug-gnu-emacs@gnu.org; Tue, 22 Jun 2021 19:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lvpP8-0007Sl-5P for bug-gnu-emacs@gnu.org; Tue, 22 Jun 2021 19:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthew Bauer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 23:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48994-submit@debbugs.gnu.org id=B48994.162440290428663 (code B ref 48994); Tue, 22 Jun 2021 23:02:02 +0000 Original-Received: (at 48994) by debbugs.gnu.org; 22 Jun 2021 23:01:44 +0000 Original-Received: from localhost ([127.0.0.1]:40057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvpOq-0007SE-6Q for submit@debbugs.gnu.org; Tue, 22 Jun 2021 19:01:44 -0400 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:35754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvpOo-0007S1-I2 for 48994@debbugs.gnu.org; Tue, 22 Jun 2021 19:01:42 -0400 Original-Received: by mail-ej1-f54.google.com with SMTP id gn32so943000ejc.2 for <48994@debbugs.gnu.org>; Tue, 22 Jun 2021 16:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=U8KiWZIZj6P6BOCu7X2I8UkoW8Y85GYEKVhuwGkP4iA=; b=IKYifC17mVNyvjpHJExc9bfmG32A2Bqs8jcLTr6lTRDu8dpLEPNyJA4URU1aPBbPXo 71KUobLNvI2DaM/Han5PwxIe1XkLurrg6mu14eYA9UsDGXX9d/piuuKkWr8s5o1Bw1eN +1DJKai31e+5HXIOBoF7LkgZYIFlMKp6sDSE3spQACTxHm/sLPABcNrAb7CVpGei3jRD wvB34+S/92PA+kh4CrfFLpypYhXphCwFJQ7vTQTrIKkRRuEHqqKk7OH6vkLdQ6K8Zp03 C3JUSC7MZCpCiuvuuJBOWPIW9KLTNKerzVx8kvFYuatM7mUyyNVBIgy4y/x6351XNWX+ yMQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=U8KiWZIZj6P6BOCu7X2I8UkoW8Y85GYEKVhuwGkP4iA=; b=McZM46+RFMYe3SJpweinzCaEKvDgrJQ/giGHhDWRZxbNosw56iTV7NGdqYIIwkgFKD ERiJwGvTNDPsvm5pvkDZCFaxZHvncO5V3FIjzJ532udu5n3WDsjofT0kPYDHNry3FvFW 8s4ojOJ65uSV7cqdzN/eKxJTrCqIpkmD+IyNQteAFIvAaFfSYe1tOocMcP6jlQ2qoqvW BYu9rdOR8nhSj4nsv5ui7JImDYcK59Rcv7vCbXcqz3E9X2TM/uYjkTPglqpH/egVNbti ftAK7CnNdGDKFAxLf3dxu1qDa3r0LcWo9hAR+x2gAAAKFpllDwaaFynvYTdfpV1EBZ1W rYCw== X-Gm-Message-State: AOAM532/Cbtuv5J3cYDgl6Hr8Nw4US8lRKQ2FUp9C6B3Yp8wZuqkFgEN qWgNG9r3lfrLKxzJmfJ0lx7FH2ioN0t9bi37ru4= X-Google-Smtp-Source: ABdhPJzAUIDC0dfgreDg1815fV7BgqJWQYIoxViad+VtgaLFg0PWv9CcPFVMOJqV9R1VIDZwF8D0vL3au5IgSgoWXjQ= X-Received: by 2002:a17:907:20da:: with SMTP id qq26mr6398177ejb.42.1624402896640; Tue, 22 Jun 2021 16:01:36 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208884 Archived-At: --000000000000a0604d05c562c53e Content-Type: text/plain; charset="UTF-8" > Turns out there's another variable that should only be set when > building the app. > Please try the attached patch. That works for me ! So previously the nextstep/Emacs.app was getting generated even with --disable-ns-self-contained. I think that's fine to not build in this case - in fact it duplicates the Emacs executable - but just a note that it kind of changes things for packages. I have a fix for Nixpkgs (which previously installed nexstep/Emacs.app), but I think homebrew-emacs-plus would also be effected: https://github.com/d12frosted/homebrew-emacs-plus On Tue, Jun 22, 2021 at 12:24 PM Alan Third wrote: > On Tue, Jun 22, 2021 at 05:59:59PM +0100, Alan Third wrote: > > If so there's no need for nextstep/Makefile to do anything, so it > > shouldn't matter. I suppose we probably want to avoid generating that > > makefile, or not call it, or something... I'm not sure. > > Turns out there's another variable that should only be set when > building the app. > > Please try the attached patch. > -- > Alan Third > --000000000000a0604d05c562c53e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Tu= rns out there's another variable that should only be set when
> b= uilding the app.

> Please try the attached patch.

That works for me = !

So previously the nextstep/Emacs.app was getting= generated even with=C2=A0--disable-ns-self-contained. I think that's f= ine to not build in this=C2=A0case - in fact it duplicates the Emacs execut= able - but just a note that it kind of changes things for packages. I have = a fix for Nixpkgs (which previously installed nexstep/Emacs.app), but I thi= nk homebrew-emacs-plus would also be effected:


On Tue, Jun 22, = 2021 at 12:24 PM Alan Third <alan@idi= ocy.org> wrote:
On Tue, Jun 22, 2021 at 05= :59:59PM +0100, Alan Third wrote:
> If so there's no need for nextstep/Makefile to do anything, so it<= br> > shouldn't matter. I suppose we probably want to avoid generating t= hat
> makefile, or not call it, or something... I'm not sure.

Turns out there's another variable that should only be set when
building the app.

Please try the attached patch.
--
Alan Third
--000000000000a0604d05c562c53e--