From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Newsgroups: gmane.emacs.bugs Subject: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase Date: Mon, 8 Jun 2020 15:24:23 -0300 Message-ID: References: <5CB87F9A-431C-4BC6-99CD-753844A26BCC@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="100055"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eggert@cs.ucla.edu, 41755@debbugs.gnu.org, pipcet@gmail.com, akrl@sdf.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 08 20:25:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiMSa-000PwO-86 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jun 2020 20:25:24 +0200 Original-Received: from localhost ([::1]:35566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiMSY-0001tz-U5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jun 2020 14:25:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiMSE-0001ti-Nn for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 14:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiMSE-0007ou-Eh for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 14:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jiMSE-0001Pn-AV for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 14:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jun 2020 18:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41755 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, Paul Eggert , 41755@debbugs.gnu.org, Pip Cet , Andrea Corallo Original-Received: via spool by submit@debbugs.gnu.org id=B.15916406785394 (code B ref -1); Mon, 08 Jun 2020 18:25:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Jun 2020 18:24:38 +0000 Original-Received: from localhost ([127.0.0.1]:57880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiMRq-0001Ov-MS for submit@debbugs.gnu.org; Mon, 08 Jun 2020 14:24:38 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:37870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiMRq-0001Op-1x for submit@debbugs.gnu.org; Mon, 08 Jun 2020 14:24:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiMRp-0001sU-Pe for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 14:24:37 -0400 Original-Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:34021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiMRo-0007li-Uj; Mon, 08 Jun 2020 14:24:37 -0400 Original-Received: by mail-ot1-x335.google.com with SMTP id b18so14462694oti.1; Mon, 08 Jun 2020 11:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k16kUmG8L1NRQ9ItF/APOhTL6rXhmyq4oUmEcfOB2fE=; b=kVng7AFVDNJLDKbriKBTlKsAEOkSJDj7ZOMI09FaJLZlNyA84Vty+uMysaRrwjNRkg sc1w6+ALvUKTZg9to3g5hNvyqot/jsEqUypxLQJ1oXwZE9IDUIddrpN4rrbK6svmj8yQ xt6GnIjUaWJr/zUN2CkAIMqhxWT7z053chi+MjcbsB296Ks7j2Z/ZD48GXdURl44teS+ xDZzoXqTJqjpT3cJYJUQOjbPvn+hr+P3HVYVdAU14L+Dwi21fZwRwzT8G/m7NlxlyoyR y4BR1rzAy11yyHQp+cvqRgG507IFA0wA4wJpbW5PqwyjVzv40cbvbtOQY+4vHvQIsOzn 8SBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k16kUmG8L1NRQ9ItF/APOhTL6rXhmyq4oUmEcfOB2fE=; b=qoZg1p6j924pVvGpBKNxF9aJexA1sCge4BMgxGehKO809JYhr+5lirQgv4IWApbXzZ yfhoHSWPwZbL3Sswrr/aJ5/i2sZMvc5p8njAadXm1/63p6RAzexXwPATb+fZAb/lK4EZ ZusMOpEgofRfXK6KwWtvnfl6taIi/No1dlEJEPuqLZ7eOwU8ioBFYizcu0PPAAa7fG/O ig6zO0tSClA9VWsybsZ7yuA+lOiAEHmMNuoXERSlsMK8oOQquKZS0pjt7z314GKmkfkO 8x5yXkv1azMpp8ofuGGXBPCPyxfgLTtTiX8D1A+WHMdTpPTwgmbxb4IFhp6gvh6UT/lK foCQ== X-Gm-Message-State: AOAM531e/iruKHKwBpAjMz0n5o+didPuXv2yrNhM+f6jtcxE3Ocu5rFv 92TGw0kvIrRWgQPehGq8ZzehjmLCUfDsHISF0sNvx0kf298qRQ== X-Google-Smtp-Source: ABdhPJzSuZkEtxYofRNp8DNrdSc8PAqqbkNbkw0IWEIGNLnWWlULgXU1obJjhZFr7LtrNdJZ8DgkPTKW7MT5nXhLSeo= X-Received: by 2002:a9d:4c19:: with SMTP id l25mr17717189otf.193.1591640675185; Mon, 08 Jun 2020 11:24:35 -0700 (PDT) In-Reply-To: <5CB87F9A-431C-4BC6-99CD-753844A26BCC@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::335; envelope-from=nicolasbertolo@gmail.com; helo=mail-ot1-x335.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181743 Archived-At: > Thanks, but are you sure the fix should be in load_charset_map_from_file and > not in the new code added to openp in the offending commit? Why does the > additional code in openp need to cons its list off the heap? Good idea. It should be easy to rework the openp to avoid putting the suffixes in a heap based list. What openp() does now is turn a list of suffixes into a list of suffixes and associated directories that need to be added to the file path. For example, it turns this: (".eln" ".elc" ".elc.gz" ".el" ".el.gz") into this: ((nil . ".eln") (comp-native-path-postfix . ".eln") (nil . ".elc") (nil . ".elc.gz") (nil . ".el") (nil . ".el.gz")) I did it this way because then iterating over it can be done using a FOR_EACH_TAIL macro. I'll change this to use two lists, one for the suffixes and another one for the directories. The code for iterating them will be just a little more complicated, but it should be safe to pass stack-based suffixes.