unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#23684: delete-trailing-whitespace bug
@ 2016-06-02 21:57 Constantin Kulikov
  2016-06-03  6:36 ` Constantin Kulikov
  0 siblings, 1 reply; 6+ messages in thread
From: Constantin Kulikov @ 2016-06-02 21:57 UTC (permalink / raw)
  To: 23684


[-- Attachment #1.1: Type: text/plain, Size: 194 bytes --]

emacs --version
GNU Emacs 25.0.50.1

emacs -Q
C-x C-f testcase.js (from attachment)
M-x delete-trailing-whitespace RET

See how it behave badly.
Send report to bug-gbu-emacs.
Is it only for me?

[-- Attachment #1.2: Type: text/html, Size: 619 bytes --]

[-- Attachment #2: testcase.tar.gz --]
[-- Type: application/x-gzip, Size: 185 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23684: delete-trailing-whitespace bug
  2016-06-02 21:57 bug#23684: delete-trailing-whitespace bug Constantin Kulikov
@ 2016-06-03  6:36 ` Constantin Kulikov
  2016-06-03 11:33   ` Noam Postavsky
  0 siblings, 1 reply; 6+ messages in thread
From: Constantin Kulikov @ 2016-06-03  6:36 UTC (permalink / raw)
  To: 23684

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hmm, looks like it is javascript-mode specific...
Here is a simple workaround:

    (defun cleanup-trailing-whitespaces ()
      (interactive)
      (let ((m-m major-mode))
        (fundamental-mode)
        (delete-trailing-whitespace)
        (funcall m-m)))

But it seems to me that I also had a wrong behaviour of the
delete-trailing-whitespace for other major-modes. Can not prove it though).

[-- Attachment #2: Type: text/html, Size: 601 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23684: delete-trailing-whitespace bug
  2016-06-03  6:36 ` Constantin Kulikov
@ 2016-06-03 11:33   ` Noam Postavsky
  2016-06-04 10:03     ` Constantin Kulikov
  0 siblings, 1 reply; 6+ messages in thread
From: Noam Postavsky @ 2016-06-03 11:33 UTC (permalink / raw)
  To: Constantin Kulikov; +Cc: 23684

I don't see any "bad" behaviour with 25.0.94 or 24.5, though you
didn't explain what "bad" means. As far I can see, all trailing
whitespace gets deleted as expected.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23684: delete-trailing-whitespace bug
  2016-06-03 11:33   ` Noam Postavsky
@ 2016-06-04 10:03     ` Constantin Kulikov
  2016-06-05  7:48       ` Constantin Kulikov
  0 siblings, 1 reply; 6+ messages in thread
From: Constantin Kulikov @ 2016-06-04 10:03 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: 23684


[-- Attachment #1.1: Type: text/plain, Size: 359 bytes --]

> I don't see any "bad" behaviour with 25.0.94 or 24.5

This is good.)

> though you didn't explain what "bad" means. As far I can see, all trailing
whitespace gets deleted as expected.

For me it deletes not only trailing whitespace, but also a region from a
trailing whitespace to the '/' character(See attachment).
May be it's time for me to update emacs.

[-- Attachment #1.2: Type: text/html, Size: 1132 bytes --]

[-- Attachment #2: testcase.tar.gz --]
[-- Type: application/x-gzip, Size: 439 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23684: delete-trailing-whitespace bug
  2016-06-04 10:03     ` Constantin Kulikov
@ 2016-06-05  7:48       ` Constantin Kulikov
  2016-06-05 14:50         ` Noam Postavsky
  0 siblings, 1 reply; 6+ messages in thread
From: Constantin Kulikov @ 2016-06-05  7:48 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: 23684

[-- Attachment #1: Type: text/plain, Size: 93 bytes --]

Just updated.

emacs --version
GNU Emacs 25.1.50.1

Looks like the problem is fixed. Thanks.

[-- Attachment #2: Type: text/html, Size: 212 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23684: delete-trailing-whitespace bug
  2016-06-05  7:48       ` Constantin Kulikov
@ 2016-06-05 14:50         ` Noam Postavsky
  0 siblings, 0 replies; 6+ messages in thread
From: Noam Postavsky @ 2016-06-05 14:50 UTC (permalink / raw)
  To: Constantin Kulikov; +Cc: 23684-done

fixed 23684 25.0.94
quit

On Sun, Jun 5, 2016 at 3:48 AM, Constantin Kulikov <zxnotdead@gmail.com> wrote:
> emacs --version
> GNU Emacs 25.1.50.1
>
> Looks like the problem is fixed. Thanks.

Closing, thanks for confirming.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-06-05 14:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-02 21:57 bug#23684: delete-trailing-whitespace bug Constantin Kulikov
2016-06-03  6:36 ` Constantin Kulikov
2016-06-03 11:33   ` Noam Postavsky
2016-06-04 10:03     ` Constantin Kulikov
2016-06-05  7:48       ` Constantin Kulikov
2016-06-05 14:50         ` Noam Postavsky

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).