From: Zachary Kanfer <zkanfer@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 64185@debbugs.gnu.org
Subject: bug#64185: proposal for new function: copy-line
Date: Mon, 26 Jun 2023 15:18:19 -0400 [thread overview]
Message-ID: <CAFXT+RPEB4evrQFYQoXLtPC1XFBphkBJSaB7C2jxioF9mJVmdQ@mail.gmail.com> (raw)
In-Reply-To: <86h6qut970.fsf@mail.linkov.net>
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
> > The code becomes slightly more verbose this way, but is far easier to
read
> > and comprehend. It seems an extremely worthwhile tradeoff to me.
>
> Not sure how often users will read the code of duplicate-line.
Developers will. And it's easier to read with symbols.
On Mon, Jun 26, 2023 at 1:41 PM Juri Linkov <juri@linkov.net> wrote:
> >> This might surprise you, but code would be more complicated with
> symbols.
> >> Instead of
> >>
> >> (unless (eq duplicate-line-final-position 0)
> >> (forward-line duplicate-line-final-position)
> >>
> >> it will be
> >>
> >> (unless (eq duplicate-line-final-position 'old-original-line)
> >> (when (eq duplicate-line-final-position
> 'first-copied-duplicate-line)
> >> (forward-line 1))
> >> (when (eq duplicate-line-final-position 'last-copied-duplicate-line)
> >> (forward-line -1))
> >
> > The code doesn't need the (unless (eq duplicate-line-final-position
> > 'old-original-line) ... check. It can be only the two when cases. But
> > that's a secondary matter.
>
> I agree.
>
> > The code becomes slightly more verbose this way, but is far easier to
> read
> > and comprehend. It seems an extremely worthwhile tradeoff to me.
>
> Not sure how often users will read the code of duplicate-line.
>
[-- Attachment #2: Type: text/html, Size: 1873 bytes --]
next prev parent reply other threads:[~2023-06-26 19:18 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 5:07 bug#64185: proposal for new function: copy-line Zachary Kanfer
2023-06-20 6:15 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-20 11:44 ` Eli Zaretskii
2023-06-22 3:33 ` Zachary Kanfer
2023-06-22 5:08 ` Eli Zaretskii
2023-06-22 6:57 ` Juri Linkov
2023-06-22 16:25 ` Eli Zaretskii
2023-06-22 17:27 ` Juri Linkov
2023-06-22 17:45 ` Eli Zaretskii
2023-06-22 18:13 ` Drew Adams
2023-06-22 18:29 ` Juri Linkov
2023-06-22 18:42 ` Drew Adams
2023-06-22 18:52 ` Juri Linkov
2023-06-22 19:05 ` Drew Adams
2023-06-22 18:17 ` Juri Linkov
2023-06-22 18:30 ` Eli Zaretskii
2023-06-23 5:46 ` Zachary Kanfer
2023-06-23 5:56 ` Eli Zaretskii
2023-06-23 7:08 ` Robert Pluim
2023-06-23 7:19 ` Eli Zaretskii
2023-06-23 9:01 ` Robert Pluim
2023-06-23 16:46 ` Juri Linkov
2023-06-23 9:07 ` Mattias Engdegård
2023-06-23 10:28 ` Eli Zaretskii
2023-06-23 10:50 ` Mattias Engdegård
2023-06-23 11:07 ` Eli Zaretskii
2023-06-23 16:45 ` Juri Linkov
2023-06-24 11:29 ` Mattias Engdegård
2023-06-25 17:24 ` Juri Linkov
2023-06-25 19:46 ` Mattias Engdegård
2023-06-26 17:37 ` Juri Linkov
2023-06-26 17:56 ` Drew Adams
2023-06-26 18:35 ` Eli Zaretskii
2023-06-27 15:35 ` Mattias Engdegård
2023-06-27 18:28 ` Juri Linkov
2023-06-28 13:17 ` Mattias Engdegård
2023-06-28 17:42 ` Juri Linkov
2023-06-28 18:37 ` Eli Zaretskii
2023-06-29 7:13 ` Juri Linkov
2023-06-30 17:13 ` Mattias Engdegård
2023-06-30 19:03 ` Eli Zaretskii
2023-07-01 8:45 ` Mattias Engdegård
2023-07-01 9:53 ` Eli Zaretskii
2023-07-01 10:07 ` Mattias Engdegård
2023-07-01 10:22 ` Eli Zaretskii
2023-07-01 10:33 ` Mattias Engdegård
2023-06-25 3:45 ` Zachary Kanfer
2023-06-25 17:19 ` Juri Linkov
[not found] ` <CAFXT+RPRwpZgfPKsyz22+-v6vy7RJwyuwaOEkmunc2MAMSoqZA@mail.gmail.com>
[not found] ` <86h6qut970.fsf@mail.linkov.net>
2023-06-26 19:18 ` Zachary Kanfer [this message]
2023-06-27 2:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFXT+RPEB4evrQFYQoXLtPC1XFBphkBJSaB7C2jxioF9mJVmdQ@mail.gmail.com \
--to=zkanfer@gmail.com \
--cc=64185@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).