From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.bugs Subject: bug#16377: Undo Tree regression: (error "Unrecognized entry in undo list undo-tree-canary") Date: Mon, 6 Jan 2014 19:32:45 -0500 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e013a1774dfe60104ef56830d X-Trace: ger.gmane.org 1389054784 20815 80.91.229.3 (7 Jan 2014 00:33:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Jan 2014 00:33:04 +0000 (UTC) To: toby-undo-tree@dr-qubit.org, 16377@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 07 01:33:10 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0KbV-0005i4-CX for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2014 01:33:09 +0100 Original-Received: from localhost ([::1]:38236 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0KbU-0003w9-SS for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jan 2014 19:33:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0KbQ-0003tT-8p for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 19:33:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0KbO-0001fh-Rt for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 19:33:04 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0KbO-0001fd-ON for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 19:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W0KbO-0002re-DW for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 19:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Barry OReilly Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2014 00:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16377 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: toby-undo-tree@dr-qubit.org, bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138905477210986 (code B ref -1); Tue, 07 Jan 2014 00:33:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Jan 2014 00:32:52 +0000 Original-Received: from localhost ([127.0.0.1]:39631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0KbD-0002r8-Jc for submit@debbugs.gnu.org; Mon, 06 Jan 2014 19:32:52 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53468) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0KbC-0002r1-AR for submit@debbugs.gnu.org; Mon, 06 Jan 2014 19:32:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0KbB-0001da-1V for submit@debbugs.gnu.org; Mon, 06 Jan 2014 19:32:50 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:43054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0KbA-0001dW-V0 for submit@debbugs.gnu.org; Mon, 06 Jan 2014 19:32:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Kb9-0003aI-Rh for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 19:32:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Kb8-0001d8-Qr for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 19:32:47 -0500 Original-Received: from mail-ob0-x22e.google.com ([2607:f8b0:4003:c01::22e]:45662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Kb8-0001d2-KE for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 19:32:46 -0500 Original-Received: by mail-ob0-f174.google.com with SMTP id wn1so19086371obc.19 for ; Mon, 06 Jan 2014 16:32:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=4rvCkEF7Qh3amONC0K9SW1PqhHGf80FVKd5TTVrZwk0=; b=Nh+nQuIOknkApJSyYZxr2iWh8iMdjQb6h5ChNPP39NYr48mURkMeMsgS7AY5vH8I4e 0DqSPNMNg51kWZY0CjlTqBQXlaoNBV6xezlUJogh1kkLW5fRkQJvjshonpSeUaXV07hI I3sXZwQvO5wIOl9n3CQsGWmYb6IU2AucKCIEsgeP2H/C+bYe2tuxv1MC9r5vE8XG8H7f Pox0bXlJIuj+Bp2YdptvHU7L086QAx9CWKUivrW+f9ySx67tvBIVsedYJhy/EXCDtmxU KHesRA/prsomRjhIyroL5810XfwYlUpMV1+kgDudcQ2hLhfV9u2zXK1/yQKiHvISX2Q2 poWg== X-Received: by 10.60.97.71 with SMTP id dy7mr157595oeb.73.1389054765555; Mon, 06 Jan 2014 16:32:45 -0800 (PST) Original-Received: by 10.76.156.103 with HTTP; Mon, 6 Jan 2014 16:32:45 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83077 Archived-At: --089e013a1774dfe60104ef56830d Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Don't know yet if the code change belongs in Undo Tree or Emacs but the recipe is: =95 Start Emacs in scratch buffer with global-undo-tree-mode enabled =95 Go to BOB and insert "xxx" =95 Select first line =95 undo-tree-undo in region =95 undo-tree-redo in region =95 undo-tree-visualize =95 Navigate down (redo)* =95 Navigate up (undo) Upon the navigate up, this error occurs: Debugger entered--Lisp error: (error "Unrecognized entry in undo list undo-tree-canary") signal(error ("Unrecognized entry in undo list undo-tree-canary")) error("Unrecognized entry in undo list %S" undo-tree-canary) primitive-undo(1 (undo-tree-canary)) undo-tree-undo-1(1) undo-tree-visualize-undo(1) call-interactively(undo-tree-visualize-undo nil nil) command-execute(undo-tree-visualize-undo) * Sometimes the navigate down hangs with backtrace: Debugger entered--Lisp error: (quit) undo-tree-copy-list((nil)) undo-tree-redo-1(1) undo-tree-visualize-redo(1) call-interactively(undo-tree-visualize-redo nil nil) command-execute(undo-tree-visualize-redo) Don't know if it's related or not. This recipe does not cause a problem with Emacs 24.3. The following commit is suspicious: commit 0c180ea96c022923ef18a255d0492bdb5ad04e02 Author: Aaron S. Hawley Date: Tue Jan 8 14:13:31 2013 -0500 * lisp/simple.el (primitive-undo): Move from undo.c. * src/undo.c (Fprimitive_undo): Move to simple.el. (syms_of_undo): Remove declaration for Sprimitive_undo. * test/automated/undo-tests.el: New file. The commit moved primitive-undo from C to Elisp. In the process, it added an else condition not present in the C code: + (t (error "Unrecognized entry in undo list %S" next))))) The consequence of this bug is that when using Undo Tree, recent undo history can become completely inaccessible. I should note that if I don't undo in region, Undo Tree has never run into any problems with the Emacs on trunk. --089e013a1774dfe60104ef56830d Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable
Don't know yet if the code change belongs in Undo Tree= or Emacs but
the recipe is:

=A0 =95 Start Emacs in scratch buffe= r with global-undo-tree-mode enabled
=A0 =95 Go to BOB and insert "= xxx"
=A0 =95 Select first line
=A0 =95 undo-tree-undo in region
=A0 =95 un= do-tree-redo in region
=A0 =95 undo-tree-visualize
=A0 =95 Navigate d= own (redo)*
=A0 =95 Navigate up (undo)

Upon the navigate up, this= error occurs:

=A0 Debugger entered--Lisp error: (error "Unrecognized entry in undo l= ist undo-tree-canary")
=A0=A0=A0=A0 signal(error ("Unrecognize= d entry in undo list undo-tree-canary"))
=A0=A0=A0=A0 error("U= nrecognized entry in undo list %S" undo-tree-canary)
=A0=A0=A0=A0 primitive-undo(1 (undo-tree-canary))
=A0=A0=A0=A0 undo-tree= -undo-1(1)
=A0=A0=A0=A0 undo-tree-visualize-undo(1)
=A0=A0=A0=A0 call= -interactively(undo-tree-visualize-undo nil nil)
=A0=A0=A0=A0 command-ex= ecute(undo-tree-visualize-undo)

* Sometimes the navigate down hangs with backtrace:

=A0 Debugger ent= ered--Lisp error: (quit)
=A0=A0=A0=A0 undo-tree-copy-list((nil))
=A0= =A0=A0=A0 undo-tree-redo-1(1)
=A0=A0=A0=A0 undo-tree-visualize-redo(1)=A0=A0=A0=A0 call-interactively(undo-tree-visualize-redo nil nil)
=A0=A0=A0=A0 command-execute(undo-tree-visualize-redo)

Don't kno= w if it's related or not.

This recipe does not cause a problem w= ith Emacs 24.3.

The following commit is suspicious:

commit 0c= 180ea96c022923ef18a255d0492bdb5ad04e02
Author: Aaron S. Hawley <aar= on.s.hawley@gmail.com>
Date:=A0=A0 Tue Jan 8 14:13:31 2013 -0500<= br>
=A0=A0=A0 * lisp/simple.el (primitive-undo): Move from undo.c.
= =A0=A0=A0 * src/undo.c (Fprimitive_undo): Move to simple.el.
=A0=A0=A0 (syms_of_undo): Remove declaration for Sprimitive_undo.
=A0=A0= =A0 * test/automated/undo-tests.el: New file.

The commit moved primi= tive-undo from C to Elisp. In the process, it
added an else condition no= t present in the C code:

+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (t (error "Unrecognized entr= y in undo list %S" next)))))

The consequence of this bug is tha= t when using Undo Tree, recent undo
history can become completely inacce= ssible.

I should note that if I don't undo in region, Undo Tree = has never run
into any problems with the Emacs on trunk.

--089e013a1774dfe60104ef56830d--