From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.bugs Subject: bug#16818: Acknowledgement (Undo in region after markers in undo history relocated) Date: Thu, 13 Mar 2014 12:55:57 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f46d04479f93c0deef04f47fd398 X-Trace: ger.gmane.org 1394729833 1466 80.91.229.3 (13 Mar 2014 16:57:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Mar 2014 16:57:13 +0000 (UTC) Cc: 16818@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 13 17:57:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WO8wX-0000Qv-Ju for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Mar 2014 17:57:17 +0100 Original-Received: from localhost ([::1]:40655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO8wX-0007Zf-Ad for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Mar 2014 12:57:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO8wO-0007WZ-Q0 for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 12:57:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WO8wI-0006gO-Qy for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 12:57:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO8wI-0006gK-N1 for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 12:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WO8wI-0003JW-9M for bug-gnu-emacs@gnu.org; Thu, 13 Mar 2014 12:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Barry OReilly Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Mar 2014 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16818 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16818-submit@debbugs.gnu.org id=B16818.139472976312635 (code B ref 16818); Thu, 13 Mar 2014 16:57:02 +0000 Original-Received: (at 16818) by debbugs.gnu.org; 13 Mar 2014 16:56:03 +0000 Original-Received: from localhost ([127.0.0.1]:36087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WO8vJ-0003HX-S9 for submit@debbugs.gnu.org; Thu, 13 Mar 2014 12:56:02 -0400 Original-Received: from mail-ob0-f177.google.com ([209.85.214.177]:36615) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WO8vG-0003HE-9v for 16818@debbugs.gnu.org; Thu, 13 Mar 2014 12:55:59 -0400 Original-Received: by mail-ob0-f177.google.com with SMTP id wo20so1286316obc.36 for <16818@debbugs.gnu.org>; Thu, 13 Mar 2014 09:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=yds9K/LX6WzPLb99bwQnyCPpiYoO59cogdX3I16Afk8=; b=SU6ViASh6+AbPWE5xsDGqmzc4B55sdaW3vH6kqU87hl0W1olNKxfe5bl1NfX3j6wy3 BaokSXXwJhEoJAt4+7dd7tEG3yjR7fPiORkAMP6p0m4Cmf+fQ9wisSuZdg8PYuWOUUv1 VA8lxzIYU6hgFX7lI06ZTiIdPbkM9HX+dcoHIATIu1DX3ZB14GaSNtqnpndFpDQss351 fxiJhMdTBuI1r2fAMmYwBzFXcMin27p6q3S0NrgEmJ1jwsGKyxId/qA3FU3ODE1hnEmT HjQHbzFw9VVmvJaF57YI+SFA9+5EWtUlsvNxZ/fhEdbpWseSPJRHauGYybRVZd3pYIGy crvg== X-Received: by 10.182.16.33 with SMTP id c1mr2448553obd.4.1394729757496; Thu, 13 Mar 2014 09:55:57 -0700 (PDT) Original-Received: by 10.76.6.44 with HTTP; Thu, 13 Mar 2014 09:55:57 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86831 Archived-At: --f46d04479f93c0deef04f47fd398 Content-Type: text/plain; charset=ISO-8859-1 > Oh, I think I see: with the current code, the mark-ring gets copies of > markers and those copies are made "late", so if you do "C-SPC, some > deletion around point, and then C-SPC", a new marker for the first C-SPC > is pushed on the mark-ring, but the undo-log has an adjustment for > mark-marker rather than for that new marker. > IOW, I think the primitive-undo fix is needed and your fix is also > needed. Yes that's right. Parents cover their childrens' eyes at the violence of our agreement. I just discovered my patch has a bug. If I C-SPC first thing after starting Emacs, an error is signaled because the mark is nil. I had hoped the mark variable initialized equivalently except to make itself available to Lisp. There are clearly holes in my understanding of the initialization business. I'll debug that at a later time. --f46d04479f93c0deef04f47fd398 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
> Oh, I think I see: with the current code, the mark-ri= ng gets copies of
> markers and those copies are made "late"= ;, so if you do "C-SPC, some
> deletion around point, and then C= -SPC", a new marker for the first C-SPC
> is pushed on the mark-ring, but the undo-log has an adjustment for
= > mark-marker rather than for that new marker.

> IOW, I think = the primitive-undo fix is needed and your fix is also
> needed.

Yes that's right. Parents cover their childrens' eyes at the vi= olence
of our agreement.

I just discovered my patch has a bug. If= I C-SPC first thing after
starting Emacs, an error is signaled because = the mark is nil. I had
hoped the mark variable initialized equivalently except to make itself
a= vailable to Lisp. There are clearly holes in my understanding of the
ini= tialization business. I'll debug that at a later time.

--f46d04479f93c0deef04f47fd398--