unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Barry OReilly <gundaetiapo@gmail.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 17887@debbugs.gnu.org
Subject: bug#17887: Regression: mouse-1 click on link does mouse-2 instead
Date: Mon, 30 Jun 2014 16:27:06 -0700	[thread overview]
Message-ID: <CAFM41H0+yaB3pJLnLM3ihToqX6PtnwV4hxBwY7VX-Cs3OnDSUA@mail.gmail.com> (raw)
In-Reply-To: <871tu6do2v.fsf@web.de>

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

> Would it solve your problem when your mode (locally) binds
> `mouse-1-click-follows-link` to nil?

No, in this case mouse-1 does nothing but relocate point.

I Git bisected the regression to:

25573f61f9eaf1631c03d16486ffc17fd9b18503 is the first bad commit
commit 25573f61f9eaf1631c03d16486ffc17fd9b18503
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Mar 8 23:15:53 2013 -0500

    Separate mouse-1-click-follows-link from mouse-drag-region.
    * lisp/mouse.el (mouse--down-1-maybe-follows-link): New function.
    (key-translation-map): Use it to implement mouse-1-click-follows-link.
    (mouse-drag-line, mouse-drag-track): Remove mouse-1-click-follows-link
code.
    (mouse--remap-link-click-p): Remove.
    * src/keyboard.c (access_keymap_keyremap): Accept nil return value from
    functions to mean "no change".
    * src/keyboard.h (EVENT_START, EVENT_END, POSN_WINDOW, POSN_POSN)
    (POSN_WINDOW_POSN, POSN_TIMESTAMP): Be careful since events may come
    from Elisp via unread-command-events.

[-- Attachment #2: Type: text/html, Size: 1225 bytes --]

  reply	other threads:[~2014-06-30 23:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 22:13 bug#17887: Regression: mouse-1 click on link does mouse-2 instead Barry OReilly
2014-06-30 22:34 ` Michael Heerdegen
2014-06-30 23:27   ` Barry OReilly [this message]
2014-06-30 23:42     ` Michael Heerdegen
2014-06-30 23:54       ` Barry OReilly
2014-07-01  1:24 ` Stefan Monnier
2014-08-21  1:45   ` Barry OReilly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFM41H0+yaB3pJLnLM3ihToqX6PtnwV4hxBwY7VX-Cs3OnDSUA@mail.gmail.com \
    --to=gundaetiapo@gmail.com \
    --cc=17887@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).