From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Hendricks Newsgroups: gmane.emacs.bugs Subject: bug#31139: [PATCH] Document Narrow indicator in describe-mode Date: Thu, 19 Apr 2018 14:38:08 +0000 Message-ID: References: <20180412171208.79685-1-michael@ndrix.org> <87po2vs85p.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000cdf106056a3485cb" X-Trace: blaine.gmane.org 1524148640 2395 195.159.176.226 (19 Apr 2018 14:37:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 19 Apr 2018 14:37:20 +0000 (UTC) Cc: "copyright-clerk@fsf.org" , 31139@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 19 16:37:16 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9AgU-0000Vt-8C for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Apr 2018 16:37:14 +0200 Original-Received: from localhost ([::1]:51787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9Aia-0000kw-U1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Apr 2018 10:39:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9AiK-0000j1-G3 for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2018 10:39:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9AiE-0007LT-7q for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2018 10:39:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f9AiE-0007KT-4f for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2018 10:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f9AiD-00006W-Su for bug-gnu-emacs@gnu.org; Thu, 19 Apr 2018 10:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Hendricks Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Apr 2018 14:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31139 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31139-submit@debbugs.gnu.org id=B31139.1524148706346 (code B ref 31139); Thu, 19 Apr 2018 14:39:01 +0000 Original-Received: (at 31139) by debbugs.gnu.org; 19 Apr 2018 14:38:26 +0000 Original-Received: from localhost ([127.0.0.1]:33026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9Ahe-00005W-4T for submit@debbugs.gnu.org; Thu, 19 Apr 2018 10:38:26 -0400 Original-Received: from mail8.static.mailgun.info ([104.130.122.8]:33799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9Ahd-00005K-51 for 31139@debbugs.gnu.org; Thu, 19 Apr 2018 10:38:25 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=ndrix.org; q=dns/txt; s=k1; t=1524148699; h=Content-Type: Cc: To: Subject: Message-ID: Date: From: In-Reply-To: References: MIME-Version: Sender; bh=hFsOC7EDYf+GyFSq/wUWd3dxaur8zT2eNO0X0ecrHFE=; b=kYI1cpOEZ2/EhZZUHv+MbfVwTfBq+AhuhVdxlFK9E56e8kK/uEvBODYmNHmgId7XhyFsbjHH DHHxBy7ez7H+PN03xNiM8HpNyk9VgeUGNmTMOhsxviuhRF6hUzTI0N/W/bGIMRPIt+hrP8kJ yH44GbNdP8AnLZVQ1JK239Ylfl4= X-Mailgun-Sid: WyI0YjdmYSIsICIzMTEzOUBkZWJidWdzLmdudS5vcmciLCAiM2UwODY2Il0= X-Mailgun-Sending-Ip: 104.130.122.8 Original-Received: from mail-ot0-f179.google.com (mail-ot0-f179.google.com [74.125.82.179]) by mxa.mailgun.org with ESMTP id 5ad8a9db.7fb1deab7bf0-smtp-out-n03; Thu, 19 Apr 2018 14:38:19 -0000 (UTC) Original-Received: by mail-ot0-f179.google.com with SMTP id i5-v6so6089517oth.1 for <31139@debbugs.gnu.org>; Thu, 19 Apr 2018 07:38:19 -0700 (PDT) X-Gm-Message-State: ALQs6tCDwPJio0IiA+arYVVL7OIsbQxP+SU4Mn9RcOEQrVEWYwVd7OmE kk/OsVXssURB6/b7F+TVxsc0qqSeCTjq1Mc+3pI= X-Google-Smtp-Source: AIpwx49lmZMOY2xCAlBkaV1BFLcJ8z2/YDcszi4JVY+ctR8Sw9RJPiYg6GA1krZue3HZcmSoFYdkau+RhDaA2Uw82bI= X-Received: by 2002:a9d:4086:: with SMTP id n6-v6mr1829271ote.335.1524148699261; Thu, 19 Apr 2018 07:38:19 -0700 (PDT) In-Reply-To: <87po2vs85p.fsf@gmail.com> X-Gmail-Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145607 Archived-At: --000000000000cdf106056a3485cb Content-Type: text/plain; charset="UTF-8" On Thu, Apr 19, 2018 at 6:16 AM Noam Postavsky wrote: > Okay, I'm convinced. I think adding a comment along the lines of > "narrowing is not a minor mode, but its indicator is part of > mode-line-modes", would be helpful in case someone tries to "fix" your > change later. > > > + (when (or (> (point-min) 1) (<= (point-max) (buffer-size))) > > You should use buffer-narrowed-p instead of checking point min & max > here. > Sounds good. I'll run Emacs with these changes over the weekend. If everything is solid, I'll reply with a final patch early next week. Have you assigned copyright for Emacs? I submitted my copyright assignment on April 11, 2018, but it sounds like I'm not on the current copyright assignment list for some reason. I've cc'd the FSF copyright clerk with whom I handled the assignment, in case he knows what happened. For reference, my RT number for the assignment was 1287241. --000000000000cdf106056a3485cb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Apr 19= , 2018 at 6:16 AM Noam Postavsky <npostavs@gmail.com> wrote:
Okay, I'm convinced.=C2=A0 I think adding a comment al= ong the lines of
"narrowing is not a minor mode, but its indicator is part of
mode-line-modes", would be helpful in case someone tries to "fix&= quot; your
change later.

> +=C2=A0 =C2=A0 =C2=A0(when (or (> (point-min) 1) (<=3D (point-ma= x) (buffer-size)))

You should use buffer-narrowed-p instead of checking point min & max here.

Sounds good.=C2=A0 I'll run Emacs with these changes o= ver the weekend.=C2=A0 If everything is solid, I'll reply with a final = patch early next week.

Have you assigned copyright for Emacs?

I submitted my copyrigh= t assignment on April 11, 2018, but it sounds like I'm not on the curre= nt copyright assignment list for some reason. I've cc'd the FSF cop= yright clerk with whom I handled the assignment, in case he knows what happ= ened.=C2=A0 For reference, my RT number for the assignment was=C2=A01287241= .

--000000000000cdf106056a3485cb--