On Thu, Apr 19, 2018 at 6:16 AM Noam Postavsky <npostavs@gmail.com> wrote:

> Okay, I'm convinced.  I think adding a comment along the lines of
> "narrowing is not a minor mode, but its indicator is part of
> mode-line-modes", would be helpful in case someone tries to "fix" your
> change later.
>
> > +     (when (or (> (point-min) 1) (<= (point-max) (buffer-size)))
>
> You should use buffer-narrowed-p instead of checking point min & max
> here.
>

Sounds good.  I'll run Emacs with these changes over the weekend.  If
everything is solid, I'll reply with a final patch early next week.

Have you assigned copyright for Emacs?


I submitted my copyright assignment on April 11, 2018, but it sounds like
I'm not on the current copyright assignment list for some reason. I've cc'd
the FSF copyright clerk with whom I handled the assignment, in case he
knows what happened.  For reference, my RT number for the assignment
was 1287241.