From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Behdad Esfahbod Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Sat, 22 Dec 2018 10:27:06 -0500 Message-ID: References: <20181214075056.GI2244@macbook.localdomain> <8336r0h1cb.fsf@gnu.org> <20181214110316.GK2244@macbook.localdomain> <83y38sfcme.fsf@gnu.org> <83tvjgf7ux.fsf@gnu.org> <83mup4du5z.fsf@gnu.org> <20181222085448.GA2244@macbook.localdomain> <20181222090644.GB2244@macbook.localdomain> <83va3lan24.fsf@gnu.org> <20181222151509.GC2244@macbook.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d3d646057d9dffc4" X-Trace: blaine.gmane.org 1545492369 20089 195.159.176.226 (22 Dec 2018 15:26:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2018 15:26:09 +0000 (UTC) Cc: 33729@debbugs.gnu.org, Mohammad Nasirifar , Kaushal Modi To: Khaled Hosny Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 22 16:26:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gajA9-000504-VE for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 16:26:02 +0100 Original-Received: from localhost ([::1]:48874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gajCG-0005FC-4E for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 10:28:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gajC9-0005B2-Dj for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 10:28:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gajC6-0007Og-4g for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 10:28:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55879) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gajC6-0007Nk-1U for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 10:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gajC5-0008Ic-Md for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 10:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Behdad Esfahbod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2018 15:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.154549244831852 (code B ref 33729); Sat, 22 Dec 2018 15:28:01 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 22 Dec 2018 15:27:28 +0000 Original-Received: from localhost ([127.0.0.1]:60137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gajBX-0008Hg-UC for submit@debbugs.gnu.org; Sat, 22 Dec 2018 10:27:28 -0500 Original-Received: from mail-lf1-f54.google.com ([209.85.167.54]:41951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gajBW-0008HN-Ie for 33729@debbugs.gnu.org; Sat, 22 Dec 2018 10:27:27 -0500 Original-Received: by mail-lf1-f54.google.com with SMTP id c16so5887986lfj.8 for <33729@debbugs.gnu.org>; Sat, 22 Dec 2018 07:27:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gvhgE1f2i0MXn9vr1uuf2mM1ML0wOw3R/mhcd4CaT/I=; b=j0Hw+t1l4MJ2yGGcBy5phKB7UEAS+4eh29x0xZJS/8idDrXpeGN3mGY6dY7CQk48Jp 8vz+Z3wjrjMH6Vwxw52UaEK4oqaCzukWB8sMEzltviZhPvAap2bemWJ7wvv3+PcP3XHN ggF35v2dt0rUzZXgFrFX78K/Xor03x6RAwo8+zmEq/E6T9rXKiF+Z14IHVVF83u2f5VO /govw4+Mr5AKZclqfUe8Qw9xbZVFxinAQHUST/h2iO6iRkiSMlJvJok1WZkQXakxZFEa qGnDel4fK7rmYEuWIguZZAHu4AjtlL2AQQ/N36ddl6jBKlAmh/2082j585VQjO23XR+q oerg== X-Gm-Message-State: AA+aEWYGd5cHIC0Vb5Cgqz2xF8wBpQNW5oKPKgPCCyfckTchptFsebqS dHKQX4kT3xcaC63nQB/lEWye1CBRi0FP2kLRiiw= X-Google-Smtp-Source: AFSGD/XzRZsTFCF6zIIpYsSysfcPgBHBH5iL/rprmIND9DMYTnQYRmziRxUoitr4bHoN6lGxnzWd1r6WESjhGJAFAAQ= X-Received: by 2002:a19:9fcd:: with SMTP id i196mr3661715lfe.82.1545492438962; Sat, 22 Dec 2018 07:27:18 -0800 (PST) In-Reply-To: <20181222151509.GC2244@macbook.localdomain> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153739 Archived-At: --000000000000d3d646057d9dffc4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I suggest you enabled UCDN. On Sat, Dec 22, 2018 at 10:15 AM Khaled Hosny wrote: > On Sat, Dec 22, 2018 at 12:11:15PM +0200, Eli Zaretskii wrote: > > > Date: Sat, 22 Dec 2018 11:06:44 +0200 > > > From: Khaled Hosny > > > Cc: Glenn Morris , far.nasiri.m@gmail.com, > behdad@behdad.org, > > > 33729@debbugs.gnu.org, kaushal.modi@gmail.com > > > > > > > Alternatively, we could just use HarfBuzz=E2=80=99s own built in uc= dn-based > > > > Unicode function for this. The only reason for overriding this in > Emacs > > > > was to keep HarfBuzz and Emacs Unicode support in sync, but if we a= re > > > > going to duplicate the Unicode script data then better use what > HarfBuzz > > > > has. > > > > > > > > I=E2=80=99m going to try this now. > > > > > > I pushed a commit to harfbuzz branch that I think fixes this issue no= w. > > > > Thanks. > > > > There's a FIXME in the change you pushed (which I believe just > > repeats what was already in the previous version). Ca you tell more > > about the problem we need to fix there? > > We need a way to get Unicode composition and decomposition for the > a given character (implementing the uni_compose and uni_decompose > functions I deleted). I recall you suggested something earlier that I > tried but couldn=E2=80=99t get to work, the exact detail escapes me. > --=20 behdad http://behdad.org/ --000000000000d3d646057d9dffc4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I suggest you enabled UCDN.

On Sat, Dec 22, 2018 at 10:15 AM Khaled Hosny <dr.khaled.hosny@gmail.com>= ; wrote:
On Sat,= Dec 22, 2018 at 12:11:15PM +0200, Eli Zaretskii wrote:
> > Date: Sat, 22 Dec 2018 11:06:44 +0200
> > From: Khaled Hosny <dr.khaled.hosny@gmail.com>
> > Cc: Glenn Morris <rgm@gnu.org>, far.nasiri.m@gmail.com, behdad@behdad.org,
> >=C2=A0 =C2=A0 =C2=A033729@debbugs.gnu.org, kaushal.modi@gmail.com
> >
> > > Alternatively, we could just use HarfBuzz=E2=80=99s own buil= t in ucdn-based
> > > Unicode function for this. The only reason for overriding th= is in Emacs
> > > was to keep HarfBuzz and Emacs Unicode support in sync, but = if we are
> > > going to duplicate the Unicode script data then better use w= hat HarfBuzz
> > > has.
> > >
> > > I=E2=80=99m going to try this now.
> >
> > I pushed a commit to harfbuzz branch that I think fixes this issu= e now.
>
> Thanks.
>
> There's a FIXME in the change you pushed (which I believe just
> repeats what was already in the previous version).=C2=A0 Ca you tell m= ore
> about the problem we need to fix there?

We need a way to get Unicode composition and decomposition for the
a given character (implementing the uni_compose and uni_decompose
functions I deleted). I recall you suggested something earlier that I
tried but couldn=E2=80=99t get to work, the exact detail escapes me.


--
--000000000000d3d646057d9dffc4--