bug#14575: 24.3.50.1; Overlays with a window property affect other windows

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

To reproduce

Start emacs -Q
M-:

(progn
  (insert "some text")
  (let ((ov (make-overlay (- (point) 9) (point))))
    (overlay-put ov 'window (selected-window))
    (overlay-put ov 'display "different text"))
  (split-window-vertically))

RET

Evgeni

[-- Attachment #2: Type: text/html, Size: 473 bytes --]

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[Eli Zaretskii]

> Date: Sat, 8 Jun 2013 14:58:58 +0100
> From: E Sabof <esabof@gmail.com>
> 
> Start emacs -Q
> M-:
> 
> (progn
>   (insert "some text")
>   (let ((ov (make-overlay (- (point) 9) (point))))
>     (overlay-put ov 'window (selected-window))
>     (overlay-put ov 'display "different text"))
>   (split-window-vertically))
> 
> RET

Fixed in trunk revision 112896.

Thanks.

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

Cool, thanks. That was fast.


On Sat, Jun 8, 2013 at 7:34 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Sat, 8 Jun 2013 14:58:58 +0100
> > From: E Sabof <esabof@gmail.com>
> >
> > Start emacs -Q
> > M-:
> >
> > (progn
> >   (insert "some text")
> >   (let ((ov (make-overlay (- (point) 9) (point))))
> >     (overlay-put ov 'window (selected-window))
> >     (overlay-put ov 'display "different text"))
> >   (split-window-vertically))
> >
> > RET
>
> Fixed in trunk revision 112896.
>
> Thanks.
>

[-- Attachment #2: Type: text/html, Size: 964 bytes --]

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[Eli Zaretskii]

> Date: Sat, 8 Jun 2013 19:47:24 +0100
> From: E Sabof <esabof@gmail.com>
> Cc: 14575-done@debbugs.gnu.org
> 
> Cool, thanks. That was fast.

Well, it's Saturday...

Btw, this bug was introduced 2 years ago, during the development of
v24.1, and no one ever said anything until now.  I guess that speaks
volumes of how frequently people use window-specific overlays.

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[Dmitry Gutov]

Eli Zaretskii <eliz@gnu.org> writes:
> Btw, this bug was introduced 2 years ago, during the development of
> v24.1, and no one ever said anything until now.  I guess that speaks
> volumes of how frequently people use window-specific overlays.

company-mode does use them, but with `before-string' and `invisible'
instead of `display'. Not exactly sure why.

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[Michael Heerdegen]

Eli Zaretskii <eliz@gnu.org> writes:

> Btw, this bug was introduced 2 years ago, during the development of
> v24.1, and no one ever said anything until now.  I guess that speaks
> volumes of how frequently people use window-specific overlays.

I use them all the time for different purposes - but only for
highlighting stuff like highlighting the current line of the selected
window, or give a visual orientation when scrolling a window.  It's
probably quite unusual to change the displayed text of a buffer on a
per-window basis.

Michael.

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

>
> Well, it's Saturday...
>
> Btw, this bug was introduced 2 years ago, during the development of
> v24.1, and no one ever said anything until now.  I guess that speaks
> volumes of how frequently people use window-specific overlays.
>

I think the more advanced features of the display engine are generally
under-used. Maybe because there aren't as many users from the front-end
side of things.

Btw, I'm trying to implement variable width right/centered paragraph
alignment. Now that I think about it, I might also do justified text (with
varied width of spaces).

https://github.com/sabof/magic-buffer

It's still in prototype stages, but the prognosis is good. And with
window-specific overlays, I can make if work even it the text is displayed
in multiple windows simultaneously

[-- Attachment #2: Type: text/html, Size: 1289 bytes --]

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

Also, wanted to ask, is there a way to use bidi display to align English
text to the right?


On Sat, Jun 8, 2013 at 9:14 PM, E Sabof <esabof@gmail.com> wrote:

> Well, it's Saturday...
>>
>> Btw, this bug was introduced 2 years ago, during the development of
>> v24.1, and no one ever said anything until now.  I guess that speaks
>> volumes of how frequently people use window-specific overlays.
>>
>
> I think the more advanced features of the display engine are generally
> under-used. Maybe because there aren't as many users from the front-end
> side of things.
>
> Btw, I'm trying to implement variable width right/centered paragraph
> alignment. Now that I think about it, I might also do justified text (with
> varied width of spaces).
>
> https://github.com/sabof/magic-buffer
>
> It's still in prototype stages, but the prognosis is good. And with
> window-specific overlays, I can make if work even it the text is displayed
> in multiple windows simultaneously
>

[-- Attachment #2: Type: text/html, Size: 1781 bytes --]

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[Eli Zaretskii]

> Date: Sat, 8 Jun 2013 21:16:55 +0100
> From: E Sabof <esabof@gmail.com>
> Cc: 14575@debbugs.gnu.org
> 
> Also, wanted to ask, is there a way to use bidi display to align English
> text to the right?

You can set bidi-paragraph-direction to 'right-to-left, but I suspect
that's not what you want.  Editing and moving inside such text will
behave in ways people don't expect to see in strict left-to-right
text.

In general, the bidi display is not about alignment, it's about
display of bidirectional text.  That is what it was designed for, so
any other uses will not necessarily produce desired results.  That it
also flushes right-to-left paragraphs to the right margin is because
people who use right-to-left scripts expect that.

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

You can set bidi-paragraph-direction to 'right-to-left, but I suspect

> that's not what you want.

 Editing and moving inside such text will
> behave in ways people don't expect to see in strict left-to-right
> text.
>
> In general, the bidi display is not about alignment, it's about
> display of bidirectional text.  That is what it was designed for, so
> any other uses will not necessarily produce desired results.  That it
> also flushes right-to-left paragraphs to the right margin is because
> people who use right-to-left scripts expect that.
>

Indeed, the "directionally neutral" characters are displayed according to
the paragraph's main alignment. Anyway, once the centering works, adding
right alignment shouldn't be hard.

[-- Attachment #2: Type: text/html, Size: 1152 bytes --]

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[Stefan Monnier]

> v24.1, and no one ever said anything until now.  I guess that speaks
> volumes of how frequently people use window-specific overlays.

It's used in doc-view-mode, but indeed, it's rarely used.


        Stefan

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[Leo Liu]

On 2013-06-09 06:03 +0800, Stefan Monnier wrote:
> It's used in doc-view-mode, but indeed, it's rarely used.

I just used it a few days ago for something called
temp-buffer-browse-mode in my init that enables "SPC", "DEL" and "RET"
keys immediately after a temp buffer popup to scroll up/down and close
the temp buffer. (if this is generally useful I can submit it to the bug
tracker.)

Leo

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

I've compiled the latest trunk, the display property seems to be fixed, but
line-prefix, and wrap-prefix are still affected.


On Sat, Jun 8, 2013 at 7:34 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Sat, 8 Jun 2013 14:58:58 +0100
> > From: E Sabof <esabof@gmail.com>
> >
> > Start emacs -Q
> > M-:
> >
> > (progn
> >   (insert "some text")
> >   (let ((ov (make-overlay (- (point) 9) (point))))
> >     (overlay-put ov 'window (selected-window))
> >     (overlay-put ov 'display "different text"))
> >   (split-window-vertically))
> >
> > RET
>
> Fixed in trunk revision 112896.
>
> Thanks.
>

[-- Attachment #2: Type: text/html, Size: 1064 bytes --]

bug#14575: 24.3.50.1; Overlays with a window property affect other windows

[Eli Zaretskii]

> Date: Sun, 9 Jun 2013 11:31:03 +0100
> From: E Sabof <esabof@gmail.com>
> Cc: 14575-done@debbugs.gnu.org
> 
> I've compiled the latest trunk, the display property seems to be fixed, but
> line-prefix, and wrap-prefix are still affected.

Those prefix features were never coded to support window-specific
overlays, so this never worked.

Now fixed in trunk revision 112901.

Thanks.