From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Fredrik Bergroth Newsgroups: gmane.emacs.bugs Subject: bug#52329: Fix alignment of makefile-backslash-region Date: Mon, 6 Dec 2021 15:07:17 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e5785e05d27ac630" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26565"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52329@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 06 15:08:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1muEf8-0006fQ-LS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Dec 2021 15:08:14 +0100 Original-Received: from localhost ([::1]:42402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muEf7-0007Rh-Lk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Dec 2021 09:08:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muEew-0007N3-OV for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2021 09:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muEew-0005jS-G8 for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2021 09:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1muEew-0003GY-2C for bug-gnu-emacs@gnu.org; Mon, 06 Dec 2021 09:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Fredrik Bergroth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2021 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52329 X-GNU-PR-Package: emacs Original-Received: via spool by 52329-submit@debbugs.gnu.org id=B52329.163879965712517 (code B ref 52329); Mon, 06 Dec 2021 14:08:02 +0000 Original-Received: (at 52329) by debbugs.gnu.org; 6 Dec 2021 14:07:37 +0000 Original-Received: from localhost ([127.0.0.1]:60912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muEeW-0003Fp-Mf for submit@debbugs.gnu.org; Mon, 06 Dec 2021 09:07:36 -0500 Original-Received: from mail-lf1-f46.google.com ([209.85.167.46]:37723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muEeU-0003Fc-8m for 52329@debbugs.gnu.org; Mon, 06 Dec 2021 09:07:35 -0500 Original-Received: by mail-lf1-f46.google.com with SMTP id c32so25612244lfv.4 for <52329@debbugs.gnu.org>; Mon, 06 Dec 2021 06:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h1gWg3MgwSJt5sO36UHanBN+vQQGl3ulziLHhMBnuTA=; b=Sq1VV9RjwF+th1fPwXJ9LS4jsPAYbqTcHkLvMi+GMeSqBRXicXbYygQ+AoFgXGW1Sf FxMCZiYlqsp5nOvufctU4K3GY2Sn63qGm40hxOR9rrdITiPLZ5PZWlPTV/2mUvx54l9o bErCiSzLAQEJsNvDEZ1ZRouz+5msQc3yUzL68uffbHvQH+OVEiy/fuM3PuSi/Vi3cxRK IqIq9bdtLez+/uQCoeYL1bfndB2Q8y0N2tjacKz4jriM1ExcepGWVQn9VsvR0aIYv0eT ZGJbDl6q3WGxKXxsLyAmnJgMhQwEuhJpOzxW3d6WipNjyxyJZNrpDEw+o+mhegoC1S8N rkuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h1gWg3MgwSJt5sO36UHanBN+vQQGl3ulziLHhMBnuTA=; b=uczuF4VrpxwUGGmhEpA3QJDYLyJQt0TrPVqhkFj6DJ6sYCAH8BzkzfqkvM1Hyyc9/X zv0UcmHUR/2OSAhsLwlEyoufagnlxsRXH7hNuAXXaUgUglds6KysXVWqLQGRNrcATP9D 6iY6hEFQDdSaJiIUFmkW+FB8L+Pxmrpsp3M3XQeyePFtGsfCL9dXJMZfmIe+3WTYGv3u wM+rpI4lPe9kZPrOmlUQOzvzl2XwoWlzlNpA1MEiSjqxwBxUHlcTzpby/6SIpRcY1HJp lBf3zpmhFe2cdOQlIsL+4/EvUMaAC+rEANn33iO94BwOrO5dKYnODwSMYI5tnL+8CUt+ 75rA== X-Gm-Message-State: AOAM531P/rce86Mdqk0L7r7N1oCGMENIt8ETfz74gOLIQAHjG/27dTSQ LKmLCR1ulZVFRQsqrmexSzP+DoS/krnSx4AA3lE= X-Google-Smtp-Source: ABdhPJznj8nfHUGsNR6GOt2Oypr5UHUsCJoOb8fw42jviggGCVrkGKmQQyuYSoGeYQ97x2cxdYoPN+L6pIpU5FQS39k= X-Received: by 2002:ac2:4e0d:: with SMTP id e13mr35609086lfr.388.1638799648322; Mon, 06 Dec 2021 06:07:28 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221752 Archived-At: --000000000000e5785e05d27ac630 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sure! emacs -Q --eval '(makefile-mode)' --eval '(insert "a\nbbbbb\ncc")' --eval '(mark-whole-buffer)' --eval "(call-interactively 'makefile-backslash-region)" This will end up with a bunch of tabs (rather than spaces) after the "a" and the b:s. If you now change tab-width to 2, the backslashes won't align. Den m=C3=A5n 6 dec. 2021 kl 14:54 skrev Stefan Kangas : > Fredrik Bergroth writes: > > > `makefile-backslash-region' is inserting tabs rather than spaces (due t= o > the major mode setting indent-tabs-mode). > > The backslashes won't align properly (unless everyone agrees on a > tab-width). I attached a patch that fixes this. > > Thanks for the patch. > > Could you provide a recipe to reproduce this problem, preferably > starting from "emacs -Q"? > --000000000000e5785e05d27ac630 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sure!

emacs -Q --eval '(= makefile-mode)' --eval '(insert "a\nbbbbb\ncc")' --ev= al '(mark-whole-buffer)' --eval "(call-interactively 'make= file-backslash-region)"

This will end up with= a bunch of tabs (rather than spaces) after the "a" and the b:s. = If you now change tab-width to 2, the backslashes won't align.

Den m=C3=A5n 6 dec. 2021 kl 14:54 skrev Stefan Kangas <stefan@marxist.se>:
Fredrik Bergroth <fbergroth@gmail.com> writes:

> `makefile-backslash-region' is inserting tabs rather than spaces (= due to the major mode setting indent-tabs-mode).
> The backslashes won't align properly (unless everyone agrees on a = tab-width). I attached a patch that fixes this.

Thanks for the patch.

Could you provide a recipe to reproduce this problem, preferably
starting from "emacs -Q"?
--000000000000e5785e05d27ac630--