From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Williams Newsgroups: gmane.emacs.bugs Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Date: Sat, 14 Oct 2017 15:55:21 -0700 Message-ID: References: <87infi9t0p.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c06d8ac155f71055b89ab5d" X-Trace: blaine.gmane.org 1508021781 5080 195.159.176.226 (14 Oct 2017 22:56:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2017 22:56:21 +0000 (UTC) Cc: 28803@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 15 00:56:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3VLl-0008Bw-13 for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 00:56:09 +0200 Original-Received: from localhost ([::1]:55421 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3VLs-0004Oh-JT for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 18:56:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3VLj-0004OO-4I for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 18:56:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3VLg-0008Uh-22 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 18:56:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60273) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3VLf-0008Ub-Ty for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 18:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3VLe-0006pq-74 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 18:56:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Williams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2017 22:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150802172926227 (code B ref 28803); Sat, 14 Oct 2017 22:56:02 +0000 Original-Received: (at 28803) by debbugs.gnu.org; 14 Oct 2017 22:55:29 +0000 Original-Received: from localhost ([127.0.0.1]:40721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3VL7-0006ox-8r for submit@debbugs.gnu.org; Sat, 14 Oct 2017 18:55:29 -0400 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:46285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3VL6-0006ol-7M for 28803@debbugs.gnu.org; Sat, 14 Oct 2017 18:55:28 -0400 Original-Received: by mail-wm0-f46.google.com with SMTP id m72so27115918wmc.1 for <28803@debbugs.gnu.org>; Sat, 14 Oct 2017 15:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=b+v2L4EGdi8EbeimWs+BKpGqBtrcjnCU5BzbE8PJfIw=; b=gseRhJhA1lR9LdhytWzzd8qLGyePs+9P8TA2bLFV91gzCt0t6EaELTNyFEjpS1E/0g ZDi8vQW2U0OXF8Zw8tn+Ez6fuKvk/4gJxBBVOsREZkIewPgKnN6PNkdg8VhnxBX/9/5L zGdeJbi/I9Mm0urjdDsElIm4NKHmybKp0ruPeSxmxYJhuqM0EhXXnicLdEurIgxOh0t1 wpKj3A2SbWgpddwU2P6yXvoZ0hyS0Nso6PvogU2cFGbSvm4nJmBEikEM9sH5FnFwSxwO dxBJVNvVLZ6SofdlzhvDsufRtS+alxx6Sqai1ehp4WDSSLSaipD8YeY61DybA0l/eYou 7Mdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=b+v2L4EGdi8EbeimWs+BKpGqBtrcjnCU5BzbE8PJfIw=; b=sn4WSNVwRIzD+MPqHdxeVN2a1abdhg95VldykHo4TfX1u3ms+1FA0ksHy/Z7BDVXfU CnxFINRV58PZy1AEKmq1dAxm1Yarnqp6L35EnG7/0Nts/pKI/IxNGnJrAj7LsICGC1uc Rro6yL3G76rJ+ZjtWWvSmTw7Jsje1DUZPy2w6LB+VmG/o9VnPQig/i6sHAejyjFb77p6 ceTk4h74p9DXgVUv80l7TmMgATqPIlX0rr2/+xAJWVkSwVh4YNrxnBPZ7SO9R6Ob/5tU aIrwMemA8G5sb1OQK7gfsSsQLYLJYFtMcamen0r5crELWZKCCziiyxhuq4J+um9Dw/l+ SNCg== X-Gm-Message-State: AMCzsaXS7ck1AV37u9PaFM+ovKl3vhB0IazaZRIX7JygPcoEaMtYu+4K JQa+dIRce1HOcY6g4UyguYobH8xwx8ZwaG088kmLMw== X-Google-Smtp-Source: AOwi7QDzD2c4ETe38UccwWy4bchouQY8itIjM/pQujKDrh+dPhTCIQwLYAOOdcFPOOV8xu6XySlrSLRQpDTRQDdZqr0= X-Received: by 10.28.71.25 with SMTP id u25mr3993513wma.22.1508021722502; Sat, 14 Oct 2017 15:55:22 -0700 (PDT) Original-Received: by 10.28.111.93 with HTTP; Sat, 14 Oct 2017 15:55:21 -0700 (PDT) Original-Received: by 10.28.111.93 with HTTP; Sat, 14 Oct 2017 15:55:21 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: mg74a6Fk8cCHxaah158HT47AEXI X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138427 Archived-At: --94eb2c06d8ac155f71055b89ab5d Content-Type: text/plain; charset="UTF-8" Oops. Is there anything that can be salvaged from my patch? Aside from fixing the bug, it also adds a unit test and refactors the logic for finding a function's argument list into a separate function that's not part of the help system. On Oct 13, 2017 10:51 PM, "Noam Postavsky" wrote: John Williams writes: > Subject: [PATCH] Fixed compiler warnings for advised functions. I think this bug was already fixed in emacs-26, see [1: 6e2d6d54e1], Bug#14860 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=14860). [1: 6e2d6d54e1]: 2017-07-14 11:27:21 -0400 * lisp/emacs-lisp/bytecomp.el: Fix bug#14860. http://git.savannah.gnu.org/cgit/emacs.git/commit/?id= 6e2d6d54e1236216462c13655ea1fe573d9672e7 --94eb2c06d8ac155f71055b89ab5d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Oops. Is there anything that can be salvaged from my patc= h? Aside from fixing the bug, it also adds a unit test and refactors the lo= gic for finding a function's argument list into a separate function tha= t's not part of the help system.

On Oct 13, 2017 10:51 PM, "Noam Postavsky&quo= t; <npostavs@users.sou= rceforge.net> wrote:
jrw@pobox.com> = writes:

> Subject: [PATCH] Fixed compiler warnings for advised functions.

I think this bug was already fixed in emacs-26, see [1: 6e2d6d54e1],
Bug#14860 (https://debbugs.gnu.org/cgi/bug= report.cgi?bug=3D14860).

[1: 6e2d6d54e1]: 2017-07-14 11:27:21 -0400
=C2=A0 * lisp/emacs-lisp/bytecomp.el: Fix bug#14860.
=C2=A0 http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D6e2d6d= 54e1236216462c13655ea1fe573d9672e7

--94eb2c06d8ac155f71055b89ab5d--