From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#38181: Actual height of mode-line not taken into account Date: Fri, 15 Oct 2021 17:09:16 -0300 Message-ID: References: <87eeyd3ul0.fsf@bernoul.li> <83czo6k9p1.fsf@gnu.org> <83a6jak1vh.fsf@gnu.org> <83o87qhzs7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31023"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38181@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 15 22:10:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbTWv-0007vC-Uh for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Oct 2021 22:10:14 +0200 Original-Received: from localhost ([::1]:44802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbTWu-0005jA-R1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Oct 2021 16:10:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbTWk-0005iz-Rs for bug-gnu-emacs@gnu.org; Fri, 15 Oct 2021 16:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbTWk-0000Kq-JQ for bug-gnu-emacs@gnu.org; Fri, 15 Oct 2021 16:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mbTWk-0004Hi-7d for bug-gnu-emacs@gnu.org; Fri, 15 Oct 2021 16:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Oct 2021 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38181 X-GNU-PR-Package: emacs Original-Received: via spool by 38181-submit@debbugs.gnu.org id=B38181.163432857916434 (code B ref 38181); Fri, 15 Oct 2021 20:10:02 +0000 Original-Received: (at 38181) by debbugs.gnu.org; 15 Oct 2021 20:09:39 +0000 Original-Received: from localhost ([127.0.0.1]:40460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbTWM-0004H0-V1 for submit@debbugs.gnu.org; Fri, 15 Oct 2021 16:09:39 -0400 Original-Received: from mail-yb1-f171.google.com ([209.85.219.171]:35792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbTWJ-0004Gm-9z for 38181@debbugs.gnu.org; Fri, 15 Oct 2021 16:09:37 -0400 Original-Received: by mail-yb1-f171.google.com with SMTP id z5so25423138ybj.2 for <38181@debbugs.gnu.org>; Fri, 15 Oct 2021 13:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i6cSl7dzHr3sigVuWKA4XXGoLSeBgm+r86DQa4E/TDk=; b=jpYtptIRoencE4+TOUweBT0ncm9S1m1rUX5yUALAtqbjYQ5Lm/TnZ6vuqmB8YD7lhK jlb6ikTaqRHgiDC/ED8E/WiCcdgRKU/0mSBnrtlyuQJN5ZLikvyDzLELEYswHyrw3uDu yatxwY1RaftJzUWR/dszxXL2fyJOnufujyXJ31f/bDe01iUsTLLRcPTQug0FCW6YD9us KqiykWIEQ5vDK/38FWULONxDRdqAetKNL/3yU1H7FRoseBevQobEwBsK71gjdEqd+NZx ugJHmTvbxcdbAFIjuIcKDGRxkWh7L5RgqZ5GQ7IR6QuBkle2JZEyNhL7FQxLMagUKbE1 PGlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i6cSl7dzHr3sigVuWKA4XXGoLSeBgm+r86DQa4E/TDk=; b=rVRhgd0eFm4rzSaC477UMrN0Mz3h82RGSnYDQ+jEAVcut7CVEubV1qtZypb6JVFvuz JWQNBs7Vuwu7/j1hnUCt10wd+XL51X6zFyA4JPVbwdFT8itHq0Jw5ERtu+RqwNA1V6E8 ER2qVcsCxHiCbd0dMsx7RL29qSKVSM/Ohg7cB4uyQpBmODAe3h9F0X2TjgyUFODk3tEu di1vbnhopJx4+gx+OSucQbHdsHDhwrMPKpoBIHz0Q1wkUn+CajwqvUfh9LJ7Dyv2/uTi isNkVzQvJeHYmSSnMFmuKndHdohmKQUQR+mRPR1jqkJfxlXofytTs1K/ztLSxpq3bbYg hfxQ== X-Gm-Message-State: AOAM530a3vWxenUP68Z9hm2Xa39fooqAVQ5/Cu1MaqlqC3w7fIss/bpx ck1eIHIt+fWNpoPkEDB7dEqO4WhOhdacdO8HFb2YjIO44Vw= X-Google-Smtp-Source: ABdhPJzziIfnKFnOASGrBetVbB5gnpiB0+992K2GsLP3mCamt9UeVAlAWtBrvctT2nnWUvyM3pE1hFnAwA4XPe54wqc= X-Received: by 2002:a25:b4d:: with SMTP id 74mr13980531ybl.443.1634328569840; Fri, 15 Oct 2021 13:09:29 -0700 (PDT) In-Reply-To: <83o87qhzs7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217329 Archived-At: Hi Eli, > "Step 1" being the original recipe of Jonas? Then what is new about > this report that Jonas didn't already report and we didn't already > discuss and analyze? Perhaps the new steps? I will provide my perspective and the formal procedure to reproduce the issue one last time. Then I let it up to you to decide if you have already discussed it because the exact relationship between what I see and what happens under the hood is way beyond my knowledge. If after that you still feel that I should file a new ticket, just let me know and I will gladly do it as a mere automaton. In message #20 you said: > Why the need to use advising? Your recipe shows that calling > redisplay before fit-window-to-buffer also solves the problem. Can't > you do something like that only when you add such tall images to the > mode line? In message #29: > Code like 'fit-window-to-buffer' works on the text area > only, it doesn't care whether a scroll bar or mode line changed size > since last redisplay. In message #33: > If this is to make the mode line prettier, then it should be done > [calling redisplay] once, at the beginning of a session, right? In message #39 Martin said: > If we don't want 'fit-window-to-buffer' to do that always we'd need > some variable, either buffer local or even a window parameter, that > 'fit-window-to-buffer' would inspect once and reset immediately in > order to perform only the redisplay call that's really needed. There are more examples but I hope you get the gist of it. Moreover, there is the "conventional" workaround [1] which likely was a consequence of the discussion above. The advice deliberately deactivates itself after the first redisplay. So from what I can see there was some consensus regarding that a single call to redisplay after changing the modeline geometry would suffice. Now that's exactly what I am bringing into question here. I reiterate the recipe: 1. Execute the code. 2. Call test-popup and check that the layout is wrong. 3. Redefine test-popup with (redisplay) uncommented. 4. Call it again and check that the layout is right. 5. Redefine test-popup with (redisplay) commented again. 6. Call it again and check that the layout is wrong again. Specifically, step 6 contradicts the statement that doing a redisplay after modifying the modeline geometry is enough. Now you might say: but then why are you reporting this here, it is not a modeline issue. To what I would answer: you still need step 1 that involves modifying the modeline. And if you then asked: but what's new wrt what was already discussed? I would answer exactly like I'm answering now and we would be going around in circles. I understand the issue is confusing but sadly I don't know enough about the subject to make it clearer to you. Maybe I'm not saying anything new about the internals you already know, but from outside it looks different. Best regards, Carlos --- [1] https://github.com/tarsius/moody/blob/9b679400ca885b8ff51bcfd75b87f79d66c0ee26/moody.el#L303