From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#51858: 29.0.50; pcomplete not ignoring case Date: Fri, 19 Nov 2021 02:06:43 -0300 Message-ID: References: <87ee7i0xiq.fsf@gnus.org> <87sfvxzw49.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1164"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51858@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 19 06:08:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnw8A-000AZC-EU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 06:08:10 +0100 Original-Received: from localhost ([::1]:45936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnw88-0000Sd-V6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 00:08:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnw82-0000SU-Br for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 00:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnw82-0004M3-3X for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 00:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnw81-0005IU-PZ for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 00:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Nov 2021 05:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51858 X-GNU-PR-Package: emacs Original-Received: via spool by 51858-submit@debbugs.gnu.org id=B51858.163729842620291 (code B ref 51858); Fri, 19 Nov 2021 05:08:01 +0000 Original-Received: (at 51858) by debbugs.gnu.org; 19 Nov 2021 05:07:06 +0000 Original-Received: from localhost ([127.0.0.1]:37612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnw78-0005HD-Fj for submit@debbugs.gnu.org; Fri, 19 Nov 2021 00:07:06 -0500 Original-Received: from mail-yb1-f173.google.com ([209.85.219.173]:45932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnw74-0005Gc-IF for 51858@debbugs.gnu.org; Fri, 19 Nov 2021 00:07:05 -0500 Original-Received: by mail-yb1-f173.google.com with SMTP id s186so24944630yba.12 for <51858@debbugs.gnu.org>; Thu, 18 Nov 2021 21:07:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OYCFVMk9OXHhEeCUqn0K5IvzDFJ5DbXYxjUmUI93CyE=; b=UEi6XG1oNpAZRqWs90YfYU0uM8cEGmW8bG9AIi1qzNfAdiI7GNG8F3XGH+V+zQDmPF qYTSSYHb6g53c7EQ4LHcex+HddHvNUmsQlHbU1Wsoo/AkBGYtV7svnOnOdEZJgEvPm2A WReZV3uJUpSUcHcI4pUptDXDcI2Xyjw2rt2E79vgMhkJAmnBINYvw+WJ173rax7d0aFr BTVcQLWUOA9hDkpbvD44SBZrb66YPvkDdP/Lz6OyYAW/f8Gk6lWz+dQGMiyB4RiFjEXU y3MQvcqUpHUE6i7DsI/yNvu7WuTMmoqCNJ8cAqr1oFuqQ05MAMw93mEKULXW3hiRHszK PP9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OYCFVMk9OXHhEeCUqn0K5IvzDFJ5DbXYxjUmUI93CyE=; b=pDurzYDpnOWc48hwlMDRDkkNRMgwKa1Dqag+HvkCETgLSmsKlNfAonCvGFn9nDAIfp yscMlN3BJaUi+0hwLoHeNudwgtLdETY2uVO4xdwvEEJ/wGzP2z+NYzw2tZLOGHMaMQME LRPpQDBi0T3Dg1ACherTRWtanRGobBl660rWookNm75O6oBRa0ZFtOd16JqDFkH3G2zg 6gBbnDJLvFL906AXXTnX3hHZMqFu/t8LXhrAILIuWyfqDyzVnPUrFg41pReba6jcCTGT Td97SxUw5IZGkm2PkzPFaNTeLfh0O1nvefdBphyvyj7UsFPPB5xX3bSxZwODbHEaJNua J9kA== X-Gm-Message-State: AOAM533X9KJEkX4m0i2/kNWH08qcLW1BLFUeLMwhFXlSyP8pz1OSfeJj c623EVOAu7FKCki6bcdbaB+D10bhj7G4icZuz9VqSPgiOkk= X-Google-Smtp-Source: ABdhPJwinJDAc/f85zZLJ0Xie9g1/PxO6OOvzhg82Ny2YA3W5h0k87cXpcEPdFvMUC0gse3j5xiaZLiQUaQ+my7GLHA= X-Received: by 2002:a25:ab4c:: with SMTP id u70mr31820667ybi.82.1637298416884; Thu, 18 Nov 2021 21:06:56 -0800 (PST) In-Reply-To: <87sfvxzw49.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220360 Archived-At: Hi Lars, Thanks! Your fix works for me. I'm not sure if this is the best place to set completion-ignore-case though. If you look at the code for comint--complete-file-name-data you will find that completion-ignore-case is set in the same way that you did. But perhaps too late because at that point comint-completion-file-name-table has already been called. Perhaps the best fix is to bind completion-ignore-case earlier in comint--complete-file-name-data. But if comint-completion-file-name-table is intended to be called from other places, then it's better to set completion-ignore-case there as you did. Best regards, Carlos