From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap) Date: Mon, 14 Oct 2019 23:30:08 -0300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="163342"; mail-complaints-to="usenet@blaine.gmane.org" To: 37755@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 15 04:31:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKCcA-000gJa-UJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 04:31:11 +0200 Original-Received: from localhost ([::1]:59518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKCc9-0000ln-PR for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Oct 2019 22:31:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45272) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKCc3-0000iz-Ee for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:31:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKCc2-0005ol-H8 for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:31:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33683) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKCc2-0005of-EA for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKCc2-0004SE-8g for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 02:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37755 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157110662617078 (code B ref -1); Tue, 15 Oct 2019 02:31:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Oct 2019 02:30:26 +0000 Original-Received: from localhost ([127.0.0.1]:42504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKCbR-0004RN-E9 for submit@debbugs.gnu.org; Mon, 14 Oct 2019 22:30:26 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:56028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKCbP-0004RF-9j for submit@debbugs.gnu.org; Mon, 14 Oct 2019 22:30:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45216) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKCbO-0000iF-7J for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:30:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKCbN-0005XJ-7w for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:30:22 -0400 Original-Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]:36443) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKCbN-0005Wg-0p for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:30:21 -0400 Original-Received: by mail-yb1-xb2d.google.com with SMTP id t4so3403296ybk.3 for ; Mon, 14 Oct 2019 19:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=PyO59Dz4pkK3AO1uPJdgDWFxa2UO7/omuXYQq0FJN78=; b=XN8s1TbrLdnuCnM/efvH9fQ3VBdwGsHYMCTsqd4WkL/j6wmYHsO1nJncx+DEMZEuEj Na6hkbHDY2zkWOmBWjsQ/I9kVuk6KLBTNRP0jTsn5yekXLR+inhdCzATFAYRGkpkAuwY +Ud8j+ciGNACtgnJ/Hfn+HrawdjwEOw/QwK/YvJZoOHYEdNFe1wXHnR5JQukCogWl7P+ pWyaS0bz9VWNesrohysGAGvzb6OdEvsFbiHZvFRhzYyhTU+vgC4JuDZLBX6F9KX3YidL k09Dcsip6hLraul+MfH6FgPLzrPYmHkdApcrubW/h64O6O7L5qoS0CFkbnHchqdinH8S r7yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PyO59Dz4pkK3AO1uPJdgDWFxa2UO7/omuXYQq0FJN78=; b=YU/XfT/jnusV2PBEEe1fCLZDxu00YA8o1frJyaWT9IZoZuDUHo50bVKme7p3A7vow4 EPn+wg5UjJGyo+3PC8AbZkJvnfpGR+J44HMW2waoHBaSOSgWKX+3IF8Jk3DZaDhJfrVz GOQGgWHWUwEp06+ZQmDVWeMraSpqWQpOik2Db5rHz0v8oCRU0pw8X9vDu5VV8bpQy/uV PYnzEAqcNveGILLvWhUnYgiai9ETcuSP1WNqGbIvGvcTHlywzI2RFyVKAWKnPt67AG9d nK00Q25Wp/DGSygTQ3PAlxq3hbldfvLIFU/c+g/rYr8B7yZDVEuuYK5SHzPIgbLm1WuV u/6A== X-Gm-Message-State: APjAAAVrr2gPFZAzipb29SAc2s1DHzliifUKcKAueQyHff1b/MD8J4To GygxbbIcfN0U5ccAPdsAPid2OWX52VvmKi/bhHfnrSPOLo0= X-Google-Smtp-Source: APXvYqyj1VN7v7GTAmsmquTKfqoinKFKVGu1W0Yc0SKb/Qo4nYHxt+Vb3GBYntypskvpbgDVJH1jzQ/4Blob4q1bGFY= X-Received: by 2002:a25:9947:: with SMTP id n7mr21832865ybo.263.1571106619886; Mon, 14 Oct 2019 19:30:19 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169348 Archived-At: In fringe.c you have init_fringe_bitmap with this structure: ``` #if defined (HAVE_X_WINDOWS) ... #ifdef USE_CAIRO ... #endif ... #endif #ifdef HAVE_NTGUI ... #endif if (!once_p) { .... rif->define_fringe_bitmap (...) .... } ``` Now, this is backend specific code that should be moved behind the redisplay_interface. It seems to me that the obvious candidate to host that code is define_fringe_bitmap. The once_p clause is related to pdumper which I ignore all about. Best regards -- Carlos