From: Carlos Pita <carlosjosepita@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31764@debbugs.gnu.org
Subject: bug#31764: 26.1; Point in VC change log is not centered as documented
Date: Fri, 8 Jun 2018 18:28:55 -0300 [thread overview]
Message-ID: <CAELgYhf7i7H0UdLu_BDci+J-jmzif3pCDX0oL4RySoFfBP7R=g@mail.gmail.com> (raw)
In-Reply-To: <CAELgYhca-D+vuAAtbBGVPtnvu+SxoZU2yeetuhYvy-Z3fMp=1w@mail.gmail.com>
AFAICS what I'm observing is consistent with the docstrings of
vc-print-log and vc-print-log-internal:
vc-print-log
It is bound to C-x v l
...
If WORKING-REVISION is non-nil, leave point at that revision.
...
When called interactively with a prefix argument, prompt for
WORKING-REVISION and LIMIT.
vc-print-log-internal
...
Leave point at WORKING-REVISION, if it is non-nil.
So without a prefix I'm indeed passing a nil working-revision argument
(I checked this with edebug).
Now, when I pass a prefix argument it asks me for a revision (default
is the last one) but it's again unable to set the point at that
revision. The default revision is shown as "last revision" and its
value is nil (so despite the ambiguity in the docstrings, no prefix
arg invocation should go to "last revision" too).
In the call to vc-log-internal-common goto-location-func is nil. This
is the next to last argument which is passed by vc-print-log-internal
with value:
;; When it's nil, point really shouldn't move (bug#15322).
(when working-revision
(lambda (bk)
(vc-call-backend bk 'show-log-entry working-revision)))
So it's no surprise the point is not being moved around at all. But
the comment is not right: nil is "last revision". Now, #15322 is a
very old bug so maybe the representation of the "last revision"
changed since then?
next prev parent reply other threads:[~2018-06-08 21:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 19:23 bug#31764: 26.1; Point in VC change log is not centered as documented Carlos Pita
2018-06-08 19:38 ` Eli Zaretskii
2018-06-08 19:57 ` Carlos Pita
2018-06-08 20:12 ` Eli Zaretskii
2018-06-08 20:15 ` Carlos Pita
2018-06-08 21:28 ` Carlos Pita [this message]
2018-06-08 21:47 ` Carlos Pita
2018-06-08 22:10 ` Carlos Pita
2018-06-09 0:29 ` Noam Postavsky
2018-06-09 0:57 ` Carlos Pita
2018-06-09 6:46 ` Eli Zaretskii
2018-06-09 14:18 ` Carlos Pita
2018-06-12 0:10 ` Noam Postavsky
2018-06-12 2:32 ` Eli Zaretskii
2018-06-14 23:20 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELgYhf7i7H0UdLu_BDci+J-jmzif3pCDX0oL4RySoFfBP7R=g@mail.gmail.com' \
--to=carlosjosepita@gmail.com \
--cc=31764@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).