From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37689: Fringe pixmaps, widgets, etc. look ridiculously tiny in hidpi screen Date: Wed, 16 Oct 2019 13:31:06 -0300 Message-ID: References: <83v9swqz9q.fsf@gnu.org> <835zkrk9q9.fsf@gnu.org> <20191014131955.GC45622@breton.holly.idiocy.org> <83pnizidi3.fsf@gnu.org> <83mue3icjm.fsf@gnu.org> <83lftni815.fsf@gnu.org> <83bluigxu0.fsf@gnu.org> <0a1ca6fb-ce34-2ace-ad32-5b3b0193c4e4@gmx.at> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000066e2d0059509a1b5" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157173"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Alan Third , 37689@debbugs.gnu.org, Robert Pluim To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 18:37:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKmIX-000enB-1e for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 18:37:17 +0200 Original-Received: from localhost ([::1]:45480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKmIV-000193-PH for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 12:37:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34506) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKmDU-0005Xm-9V for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 12:32:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKmDS-0001QU-I4 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 12:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37616) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKmDS-0001QJ-Ee for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 12:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKmDS-0004nF-AO for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 12:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 16:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37689-submit@debbugs.gnu.org id=B37689.157124348718379 (code B ref 37689); Wed, 16 Oct 2019 16:32:02 +0000 Original-Received: (at 37689) by debbugs.gnu.org; 16 Oct 2019 16:31:27 +0000 Original-Received: from localhost ([127.0.0.1]:46437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKmCt-0004mN-7v for submit@debbugs.gnu.org; Wed, 16 Oct 2019 12:31:27 -0400 Original-Received: from mail-yw1-f66.google.com ([209.85.161.66]:40235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKmCr-0004m8-KO for 37689@debbugs.gnu.org; Wed, 16 Oct 2019 12:31:26 -0400 Original-Received: by mail-yw1-f66.google.com with SMTP id e205so8864115ywc.7 for <37689@debbugs.gnu.org>; Wed, 16 Oct 2019 09:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YD0XuV+Vzqv6tRdm0ErIAzVdeLeeUhv3hbvov2gfrI4=; b=FH6vFweHZyy/87nLOPTI/Ii0CNy5sMkwIxqdfaLdzGSntckl0sU7pU/mAlUGrBL+vg 2baaAw/T9+SZduNeHpCTP50/5ld99U0J0pmUQWWX8V8ovOobtH+QaKahjLXkn4k+9pNl Mlt/GbFxErw9zdfL0W1AKkzcSoKCI05PHyYctIXnuMYBkeDlEIyJzSNnQBmlhfGjXs5V ntkCBmU50tC9vbOvk7cu4DE5HxBAfTef53/F80TazJCtyaq6FpBDX45gWHP1iOx2M1s8 65jBUrB2hFCcHYicGgBO60B81HHWuxUiNUACgWcA7a30jPcWqSpYeNTGRzhowA0A16w5 rWzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YD0XuV+Vzqv6tRdm0ErIAzVdeLeeUhv3hbvov2gfrI4=; b=HFUftvFLPDxUipVnyE3GHp/hXr+GqVWr1GOK2NlOyusnsHiiXPNEekjsX/RUAMUaVe C42rMKTtNqn24yvp4eFN8+B3ypqtbkjqXmUHHnkDqt499cVs7vSrsGccVYs+Lvenwags wagVtJdO2oPmjBxzHXBJ5a9RNlCDnx1CaNa5QvWOAdZoaaeEbsQj2qzmoQdcBTWTzXpV JE6+BAtqON0bCLcF0uXiIw8mQxW+mo1i5LUkr+VQGfgpyviogdCk2cjBcW8Iy8PF12o+ UO+kQBTYW1gC+KeyoTrJciS2mo6IO/OiyTYqbnQkEe30k2fPbLksDdtJiKKbO6czlGnY kg2g== X-Gm-Message-State: APjAAAXFnOUw2q5oP9Idpuw5df0TlirJVK1B1SORB1th4ycjjb2o/bsV KnlawAcMzcFl5fIdOZJhBEUudhodAU2/BjdT0Uc= X-Google-Smtp-Source: APXvYqyOXVWksnEX9xerRydCYvB3bygTy9X8dq97VqMxeI3EgU/ltc2LQqmAs5X6A0Y/H416saGM01jsOGNCzEOSmvE= X-Received: by 2002:a81:996:: with SMTP id 144mr22468612ywj.57.1571243478624; Wed, 16 Oct 2019 09:31:18 -0700 (PDT) In-Reply-To: <0a1ca6fb-ce34-2ace-ad32-5b3b0193c4e4@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169463 Archived-At: --00000000000066e2d0059509a1b5 Content-Type: text/plain; charset="UTF-8" > Please just call it WINDOW_FRAME_SCALE_FACTOR or FRAME_SCALE_FACTOR. > WINDOW_SCALE_FACTOR implies that it could be different for different > windows on the same frame. Good point, I've changed the name to WINDOW_FRAME_SCALE_FACTOR. I've a bad feeling towards the conditional hidden behind that macro, though. It's necessary because WINDOW_LEFT/RIGHT_FRINGE_WIDTH are being called in contexts where the rif is still unavailable; so knowing of no other sensible default, I just defaulted to 1. Now, there is a bad smell in these requests for geometry parameters in places where the exact geometry may still be unknown (although I believe geometry is indeed known because, even if there isn't a rif, cursory debugging shows that there already is a frame in all problematic cases). So either these usages asume geometry is not dependent on the current screen or, less problematically and more probably, the rif is being initialized too late. A careful inspection of every use place is a lot of work (I might be doing some of it next weekend, though) so for now I'm just returning a sane default so that we can safely move forward. --00000000000066e2d0059509a1b5 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-fringe-honour-scale-factor-in-Cairo-backend.patch" Content-Disposition: attachment; filename="0001-Make-fringe-honour-scale-factor-in-Cairo-backend.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1thnx920 RnJvbSA2Y2U4NjIzNjBiYzkzNjk5MTZhMjVjOTMzYmY0YTg0Yjk4OTg0OWI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBXZWQsIDE2IE9jdCAyMDE5IDAxOjE4OjQ5IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gTWFr ZSBmcmluZ2UgaG9ub3VyIHNjYWxlIGZhY3RvciBpbiBDYWlybyBiYWNrZW5kCgoqIHNyYy9mcmlu Z2UuYzogc2NhbGUgYml0bWFwIHdpdGggYW5kIGhlaWdodAoqIHNyYy94dGVybS5jOiBzZXQgZGV2 aWNlIHNjYWxlLgoqIHNlYy93aW5kb3cuaDogc2NhbGUgV0lORE9XX0xFRlQvUklHSFRfRlJJTkdF X1dJRFRIIG1hY3JvcwotLS0KIHNyYy9mcmluZ2UuYyB8ICA1ICsrKy0tCiBzcmMvd2luZG93Lmgg fCAxNCArKysrKysrKysrLS0tLQogc3JjL3h0ZXJtLmMgIHwgIDIgKysKIDMgZmlsZXMgY2hhbmdl ZCwgMTUgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvZnJp bmdlLmMgYi9zcmMvZnJpbmdlLmMKaW5kZXggMjJmM2JkYy4uNTI0MmU4NCAxMDA2NDQKLS0tIGEv c3JjL2ZyaW5nZS5jCisrKyBiL3NyYy9mcmluZ2UuYwpAQCAtNTYzLDYgKzU2Myw3IEBAIGRyYXdf ZnJpbmdlX2JpdG1hcF8xIChzdHJ1Y3Qgd2luZG93ICp3LCBzdHJ1Y3QgZ2x5cGhfcm93ICpyb3cs IGludCBsZWZ0X3AsIGludCBvCiAgIGludCBwZXJpb2Q7CiAgIGludCBmYWNlX2lkID0gREVGQVVM VF9GQUNFX0lEOwogICBpbnQgb2Zmc2V0LCBoZWFkZXJfbGluZV9oZWlnaHQ7CisgIGRvdWJsZSBz Y2FsZSA9IEZSQU1FX1JJRiAoZiktPmdldF9zY2FsZV9mYWN0b3IgKGYpOwogCiAgIHAub3Zlcmxh eV9wID0gKG92ZXJsYXkgJiAxKSA9PSAxOwogICBwLmN1cnNvcl9wID0gKG92ZXJsYXkgJiAyKSA9 PSAyOwpAQCAtNjAyLDkgKzYwMyw5IEBAIGRyYXdfZnJpbmdlX2JpdG1hcF8xIChzdHJ1Y3Qgd2lu ZG93ICp3LCBzdHJ1Y3QgZ2x5cGhfcm93ICpyb3csIGludCBsZWZ0X3AsIGludCBvCiAKICAgcC53 aGljaCA9IHdoaWNoOwogICBwLmJpdHMgPSBmYi0+Yml0czsKLSAgcC53ZCA9IGZiLT53aWR0aDsK KyAgcC53ZCA9IGZiLT53aWR0aCAqIHNjYWxlOwogCi0gIHAuaCA9IGZiLT5oZWlnaHQ7CisgIHAu aCA9IGZiLT5oZWlnaHQgKiBzY2FsZTsKICAgcC5kaCA9IChwZXJpb2QgPiAwID8gKHAueSAlIHBl cmlvZCkgOiAwKTsKICAgcC5oIC09IHAuZGg7CiAKZGlmZiAtLWdpdCBhL3NyYy93aW5kb3cuaCBi L3NyYy93aW5kb3cuaAppbmRleCA3MTk0NmE1Li43OTM3ZDFlIDEwMDY0NAotLS0gYS9zcmMvd2lu ZG93LmgKKysrIGIvc3JjL3dpbmRvdy5oCkBAIC04MjcsMTYgKzgyNywyMiBAQCAjZGVmaW5lIFdJ TkRPV19NQVJHSU5TX1dJRFRIKFcpCQkJXAogICAoV0lORE9XX0xFRlRfTUFSR0lOX1dJRFRIIChX KQkJCVwKICAgICsgV0lORE9XX1JJR0hUX01BUkdJTl9XSURUSCAoVykpCiAKKyNkZWZpbmUgV0lO RE9XX1NDQUxFX0ZBQ1RPUihXKQkJCQkJCQlcCisgIChGUkFNRV9SSUYgKFdJTkRPV19YRlJBTUUg KFcpKSA9PSAwID8gMQkJCQkJXAorICAgOiBGUkFNRV9SSUYgKFdJTkRPV19YRlJBTUUgKFcpKS0+ Z2V0X3NjYWxlX2ZhY3RvciAoV0lORE9XX1hGUkFNRSAoVykpKQorCiAvKiBQaXhlbC13aWR0aHMg b2YgZnJpbmdlcy4gICovCiAjZGVmaW5lIFdJTkRPV19MRUZUX0ZSSU5HRV9XSURUSChXKQkJCVwK LSAgKFctPmxlZnRfZnJpbmdlX3dpZHRoID49IDAJCQkJXAorICAoKFctPmxlZnRfZnJpbmdlX3dp ZHRoID49IDAJCQkJXAogICAgPyBXLT5sZWZ0X2ZyaW5nZV93aWR0aAkJCQlcCi0gICA6IEZSQU1F X0xFRlRfRlJJTkdFX1dJRFRIIChXSU5ET1dfWEZSQU1FIChXKSkpCisgICA6IEZSQU1FX0xFRlRf RlJJTkdFX1dJRFRIIChXSU5ET1dfWEZSQU1FIChXKSkpCVwKKyAgICogV0lORE9XX1NDQUxFX0ZB Q1RPUiAoVykpCiAKICNkZWZpbmUgV0lORE9XX1JJR0hUX0ZSSU5HRV9XSURUSChXKQkJCVwKLSAg KFctPnJpZ2h0X2ZyaW5nZV93aWR0aCA+PSAwCQkJCVwKKyAgKChXLT5yaWdodF9mcmluZ2Vfd2lk dGggPj0gMAkJCQlcCiAgICA/IFctPnJpZ2h0X2ZyaW5nZV93aWR0aAkJCQlcCi0gICA6IEZSQU1F X1JJR0hUX0ZSSU5HRV9XSURUSCAoV0lORE9XX1hGUkFNRSAoVykpKQorICAgOiBGUkFNRV9SSUdI VF9GUklOR0VfV0lEVEggKFdJTkRPV19YRlJBTUUgKFcpKSkJXAorICAgKiBXSU5ET1dfU0NBTEVf RkFDVE9SIChXKSkKIAogI2RlZmluZSBXSU5ET1dfRlJJTkdFU19XSURUSChXKQkJXAogICAoV0lO RE9XX0xFRlRfRlJJTkdFX1dJRFRIIChXKSArIFdJTkRPV19SSUdIVF9GUklOR0VfV0lEVEggKFcp KQpkaWZmIC0tZ2l0IGEvc3JjL3h0ZXJtLmMgYi9zcmMveHRlcm0uYwppbmRleCA2NzI1M2E2Li5i ZjFhYmEyIDEwMDY0NAotLS0gYS9zcmMveHRlcm0uYworKysgYi9zcmMveHRlcm0uYwpAQCAtNjA4 LDYgKzYwOCw3IEBAIHhfY3JfZHJhd19pbWFnZSAoc3RydWN0IGZyYW1lICpmLCBHQyBnYywgY2Fp cm9fcGF0dGVybl90ICppbWFnZSwKIAkJIGludCBkZXN0X3gsIGludCBkZXN0X3ksIGJvb2wgb3Zl cmxheV9wKQogewogICBjYWlyb190ICpjciA9IHhfYmVnaW5fY3JfY2xpcCAoZiwgZ2MpOworICBk b3VibGUgc2NhbGUgPSBGUkFNRV9SSUYgKGYpLT5nZXRfc2NhbGVfZmFjdG9yIChmKTsKIAogICBp ZiAob3ZlcmxheV9wKQogICAgIGNhaXJvX3JlY3RhbmdsZSAoY3IsIGRlc3RfeCwgZGVzdF95LCB3 aWR0aCwgaGVpZ2h0KTsKQEAgLTYyMiw2ICs2MjMsNyBAQCB4X2NyX2RyYXdfaW1hZ2UgKHN0cnVj dCBmcmFtZSAqZiwgR0MgZ2MsIGNhaXJvX3BhdHRlcm5fdCAqaW1hZ2UsCiAKICAgY2Fpcm9fc3Vy ZmFjZV90ICpzdXJmYWNlOwogICBjYWlyb19wYXR0ZXJuX2dldF9zdXJmYWNlIChpbWFnZSwgJnN1 cmZhY2UpOworICBjYWlyb19zdXJmYWNlX3NldF9kZXZpY2Vfc2NhbGUgKHN1cmZhY2UsIDEuIC8g c2NhbGUsIDEuIC8gc2NhbGUpOwogICBjYWlyb19mb3JtYXRfdCBmb3JtYXQgPSBjYWlyb19pbWFn ZV9zdXJmYWNlX2dldF9mb3JtYXQgKHN1cmZhY2UpOwogICBpZiAoZm9ybWF0ICE9IENBSVJPX0ZP Uk1BVF9BOCAmJiBmb3JtYXQgIT0gQ0FJUk9fRk9STUFUX0ExKQogICAgIHsKLS0gCjIuMjAuMQoK --00000000000066e2d0059509a1b5--