From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap) Date: Sun, 20 Oct 2019 12:47:13 -0300 Message-ID: References: <83a7a2gxp0.fsf@gnu.org> <83a79v620e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="236899"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37755@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 20 17:52:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMDVL-000zTC-89 for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 17:52:27 +0200 Original-Received: from localhost ([::1]:39090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMDVK-0007rq-2C for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 11:52:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57838) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMDR6-0006lv-Eg for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:48:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMDR5-000653-AD for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:48:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46314) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMDR4-00064v-Ha for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMDR4-0005xm-CJ for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2019 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37755-submit@debbugs.gnu.org id=B37755.157158645222885 (code B ref 37755); Sun, 20 Oct 2019 15:48:02 +0000 Original-Received: (at 37755) by debbugs.gnu.org; 20 Oct 2019 15:47:32 +0000 Original-Received: from localhost ([127.0.0.1]:55135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMDQa-0005x3-5r for submit@debbugs.gnu.org; Sun, 20 Oct 2019 11:47:32 -0400 Original-Received: from mail-yb1-f172.google.com ([209.85.219.172]:42575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMDQY-0005wq-Ql for 37755@debbugs.gnu.org; Sun, 20 Oct 2019 11:47:31 -0400 Original-Received: by mail-yb1-f172.google.com with SMTP id 4so3301684ybq.9 for <37755@debbugs.gnu.org>; Sun, 20 Oct 2019 08:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xc3ZBSfO8iCuKtikoIYKUaiMqiEsnvchdsbFUgWVyj8=; b=QQASUI1waLDhaoXO1Lf/18+GmbMwS72OMSCB7IRDISfkmI2HyRplPPPWr7mRReMHJy 6AoizEekLQEK0Ys3U1OfkYS/ZKsTsFby1Sx5R7clltVsn3k4mVCLtY9K1aeQfZUsF4Ug GQbn37yJVa2dVRGcV2FaQVfKeVWzyy/ZF/Xa/2I0dFBLSufXACgiYRb12RFFRNGqUtUA n7ftm/0e7NCBc5Pczui4uewqc06CGmq+p9sZFGu1oKRzWhJ0LWreGXID48nTlThrp8WR Sv7TBwU9BuMCc/a6Q5uJi8Bri18F51t18ddP6FzZyReAXYUShukh6n0wpzCInKKFm8aD lC5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xc3ZBSfO8iCuKtikoIYKUaiMqiEsnvchdsbFUgWVyj8=; b=VnHshOgAdPMjEjLznYrjIBSIaRUg5aXDQnh/YH9tq0aDQ1UGdHwrcDC+/bVa/xODne Tprmsqf8ZTZbeItPPcwreWw9T5C3bWi+uPKKgCEF962vzkZUraxNnDhxnQBvqjK4tbvU +kYKHzMByg/q1mXKjxSyvxAnEMAQDaf8RkV6T3Q2myYCBIdPOUo3pKrSrm7NwYN60iUZ xUQ0HNzYhm/x6pd3nOqPGFelk9ocR/cNSIKJGSHOXl5FwD2CShOgB2YZZSAzsJNeXTEp drSZdl8O1WnSaDoX7jtZJ+MylcSDIz0UMujgVyxSlNsgrzbcW+Le5e9t+shu+df6WbJs LkbQ== X-Gm-Message-State: APjAAAUm/SHDozOc5ksUscp9W/ug/oNRy2Go/eTQQrq5NbhjWrHR/bx1 wCRdYNKW4EWDH3/KI8b5s3AEy7mzOXop85WnZxVjxMHsHZo= X-Google-Smtp-Source: APXvYqxHXplv+xcm7lHcKqgYbnqdqnhWxY7AEUPVhU1p74gl17N6gXxMzzQGdrEWG3AOXKAqB12V6g+03VZyLW/e9mA= X-Received: by 2002:a25:9947:: with SMTP id n7mr12932429ybo.263.1571586445033; Sun, 20 Oct 2019 08:47:25 -0700 (PDT) In-Reply-To: <83a79v620e.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169827 Archived-At: Hi Eli, thank you for the review. >It looks like you removed > the call to init_fringe_bitmap during dumping, and left its equivalent > only in define-fringe-bitmap, is that right? > > What did I miss? The call to gui_init_fringe I guess. Also, notice that define_fringe_bitmap is quite different than Fdefine_fringe_bitmap. I suggest you take a look at the modified pseudo code I posted quite a few message above. > Emacs needs to have the standard fringe > bitmaps (for line truncation, continuation, etc.) be defined even > without a call to define-fringe-bitmap. This is indeed the case after applying the patch. Some bit shuffling has been postponed from init_fringe_once to gui_init_fringe, but that's all. Now, regarding the dumping stuff you mention, TBH I'm completely ignorant. So maybe this innocent looking delay of bit shuffling could have some effect, I don't now, but it's a very different thing from not initializing standard bitmaps until define-fringe-bitmap is first called from elisp world. Besides, whatever is missing after the C static initialization part is just this *platform dependent* bit shuffling, which I seriously doubt emacs could make sense of without the appropriate rif at hand, so quite late in the initialization sequence. I even suggested to avoid this destructive manipulation of platform independent bitmaps from the part of the rifs, although I've only followed my suggestion in the case of cairo, which was quite natural and convenient. Best regards -- Carlos