From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37689: Fringe pixmaps, widgets, etc. look ridiculously tiny in hidpi screen Date: Sun, 13 Oct 2019 21:40:14 -0300 Message-ID: References: <83sgo1rpbx.fsf@gnu.org> <831rvksksa.fsf@gnu.org> <83v9swqz9q.fsf@gnu.org> <83k19ao21y.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="136145"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Robert Pluim , 37689@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 14 02:41:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJoQD-000ZI9-5L for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Oct 2019 02:41:13 +0200 Original-Received: from localhost ([::1]:43680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJoQB-0001lf-A3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Oct 2019 20:41:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32809) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJoQ3-0001jL-A4 for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2019 20:41:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJoQ2-0007kP-5j for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2019 20:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56745) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJoQ2-0007kH-2V for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2019 20:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iJoQ1-0005E5-UK for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2019 20:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Oct 2019 00:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37689 X-GNU-PR-Package: emacs Original-Received: via spool by 37689-submit@debbugs.gnu.org id=B37689.157101363319939 (code B ref 37689); Mon, 14 Oct 2019 00:41:01 +0000 Original-Received: (at 37689) by debbugs.gnu.org; 14 Oct 2019 00:40:33 +0000 Original-Received: from localhost ([127.0.0.1]:37333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJoPZ-0005BX-9x for submit@debbugs.gnu.org; Sun, 13 Oct 2019 20:40:33 -0400 Original-Received: from mail-yw1-f67.google.com ([209.85.161.67]:41473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJoPX-0005B5-Q6 for 37689@debbugs.gnu.org; Sun, 13 Oct 2019 20:40:32 -0400 Original-Received: by mail-yw1-f67.google.com with SMTP id 129so5562563ywb.8 for <37689@debbugs.gnu.org>; Sun, 13 Oct 2019 17:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=98TbjnFPKE9uodcRUo7d+nBU0kpxCBJQ6OMW/2zsgek=; b=eL+ZREsNVoDIWOtQwCBcsDzwwCHXVzPwI19N8movyWV5WisRMrNXZHNX01dzbK7NTN 9V7oFhqwZTzpArCZ2/ttJp/ZcrvqmkHWiqWwb/MJI90XEORQVVywrSZVqIz7TQciUehB cYfODf26tXnK5zxKuqYuiT5186MzAuzlhBuY6btdlnJnXLmwjkcKqzC5ZkfnH6w3orh5 29Pex6UsPsQXp5NVnb6uIMyuU2jWazoBfIejekEX/cvisHLyMb0YQTLtoaK18cry6R3C tpH64GN3hVK2uFhl0oJPZ/Q19fdazaNmoVBnjncEsCYHxAh6xfVnlLRIv6551FZmblrl DWRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=98TbjnFPKE9uodcRUo7d+nBU0kpxCBJQ6OMW/2zsgek=; b=SUPwQvIwv3E1Xks3AMq/zyVRgFy/epOEBpv3pB+VWWmKT2GOFRQYxXL6q7uHK2bL44 6dcxP9dHgmhq+Xk48u3jiKj6u09Xb5L/ZfZUWr4A9kRIyiFnkjrwy4vlME+kP5NDNp17 QcmbK+0xW9i/l38WRyPfuMONZAkPm3UAoLQK7Zu5W2Sud0Tjb7r8VmOJC7jd3fqUfefC vV9r4/cueSsQDG0EqJOExE6S+ocpnfLMDd0OTeLaqaDJoc7aki45cLxlfg1v23I7j6ny eR0hVwwk+37EYfoBUaZut9Tt1zWFAjBCRBpU3VZkhAEEIe+GQT1t7OUrhzFJFp2St4MA q2iw== X-Gm-Message-State: APjAAAUfItwR9Xj1Ueazl0/EJGieSDPAMD5y4KMaMOcnOZ1xAiLImcm7 4LaPZCwMlAlYgCL0CQ5rGXCzhKaa9pdR0b8VWhM= X-Google-Smtp-Source: APXvYqwNX4CxuIy30kW5w4qzY4hfMcCaDPm5RhWGKApzB28D03d2m/y3BciQmcqyiB59fdJkl8VMzW5gCqhuv7iF+MU= X-Received: by 2002:a81:996:: with SMTP id 144mr11691065ywj.57.1571013625957; Sun, 13 Oct 2019 17:40:25 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169172 Archived-At: I've been reading some related code (fringe.c, xterm.c, etc) but at this point I feel I need some feedback from you in order to advance: 1. In my previous posts I have open two alternative paths: 1.a. Do the scaling as downstream as possible. The problem with this approach is that I will be fixing the problem only for one backend (for example, Cairo). Also, I would have to "hack" some assumptions done upstream (for example, to adjust x, y and scale of a rectangle that is assumed to be of a different geometry by the caller). The advantage of the approach is that not only fringe icons but any other image that is rendered by the lowest level routine will be properly scaled; but, that said, I noticed that in emacs 26.3 widgets are not using x_cr_draw_image. 1.b. Do the scaling upstream (for example, in get_fringe_bitmap_data as proposed above). One problem with this approach is that some backend could already be scaling output itself (for example, by using a toolkit that automatically scales according to the device resolution... do you know if this is the case for windows, for macos?). Also, it won't fix the widgets issue (anyway, as I said, neither the "downstream" approach will do it in 26.3). 2. I'm clueless regarding were widgets (I mean checkboxes and things like that) are rendered. With Cairo backend enabled, x_cr_draw_image is never reached in 26.3, its only user is the fringe module, I've checked this in the debugger and by inspecting the code. Not sure about 27, since tweaking x_cr_draw_image did have a (weird) effect, as the screenshots in my previous post show. Any help or opinion regarding these issues will be much appreciated, I really want to move this forward. Best regards -- Carlos