unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Carlos Pita <carlosjosepita@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 31884@debbugs.gnu.org
Subject: bug#31884: 26.1.50; Wrong icon in gtk tooltips
Date: Tue, 19 Jun 2018 21:12:23 -0300	[thread overview]
Message-ID: <CAELgYhdVxAzit_Crw0fegO6B_LTapEzD6CJ9=VMriW_qvRSRfA@mail.gmail.com> (raw)
In-Reply-To: <87po0ms4h5.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 131 bytes --]

It's just that it was so easy that I described it in words: change
show_all to show :). But ok, here I'm attaching a proper patch.

[-- Attachment #2: 0001-Remove-broken-icon-from-tooltip.patch --]
[-- Type: text/x-patch, Size: 762 bytes --]

From 8a0a4e6e8c6dfa6b546387d011e487b1484f572b Mon Sep 17 00:00:00 2001
From: memeplex <carlosjosepita@gmail.com>
Date: Tue, 19 Jun 2018 02:12:11 -0300
Subject: [PATCH 1/2] Remove broken icon from tooltip

---
 src/gtkutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gtkutil.c b/src/gtkutil.c
index 83b306a..06f38a0 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -762,7 +762,7 @@ xg_show_tooltip (struct frame *f, int root_x, int root_y)
       block_input ();
       gtk_window_move (x->ttip_window, root_x / xg_get_scale (f),
 		       root_y / xg_get_scale (f));
-      gtk_widget_show_all (GTK_WIDGET (x->ttip_window));
+      gtk_widget_show (GTK_WIDGET (x->ttip_window));
       unblock_input ();
     }
 #endif
-- 
2.17.1


  reply	other threads:[~2018-06-20  0:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 18:24 bug#31884: 26.1.50; Wrong icon in gtk tooltips Carlos Pita
2018-06-18 19:08 ` Carlos Pita
2018-06-19  1:03   ` Carlos Pita
2018-06-20  0:09     ` Noam Postavsky
2018-06-20  0:12       ` Carlos Pita [this message]
2018-06-20 23:47         ` Noam Postavsky
2018-06-21  0:18           ` Carlos Pita
2018-06-22  0:18             ` Noam Postavsky
2018-06-19  1:15 ` bug#31884: Carlos Pita
2018-06-19  1:17 ` bug#31884: (no subject) Carlos Pita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAELgYhdVxAzit_Crw0fegO6B_LTapEzD6CJ9=VMriW_qvRSRfA@mail.gmail.com' \
    --to=carlosjosepita@gmail.com \
    --cc=31884@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).