From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#31906: 26.1.50; Properly set completion-at-point-functions in eshell Date: Tue, 19 Jun 2018 23:59:29 -0300 Message-ID: References: <87vaaeqj8k.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1529463486 16798 195.159.176.226 (20 Jun 2018 02:58:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 20 Jun 2018 02:58:06 +0000 (UTC) To: 31906@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 20 04:58:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVTJp-0004EF-Ei for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jun 2018 04:58:01 +0200 Original-Received: from localhost ([::1]:45790 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVTLv-0006iF-8Y for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jun 2018 23:00:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVTLo-0006i9-9N for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 23:00:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVTLn-0007aK-Ev for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 23:00:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVTLn-0007Zm-AX for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 23:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fVTLm-00066Q-Sb for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 23:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jun 2018 03:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31906 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152946360023423 (code B ref -1); Wed, 20 Jun 2018 03:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Jun 2018 03:00:00 +0000 Original-Received: from localhost ([127.0.0.1]:56791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVTLk-00065i-7j for submit@debbugs.gnu.org; Tue, 19 Jun 2018 23:00:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVTLi-00065T-QT for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:59:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVTLc-0007VZ-NP for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:59:53 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVTLc-0007VT-Jv for submit@debbugs.gnu.org; Tue, 19 Jun 2018 22:59:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVTLb-0006h0-Er for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:59:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVTLa-0007Uv-MU for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:59:51 -0400 Original-Received: from mail-io0-x229.google.com ([2607:f8b0:4001:c06::229]:39237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVTLa-0007Ue-Gv for bug-gnu-emacs@gnu.org; Tue, 19 Jun 2018 22:59:50 -0400 Original-Received: by mail-io0-x229.google.com with SMTP id f1-v6so2149260ioh.6 for ; Tue, 19 Jun 2018 19:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=JwwcxVXQOog+NiciG6jtPvdyGnJRXm18y6cmziKKSR0=; b=vRlQ1CmWdRYfq0SJu9CzCT79VjNWy8CuUwR1CgbP+RXJqIDZW/+DE1xak5XVSmAM9+ Z5S6n75J+nxRtYfX8eyXO5c5ncQitSWOSmwJv9HmJ8itzFzPBTI/wxLUPQQOTK/JBhnC qSswOksdzms0kFDNyaf4iypwDBvyGjkvo3spTIIfUYhjZBQyA8XxFfXm+IZJJk8t5sXO EpJquZiI809/A9A9+ww1mXHg4q3w2bVO6Psix6pdRPhi4QIRHAxCP1qNlukbuzgNpLqq uPrb5qlw31Izod7E4sztYFRsfyQ7ylLF/ElnKuN1z7y2Js8DlepHExxkdc/usz12au/S SlgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=JwwcxVXQOog+NiciG6jtPvdyGnJRXm18y6cmziKKSR0=; b=IzkVzro8wtrvkG+nU00nQojb2ACuR/UQPGVsJ5ngu2hxTyHzZGjTSQibig8hZ1Zqf9 B4uc+nqGVKvPQfu8egAVyDpnj/TGfptfwJWND+RJ3xnD6sXmWjYohPAg3cep9nF2dG1j 5V2QrWAidVlb6/3f1cco9sPaQv6k9z9s8k+oh8OXRrFk3jDN6a0nnxhBHNT+KoZjQypZ SGvfxotuGgxqPyhNN6ojAIWdhrOKPcbH1d07Xsnb8qO5mrrbSNr2tL7z9b/IDQ2Wje3h Lsh81bR2hjpRWgV0I27gYYeHl+yk7I32h+2WcogaUJ7nPDlwwGL6RVEzXFHTe3jQwihj hG8w== X-Gm-Message-State: APt69E0j6dPUOSy3vo6I96KEGWJPXm56sXiWTnWKSRXNUAb1MeKV2zjR aFpqH2Fx+sWz8nCY8RUC/4hWoisffOsZ7Z1h/vCq7Q== X-Google-Smtp-Source: ADUXVKLJaZCal5fRL7KGzoQ74G0jBvOZ+FYju9VpWShnyFmQ/WDkYxjHaboo0XcsB+0QzkPCSnSjwmLXjFP5TsUebf0= X-Received: by 2002:a6b:de14:: with SMTP id v20-v6mr15859903iog.260.1529463589470; Tue, 19 Jun 2018 19:59:49 -0700 (PDT) Original-Received: by 2002:a02:97bb:0:0:0:0:0 with HTTP; Tue, 19 Jun 2018 19:59:29 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147641 Archived-At: Mmmh it seems to be that it's overriding the default pcomplete-completions-at-point. But then why is this default set at all? is directly bound to eshell-pcomplete, a simple wrapper around pcomplete, which AFAICS doesn't rely on completion-at-point-functions. But there is this workaround for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=12838 in the final line of eshell-pcomplete: (defun eshell-pcomplete (&optional interactively) "Eshell wrapper for `pcomplete'." (interactive "p") ;; Pretend to be pcomplete so that cycling works (bug#13293). (setq this-command 'pcomplete) (condition-case nil (if interactively (call-interactively 'pcomplete) (pcomplete)) (text-read-only (completion-at-point)))) ; Workaround for bug#12838. Although I don't fully understand the workaround. So to sum up, what I would have expected is: 1. completion-at-point-functions contains only elisp-completions-at-point. 2. M- is bound to completion-at-point. 3. is bound to a wrapper to pcomplete (that doesn't call completion-at-point). All these expectations are violated.