From: Carlos Pita <carlosjosepita@gmail.com>
To: 37932@debbugs.gnu.org
Subject: bug#37932: [PATCH] Support hidpi fringes and images with Cairo
Date: Sat, 26 Oct 2019 05:05:52 -0300 [thread overview]
Message-ID: <CAELgYhcfvXWheh6-JdLy8UbiBec2hB1Fu-YFFkORo-FCG1jFWQ@mail.gmail.com> (raw)
In-Reply-To: <CAELgYhe70fjMN7kKey6O=W+6Y=HznLz+hvdhkMTLzCZCofGBWQ@mail.gmail.com>
Here is an attempt to fix the above issues:
https://github.com/memeplex/emacs/commit/473beb25dd947c34392708ca40f1b3bf80613007
* It uses the scaling mechanism already present in image.c (notice
that imagemagick does its own scaling), so it works even without cairo
(except for fringes, of course).
* It removes the auto :scale property. I think this is the right thing
to do, applications that want to use the :scale parameter to transform
their images shouldn't lose the hidpi scaling nor explicitly call
image-compute-scaling-factor.
* The scale factor is slightly different than the one computed by
image-compute-scaling-factor, but anyway it's the scale factor that
was already computed by x/w32_scale_factor. Moreover, it has separated
x and y values.
A bit surprisingly the patch results in a code reduction of ~20LOC.
And there are image-compute-scaling-factor and image-scaling-factor
still remaining in image.el. The only user inside emacs is shr.el.
next prev parent reply other threads:[~2019-10-26 8:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 2:17 bug#37932: [PATCH] Support hidpi fringes and images with Cairo Carlos Pita
2019-10-26 2:30 ` Carlos Pita
2019-10-26 6:01 ` Carlos Pita
2019-10-26 6:43 ` Carlos Pita
2019-10-26 8:05 ` Carlos Pita [this message]
2019-10-26 9:14 ` Eli Zaretskii
2019-10-26 9:18 ` Carlos Pita
2019-10-27 8:22 ` Robert Pluim
2019-10-27 17:08 ` Carlos Pita
2019-10-27 17:10 ` Carlos Pita
2024-01-10 22:15 ` Stefan Kangas
2024-01-11 17:35 ` Carlos Pita
2024-01-11 18:21 ` Stefan Kangas
2024-01-11 18:38 ` Carlos Pita
2024-01-11 19:31 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAELgYhcfvXWheh6-JdLy8UbiBec2hB1Fu-YFFkORo-FCG1jFWQ@mail.gmail.com \
--to=carlosjosepita@gmail.com \
--cc=37932@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).