From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#32344: Date: Wed, 12 Sep 2018 14:04:15 -0300 Message-ID: References: <87h8kdwro4.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1536771787 12145 195.159.176.226 (12 Sep 2018 17:03:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Sep 2018 17:03:07 +0000 (UTC) To: 32344@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 12 19:03:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g08Xe-00033S-V8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Sep 2018 19:03:03 +0200 Original-Received: from localhost ([::1]:37300 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g08Zl-000317-Ka for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Sep 2018 13:05:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g08Zd-00030F-KF for bug-gnu-emacs@gnu.org; Wed, 12 Sep 2018 13:05:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g08Za-0004KK-AI for bug-gnu-emacs@gnu.org; Wed, 12 Sep 2018 13:05:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34167) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g08Za-0004KG-45 for bug-gnu-emacs@gnu.org; Wed, 12 Sep 2018 13:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g08ZZ-0003gH-PZ for bug-gnu-emacs@gnu.org; Wed, 12 Sep 2018 13:05:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87h8kdwro4.fsf@gmail.com> Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Sep 2018 17:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32344-submit@debbugs.gnu.org id=B32344.153677188314118 (code B ref 32344); Wed, 12 Sep 2018 17:05:01 +0000 Original-Received: (at 32344) by debbugs.gnu.org; 12 Sep 2018 17:04:43 +0000 Original-Received: from localhost ([127.0.0.1]:38425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g08ZG-0003fe-SQ for submit@debbugs.gnu.org; Wed, 12 Sep 2018 13:04:43 -0400 Original-Received: from mail-yb1-f177.google.com ([209.85.219.177]:33117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g08ZF-0003fL-Fr for 32344@debbugs.gnu.org; Wed, 12 Sep 2018 13:04:41 -0400 Original-Received: by mail-yb1-f177.google.com with SMTP id m123-v6so2036315ybm.0 for <32344@debbugs.gnu.org>; Wed, 12 Sep 2018 10:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=9RxiDSMd5B5bVJ4mdNf9Aq52YwGvOLewjdgkYHFhjwU=; b=SZP/s7AvCWZ9rCeMPCvm+B99vWiGzV/U/Q22MYA2OW3efi6VKYcTZbBr/uq8dAtBHG a0LF3q63Q6x5F+mjEfK/yY8BCAwXM37J8MKxIaciXxutVblGs39uOVgHoBILclQp0chU Q0O+cZsS7r7ZCsXiuEFX0jO4NeJGSXZvYp0n7WHCcTaccWsXYp506BFJC2TdrTOIS42m nhIelRCq/kRtYq6ixvd3JtkWQt7nUE6+IpPnumGDFt7hSRivLJSJqfgcaCat8ocwYTYQ IvErhv+svt22+R5HGlD7qk40R/EGQgXUJb9od8ZXKlB7NI7i8evbS76Bc40QLgOM3ESI iL5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9RxiDSMd5B5bVJ4mdNf9Aq52YwGvOLewjdgkYHFhjwU=; b=AXh0Rd3cakjN/bv/nqUI7HNQ8ndTkWQW1in0tfB2P9L7V09Akmi+wY2sGjtfME/5pG 7M6zSX0BdxRRvba7VXY9t9EUpO7ibMW1QwtUsQBBvu7npT+qw48a28RrNio30udH/4kf Q8X57zHzGwNVcCeRumpXBfoWLZEI/9LBRFoM1jkpTxI//w7Y3iwtAavLbai60xxJjRr4 pJmG2P+B7wZTXnDLZTGwBkSM1eg6Hnion4K76b9QnZhsmVKZdx0shKU3lULobzooVLSP slZhqaIA05o0mrUL6X0At3fXp/Z1LQsMJpQTo9P/3M5nr7vPi6KDol0g5st3NtVBAMC9 QoKw== X-Gm-Message-State: APzg51Cr6YYohW/q149J1oSZX+TLq6zVb9v04W0ojMr+hYLSrfp2j7+H Vgz8pHgMo3Y3ADN7b0KAPs1mNkjtGd+ym3gaTtcfwer9 X-Google-Smtp-Source: ANB0VdbaqlXZonB+qxrSsODmPCWuCTGyzCZM4wOAQ/gqCJplqSQPIW/XYyVo4swbDMr6jfH5a3Iu7Z1s7oB/sf9ihug= X-Received: by 2002:a25:84d2:: with SMTP id x18-v6mr1380099ybm.93.1536771875628; Wed, 12 Sep 2018 10:04:35 -0700 (PDT) Original-Received: by 2002:a25:42c4:0:0:0:0:0 with HTTP; Wed, 12 Sep 2018 10:04:15 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150258 Archived-At: Recently I've had some exchange with elpy maintainer and he said he would be glad to support full history fontification for python mode but he didn't want to add my advice (its final version is quoted below) to elpy in order to instrument comint-send-input, so for now we just have a wiki-level DIY solution. Now, I fully understand his concern, so is there any interest in adding this option to comint? It seems quite simple a change and it will allow inferior modes to fully colorize their history, which is a rather nice feature. In case there is any interest I could submit a patch. --- (advice-add 'comint-send-input :around (lambda (f &rest args) (if (eq major-mode 'inferior-python-mode) (cl-letf ((g (symbol-function 'add-text-properties)) ((symbol-function 'add-text-properties) (lambda (start end properties &optional object) (unless (eq (nth 3 properties) 'comint-highlight-input) (funcall g start end properties object))))) (apply f args)) (apply f args))))