unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Masayuki Hatta <mhatta@gmail.com>
To: 11732@debbugs.gnu.org
Subject: bug#11732: Follow-up to bug#11732
Date: Tue, 26 Jun 2018 18:10:26 +0900	[thread overview]
Message-ID: <CAECZVPAXjLje9ED6fp1hJa4OPbBLd9nVsNMPB4xZ9njuDamF0Q@mail.gmail.com> (raw)
In-Reply-To: <87obohkxga.fsf@XAVIER-PC.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

Hi!

Recently I built Emacs 26.1 on Windows 10 (w/ MSYS2 64bit) with the
patch as mentioned earlier.  It works as expected and seems to bring
no lousy side effects anymore.

This problem has been making Emacs on Windows almost unusable for
Japanese users (so most of them use their patched binary).  Thus I
appreciate if you apply the patch again.

Best regards,
MH

-----
What I did:

Following the instruction in INSTALL.W64 almost verbatim, using the
latest (as of Jun. 26, 2018) MSYS2 64bit on Windows 10 Pro 1803.

Applied the attached patch (this is against 26.1, but I am pretty sure
you can apply it to HEAD) and build.

Tested with "File -> Open File" dialog and "(w32-font-select)" dialog.
Both seem to work.

Also tested with Microsoft IME, ATOK 2017, Google Japanese Input and
SKKFEP (those are popular Japanese input system for Windows).

Please let me know if you want me to do additional info, tests, etc.

-- 
Masayuki Hatta
Associate Professor, Faculty of Economics and Management, Surugadai
University, Japan

http://about.me/mhatta

mhatta@gnu.org  / mhatta@debian.org / mhatta@opensource.jp /
hatta.masayuki@surugadai.ac.jp

[-- Attachment #2: diff --]
[-- Type: application/octet-stream, Size: 492 bytes --]

diff -urN emacs-26.1.orig/src/w32fns.c emacs-26.1/src/w32fns.c
--- emacs-26.1.orig/src/w32fns.c	2018-06-22 21:19:49.476879400 +0900
+++ emacs-26.1/src/w32fns.c	2018-06-26 18:00:54.780661600 +0900
@@ -4551,7 +4551,7 @@
 	 dialog boxes, such as the file selection dialog or font
 	 selection dialog.  So something else is needed to fix the
 	 former without breaking the latter.  See bug#11732.  */
-      break;
+      goto dflt;
 
     case WM_IME_ENDCOMPOSITION:
       ignore_ime_char = 0;

  parent reply	other threads:[~2018-06-26  9:10 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18  5:20 bug#11732: 24.1; Microsoft IME Japanese input problem xavier.dahan
2015-02-17 10:26 ` Fujii Hironori
2015-02-18 15:17   ` Eli Zaretskii
2015-02-19  2:03     ` Fujii Hironori
2015-02-19  6:44       ` Eli Zaretskii
     [not found]         ` <CALus1PmqiC8TnQTfcpVFD5ObjqbK_4hkOczRKmG1=+mkWXUHWQ@mail.gmail.com>
2015-02-19 11:44           ` Eli Zaretskii
2015-03-06 20:29             ` Eli Zaretskii
2015-03-06 22:37               ` Fujii Hironori
2015-03-07 10:53                 ` Eli Zaretskii
2015-03-09  2:13               ` Fujii Hironori
2015-03-09 16:30                 ` Eli Zaretskii
2018-06-26  9:10 ` Masayuki Hatta [this message]
2018-06-27 15:54   ` bug#11732: Follow-up to bug#11732 Eli Zaretskii
2018-06-28  8:04     ` martin rudalics
2018-06-28 10:13       ` Masayuki Hatta
2018-06-28 12:25         ` martin rudalics
2018-06-28 13:09           ` Eli Zaretskii
2018-06-28 10:11     ` Masayuki Hatta
2018-06-28 13:28       ` Eli Zaretskii
2018-06-28 19:17         ` Noam Postavsky
2018-06-28 19:24           ` Eli Zaretskii
2018-06-29  7:39             ` Masayuki Hatta
2018-06-29  8:43               ` martin rudalics
2018-06-29  8:59                 ` Eli Zaretskii
2018-06-30  3:14                 ` Masayuki Hatta
2018-06-30  7:46                   ` Eli Zaretskii
2018-06-30  8:30                     ` Masayuki Hatta
2018-06-29  8:56               ` Eli Zaretskii
2018-06-29  8:43     ` martin rudalics
2018-06-29  9:07       ` Eli Zaretskii
2018-06-30  8:06         ` martin rudalics
2018-06-30 11:32           ` Eli Zaretskii
2018-06-30 12:51             ` martin rudalics
2018-06-30 13:21               ` Eli Zaretskii
2018-07-01  9:00                 ` martin rudalics
2018-07-01 14:29                   ` Eli Zaretskii
2018-07-03  8:29                     ` martin rudalics
2018-07-03 18:50                       ` Eli Zaretskii
2018-07-07  7:45                         ` Tak Kunihiro
2018-07-07 10:00                           ` Eli Zaretskii
2018-07-07 10:21                             ` martin rudalics
2018-07-07 11:32                               ` Eli Zaretskii
2018-07-01 14:34             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAECZVPAXjLje9ED6fp1hJa4OPbBLd9nVsNMPB4xZ9njuDamF0Q@mail.gmail.com \
    --to=mhatta@gmail.com \
    --cc=11732@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).